All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/bash: fix naming of target-finalize-hook
@ 2023-03-03  9:37 Sebastian Weyer
  2023-03-05 18:22 ` Peter Korsgaard
  2023-03-15 13:06 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Sebastian Weyer @ 2023-03-03  9:37 UTC (permalink / raw)
  To: buildroot; +Cc: Sebastian Weyer

When the target-finalize-hook for bash was added in commit
311c9eebc4dcfb764e3a7082706daf68e0603188 in order to write bash into
/etc/shells, it was done at the same time as for package/mksh and it was
incorrectly copied and MKSH still appeared in the name of the hook.

The hook is now correctly named BASH_ADD_BASH_TO_SHELLS

Signed-off-by: Sebastian Weyer <sebastian.weyer@smile.fr>
---
 package/bash/bash.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/bash/bash.mk b/package/bash/bash.mk
index ec5e2d722f..9a73ed8c36 100644
--- a/package/bash/bash.mk
+++ b/package/bash/bash.mk
@@ -62,10 +62,10 @@ endif
 
 # Add /bin/bash to /etc/shells otherwise some login tools like dropbear
 # can reject the user connection. See man shells.
-define BASH_ADD_MKSH_TO_SHELLS
+define BASH_ADD_BASH_TO_SHELLS
 	grep -qsE '^/bin/bash$$' $(TARGET_DIR)/etc/shells \
 		|| echo "/bin/bash" >> $(TARGET_DIR)/etc/shells
 endef
-BASH_TARGET_FINALIZE_HOOKS += BASH_ADD_MKSH_TO_SHELLS
+BASH_TARGET_FINALIZE_HOOKS += BASH_ADD_BASH_TO_SHELLS
 
 $(eval $(autotools-package))
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/bash: fix naming of target-finalize-hook
  2023-03-03  9:37 [Buildroot] [PATCH 1/1] package/bash: fix naming of target-finalize-hook Sebastian Weyer
@ 2023-03-05 18:22 ` Peter Korsgaard
  2023-03-15 13:06 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2023-03-05 18:22 UTC (permalink / raw)
  To: Sebastian Weyer; +Cc: buildroot

>>>>> "Sebastian" == Sebastian Weyer <sebastian.weyer@smile.fr> writes:

 > When the target-finalize-hook for bash was added in commit
 > 311c9eebc4dcfb764e3a7082706daf68e0603188 in order to write bash into
 > /etc/shells, it was done at the same time as for package/mksh and it was
 > incorrectly copied and MKSH still appeared in the name of the hook.

 > The hook is now correctly named BASH_ADD_BASH_TO_SHELLS

 > Signed-off-by: Sebastian Weyer <sebastian.weyer@smile.fr>

Committed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/bash: fix naming of target-finalize-hook
  2023-03-03  9:37 [Buildroot] [PATCH 1/1] package/bash: fix naming of target-finalize-hook Sebastian Weyer
  2023-03-05 18:22 ` Peter Korsgaard
@ 2023-03-15 13:06 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2023-03-15 13:06 UTC (permalink / raw)
  To: Sebastian Weyer; +Cc: buildroot

>>>>> "Sebastian" == Sebastian Weyer <sebastian.weyer@smile.fr> writes:

 > When the target-finalize-hook for bash was added in commit
 > 311c9eebc4dcfb764e3a7082706daf68e0603188 in order to write bash into
 > /etc/shells, it was done at the same time as for package/mksh and it was
 > incorrectly copied and MKSH still appeared in the name of the hook.

 > The hook is now correctly named BASH_ADD_BASH_TO_SHELLS

 > Signed-off-by: Sebastian Weyer <sebastian.weyer@smile.fr>

Committed to 2022.11.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-03-15 13:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-03  9:37 [Buildroot] [PATCH 1/1] package/bash: fix naming of target-finalize-hook Sebastian Weyer
2023-03-05 18:22 ` Peter Korsgaard
2023-03-15 13:06 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.