All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@linux-m68k.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/32s: Setup the early hash table at all time.
Date: Thu, 29 Oct 2020 22:07:41 +0100	[thread overview]
Message-ID: <87wnz8vizm.fsf@igel.home> (raw)
In-Reply-To: <b8f8101c368b8a6451844a58d7bd7d83c14cf2aa.1601566529.git.christophe.leroy@csgroup.eu> (Christophe Leroy's message of "Thu, 1 Oct 2020 15:35:38 +0000 (UTC)")

On Okt 01 2020, Christophe Leroy wrote:

> At the time being, an early hash table is set up when
> CONFIG_KASAN is selected.
>
> There is nothing wrong with setting such an early hash table
> all the time, even if it is not used. This is a statically
> allocated 256 kB table which lies in the init data section.
>
> This makes the code simpler and may in the future allow to
> setup early IO mappings with fixmap instead of hard coding BATs.
>
> Put create_hpte() and flush_hash_pages() in the .ref.text section
> in order to avoid warning for the reference to early_hash[]. This
> reference is removed by MMU_init_hw_patch() before init memory is
> freed.

This breaks booting on the iBook G4.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

WARNING: multiple messages have this Message-ID (diff)
From: Andreas Schwab <schwab@linux-m68k.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: linuxppc-dev@lists.ozlabs.org, Paul Mackerras <paulus@samba.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/32s: Setup the early hash table at all time.
Date: Thu, 29 Oct 2020 22:07:41 +0100	[thread overview]
Message-ID: <87wnz8vizm.fsf@igel.home> (raw)
In-Reply-To: <b8f8101c368b8a6451844a58d7bd7d83c14cf2aa.1601566529.git.christophe.leroy@csgroup.eu> (Christophe Leroy's message of "Thu, 1 Oct 2020 15:35:38 +0000 (UTC)")

On Okt 01 2020, Christophe Leroy wrote:

> At the time being, an early hash table is set up when
> CONFIG_KASAN is selected.
>
> There is nothing wrong with setting such an early hash table
> all the time, even if it is not used. This is a statically
> allocated 256 kB table which lies in the init data section.
>
> This makes the code simpler and may in the future allow to
> setup early IO mappings with fixmap instead of hard coding BATs.
>
> Put create_hpte() and flush_hash_pages() in the .ref.text section
> in order to avoid warning for the reference to early_hash[]. This
> reference is removed by MMU_init_hw_patch() before init memory is
> freed.

This breaks booting on the iBook G4.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

  parent reply	other threads:[~2020-10-29 21:07 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-01 15:35 [PATCH] powerpc/32s: Setup the early hash table at all time Christophe Leroy
2020-10-01 15:35 ` Christophe Leroy
2020-10-09  6:03 ` Michael Ellerman
2020-10-09  6:03   ` Michael Ellerman
2020-10-29 21:07 ` Andreas Schwab [this message]
2020-10-29 21:07   ` Andreas Schwab
2020-10-30  5:19   ` Michael Ellerman
2020-10-30  5:19     ` Michael Ellerman
2020-10-30  9:09     ` Andreas Schwab
2020-10-30  9:09       ` Andreas Schwab
2020-10-30 13:00       ` Christophe Leroy
2020-10-30 13:00         ` Christophe Leroy
2020-10-30 13:11         ` Andreas Schwab
2020-10-30 13:11           ` Andreas Schwab
2020-11-03  7:41           ` Christophe Leroy
2020-11-03  7:41             ` Christophe Leroy
2020-11-03  8:43             ` Andreas Schwab
2020-11-03  8:43               ` Andreas Schwab
2020-11-03  8:56             ` Andreas Schwab
2020-11-03  8:56               ` Andreas Schwab
2020-11-03 18:58             ` Serge Belyshev
2020-11-03 18:58               ` Serge Belyshev
2020-11-04  6:44               ` Christophe Leroy
2020-11-04  6:44                 ` Christophe Leroy
2020-11-04  7:57                 ` Serge Belyshev
2020-11-04  7:57                   ` Serge Belyshev
2020-11-04  9:28                   ` Serge Belyshev
2020-11-04  9:28                     ` Serge Belyshev
2020-11-04 14:53                     ` Serge Belyshev
2020-11-04 14:53                       ` Serge Belyshev
2020-11-07  9:12   ` Christophe Leroy
2020-11-07  9:12     ` Christophe Leroy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wnz8vizm.fsf@igel.home \
    --to=schwab@linux-m68k.org \
    --cc=benh@kernel.crashing.org \
    --cc=christophe.leroy@csgroup.eu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.