* [PATCH] virtiofsd: Call qemu_init_exec_dir
@ 2020-10-02 12:40 Dr. David Alan Gilbert (git)
2020-10-02 13:11 ` Alex Bennée
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Dr. David Alan Gilbert (git) @ 2020-10-02 12:40 UTC (permalink / raw)
To: qemu-devel, alex.bennee, stefanha; +Cc: pbonzini
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Since fcb4f59c879 qemu_get_local_state_pathname relies on the
init_exec_dir, and virtiofsd asserts because we never set it.
Set it.
Reported-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
tools/virtiofsd/passthrough_ll.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c
index 0b229ebd57..cce983ca63 100644
--- a/tools/virtiofsd/passthrough_ll.c
+++ b/tools/virtiofsd/passthrough_ll.c
@@ -2839,6 +2839,8 @@ int main(int argc, char *argv[])
/* Don't mask creation mode, kernel already did that */
umask(0);
+ qemu_init_exec_dir(argv[0]);
+
pthread_mutex_init(&lo.mutex, NULL);
lo.inodes = g_hash_table_new(lo_key_hash, lo_key_equal);
lo.root.fd = -1;
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] virtiofsd: Call qemu_init_exec_dir
2020-10-02 12:40 [PATCH] virtiofsd: Call qemu_init_exec_dir Dr. David Alan Gilbert (git)
@ 2020-10-02 13:11 ` Alex Bennée
2020-10-05 13:54 ` Stefan Hajnoczi
2020-10-07 10:56 ` Dr. David Alan Gilbert
2 siblings, 0 replies; 4+ messages in thread
From: Alex Bennée @ 2020-10-02 13:11 UTC (permalink / raw)
To: Dr. David Alan Gilbert (git); +Cc: pbonzini, qemu-devel, stefanha
"Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> writes:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Since fcb4f59c879 qemu_get_local_state_pathname relies on the
> init_exec_dir, and virtiofsd asserts because we never set it.
> Set it.
>
> Reported-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Tested-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> tools/virtiofsd/passthrough_ll.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c
> index 0b229ebd57..cce983ca63 100644
> --- a/tools/virtiofsd/passthrough_ll.c
> +++ b/tools/virtiofsd/passthrough_ll.c
> @@ -2839,6 +2839,8 @@ int main(int argc, char *argv[])
> /* Don't mask creation mode, kernel already did that */
> umask(0);
>
> + qemu_init_exec_dir(argv[0]);
> +
> pthread_mutex_init(&lo.mutex, NULL);
> lo.inodes = g_hash_table_new(lo_key_hash, lo_key_equal);
> lo.root.fd = -1;
--
Alex Bennée
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] virtiofsd: Call qemu_init_exec_dir
2020-10-02 12:40 [PATCH] virtiofsd: Call qemu_init_exec_dir Dr. David Alan Gilbert (git)
2020-10-02 13:11 ` Alex Bennée
@ 2020-10-05 13:54 ` Stefan Hajnoczi
2020-10-07 10:56 ` Dr. David Alan Gilbert
2 siblings, 0 replies; 4+ messages in thread
From: Stefan Hajnoczi @ 2020-10-05 13:54 UTC (permalink / raw)
To: Dr. David Alan Gilbert (git); +Cc: pbonzini, alex.bennee, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 541 bytes --]
On Fri, Oct 02, 2020 at 01:40:15PM +0100, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Since fcb4f59c879 qemu_get_local_state_pathname relies on the
> init_exec_dir, and virtiofsd asserts because we never set it.
> Set it.
>
> Reported-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> tools/virtiofsd/passthrough_ll.c | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] virtiofsd: Call qemu_init_exec_dir
2020-10-02 12:40 [PATCH] virtiofsd: Call qemu_init_exec_dir Dr. David Alan Gilbert (git)
2020-10-02 13:11 ` Alex Bennée
2020-10-05 13:54 ` Stefan Hajnoczi
@ 2020-10-07 10:56 ` Dr. David Alan Gilbert
2 siblings, 0 replies; 4+ messages in thread
From: Dr. David Alan Gilbert @ 2020-10-07 10:56 UTC (permalink / raw)
To: qemu-devel, alex.bennee, stefanha; +Cc: pbonzini
* Dr. David Alan Gilbert (git) (dgilbert@redhat.com) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Since fcb4f59c879 qemu_get_local_state_pathname relies on the
> init_exec_dir, and virtiofsd asserts because we never set it.
> Set it.
>
> Reported-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Queued
> ---
> tools/virtiofsd/passthrough_ll.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c
> index 0b229ebd57..cce983ca63 100644
> --- a/tools/virtiofsd/passthrough_ll.c
> +++ b/tools/virtiofsd/passthrough_ll.c
> @@ -2839,6 +2839,8 @@ int main(int argc, char *argv[])
> /* Don't mask creation mode, kernel already did that */
> umask(0);
>
> + qemu_init_exec_dir(argv[0]);
> +
> pthread_mutex_init(&lo.mutex, NULL);
> lo.inodes = g_hash_table_new(lo_key_hash, lo_key_equal);
> lo.root.fd = -1;
> --
> 2.26.2
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-07 10:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-02 12:40 [PATCH] virtiofsd: Call qemu_init_exec_dir Dr. David Alan Gilbert (git)
2020-10-02 13:11 ` Alex Bennée
2020-10-05 13:54 ` Stefan Hajnoczi
2020-10-07 10:56 ` Dr. David Alan Gilbert
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.