* [PATCH] qemu: Do not include file if not exists
@ 2020-03-24 9:43 Oleksiy Obitotskyy
2020-03-24 13:03 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 4+ messages in thread
From: Oleksiy Obitotskyy @ 2020-03-24 9:43 UTC (permalink / raw)
To: qemu-devel; +Cc: Oleksiy Obitotskyy
Script configure checks for if_alg.h and check failed but
if_alg.h still included.
Upstream-Status: Submitted [<oobitots@cisco.com>]
Signed-off-by: Oleksiy Obitotskyy <oobitots@cisco.com>
---
linux-user/syscall.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 35f4146662..819774af0d 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -109,7 +109,9 @@
#include <linux/blkpg.h>
#include <netpacket/packet.h>
#include <linux/netlink.h>
+#if defined(CONFIG_AF_ALG)
#include <linux/if_alg.h>
+#endif
#include <linux/rtc.h>
#include <sound/asound.h>
#include "linux_loop.h"
--
2.19.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] qemu: Do not include file if not exists
2020-03-24 9:43 [PATCH] qemu: Do not include file if not exists Oleksiy Obitotskyy
@ 2020-03-24 13:03 ` Philippe Mathieu-Daudé
2020-03-25 8:52 ` Oleksiy Obitotskyy
0 siblings, 1 reply; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-03-24 13:03 UTC (permalink / raw)
To: Oleksiy Obitotskyy, qemu-devel, Laurent Vivier
On 3/24/20 10:43 AM, Oleksiy Obitotskyy wrote:
> Script configure checks for if_alg.h and check failed but
> if_alg.h still included.
>
> Upstream-Status: Submitted [<oobitots@cisco.com>]
^ Mainstream doesn't use such tag.
Otherwise:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Oleksiy Obitotskyy <oobitots@cisco.com>
> ---
> linux-user/syscall.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 35f4146662..819774af0d 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -109,7 +109,9 @@
> #include <linux/blkpg.h>
> #include <netpacket/packet.h>
> #include <linux/netlink.h>
> +#if defined(CONFIG_AF_ALG)
> #include <linux/if_alg.h>
> +#endif
> #include <linux/rtc.h>
> #include <sound/asound.h>
> #include "linux_loop.h"
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] qemu: Do not include file if not exists
2020-03-24 13:03 ` Philippe Mathieu-Daudé
@ 2020-03-25 8:52 ` Oleksiy Obitotskyy
2020-03-30 7:47 ` Markus Armbruster
0 siblings, 1 reply; 4+ messages in thread
From: Oleksiy Obitotskyy @ 2020-03-25 8:52 UTC (permalink / raw)
To: qemu-devel; +Cc: Oleksiy Obitotskyy
Script configure checks for if_alg.h and check failed but
if_alg.h still included.
Signed-off-by: Oleksiy Obitotskyy <oobitots@cisco.com>
---
linux-user/syscall.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 35f4146662..819774af0d 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -109,7 +109,9 @@
#include <linux/blkpg.h>
#include <netpacket/packet.h>
#include <linux/netlink.h>
+#if defined(CONFIG_AF_ALG)
#include <linux/if_alg.h>
+#endif
#include <linux/rtc.h>
#include <sound/asound.h>
#include "linux_loop.h"
--
2.19.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] qemu: Do not include file if not exists
2020-03-25 8:52 ` Oleksiy Obitotskyy
@ 2020-03-30 7:47 ` Markus Armbruster
0 siblings, 0 replies; 4+ messages in thread
From: Markus Armbruster @ 2020-03-30 7:47 UTC (permalink / raw)
To: Oleksiy Obitotskyy; +Cc: Riku Voipio, qemu-devel, Laurent Vivier
Cc'ing maintainers.
Oleksiy, this looks like a respin of your patch. Since it is buried in
the original thread, our patch processing automation won't pick it up,
and humans may well miss it, too. Next time, start a new thread, with
proper [PATCH v2] versioning in the subject, and cc: the maintainers
(use scripts/get_maintainer.pl to find them). Also collect the
Reviewed-by tags, if any, and explain what changed since the previous
version.
https://wiki.qemu.org/Contribute/SubmitAPatch
I know getting everything just right seems overwhelming at first. Don't
worry about making innocent mistakes, just learn from them :)
Thanks for your fix!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-30 7:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-24 9:43 [PATCH] qemu: Do not include file if not exists Oleksiy Obitotskyy
2020-03-24 13:03 ` Philippe Mathieu-Daudé
2020-03-25 8:52 ` Oleksiy Obitotskyy
2020-03-30 7:47 ` Markus Armbruster
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.