From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> To: Peter Zijlstra <peterz@infradead.org>, Will Deacon <will@kernel.org>, Andrew Morton <akpm@linux-foundation.org>, Nick Piggin <npiggin@gmail.com>, Peter Zijlstra <peterz@infradead.org> Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, "David S. Miller" <davem@davemloft.net>, Helge Deller <deller@gmx.de>, Geert Uytterhoeven <geert@linux-m68k.org>, Paul Burton <paulburton@kernel.org>, Tony Luck <tony.luck@intel.com>, Richard Henderson <rth@twiddle.net>, Nick Hu <nickhu@andestech.com>, Paul Walmsley <paul.walmsley@sifive.com> Subject: Re: [PATCH 05/17] asm-generic/tlb: Rename HAVE_RCU_TABLE_NO_INVALIDATE Date: Mon, 16 Dec 2019 18:01:58 +0530 [thread overview] Message-ID: <87woawzc1t.fsf@linux.ibm.com> (raw) In-Reply-To: <20191211122955.940455408@infradead.org> Peter Zijlstra <peterz@infradead.org> writes: > Towards a more consistent naming scheme. > > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> > --- > arch/Kconfig | 3 ++- > arch/powerpc/Kconfig | 2 +- > arch/sparc/Kconfig | 2 +- > include/asm-generic/tlb.h | 2 +- > mm/mmu_gather.c | 2 +- > 5 files changed, 6 insertions(+), 5 deletions(-) > > --- a/arch/Kconfig > +++ b/arch/Kconfig > @@ -396,8 +396,9 @@ config HAVE_ARCH_JUMP_LABEL_RELATIVE > config MMU_GATHER_RCU_TABLE_FREE > bool > > -config HAVE_RCU_TABLE_NO_INVALIDATE > +config MMU_GATHER_NO_TABLE_INVALIDATE > bool > + depends on MMU_GATHER_RCU_TABLE_FREE Can we drop this Kernel config option instead use MMU_GATHER_RCU_TABLE_FREE? IMHO reducing the kernel config related to mmu_gather can reduce the complexity. > > config HAVE_MMU_GATHER_PAGE_SIZE > bool > --- a/arch/powerpc/Kconfig > +++ b/arch/powerpc/Kconfig > @@ -223,7 +223,7 @@ config PPC > select HAVE_PERF_REGS > select HAVE_PERF_USER_STACK_DUMP > select MMU_GATHER_RCU_TABLE_FREE if SMP > - select HAVE_RCU_TABLE_NO_INVALIDATE if MMU_GATHER_RCU_TABLE_FREE > + select MMU_GATHER_NO_TABLE_INVALIDATE if MMU_GATHER_RCU_TABLE_FREE > select HAVE_MMU_GATHER_PAGE_SIZE > select HAVE_REGS_AND_STACK_ACCESS_API > select HAVE_RELIABLE_STACKTRACE if PPC_BOOK3S_64 && CPU_LITTLE_ENDIAN > --- a/arch/sparc/Kconfig > +++ b/arch/sparc/Kconfig > @@ -65,7 +65,7 @@ config SPARC64 > select HAVE_KRETPROBES > select HAVE_KPROBES > select MMU_GATHER_RCU_TABLE_FREE if SMP > - select HAVE_RCU_TABLE_NO_INVALIDATE if MMU_GATHER_RCU_TABLE_FREE > + select MMU_GATHER_NO_TABLE_INVALIDATE if MMU_GATHER_RCU_TABLE_FREE > select HAVE_MEMBLOCK_NODE_MAP > select HAVE_ARCH_TRANSPARENT_HUGEPAGE > select HAVE_DYNAMIC_FTRACE > --- a/include/asm-generic/tlb.h > +++ b/include/asm-generic/tlb.h > @@ -137,7 +137,7 @@ > * When used, an architecture is expected to provide __tlb_remove_table() > * which does the actual freeing of these pages. > * > - * HAVE_RCU_TABLE_NO_INVALIDATE > + * MMU_GATHER_NO_TABLE_INVALIDATE > * > * This makes MMU_GATHER_RCU_TABLE_FREE avoid calling tlb_flush_mmu_tlbonly() before > * freeing the page-table pages. This can be avoided if you use > --- a/mm/mmu_gather.c > +++ b/mm/mmu_gather.c > @@ -102,7 +102,7 @@ bool __tlb_remove_page_size(struct mmu_g > */ > static inline void tlb_table_invalidate(struct mmu_gather *tlb) > { > -#ifndef CONFIG_HAVE_RCU_TABLE_NO_INVALIDATE > +#ifndef CONFIG_MMU_GATHER_NO_TABLE_INVALIDATE > /* > * Invalidate page-table caches used by hardware walkers. Then we still > * need to RCU-sched wait while freeing the pages because software
WARNING: multiple messages have this Message-ID (diff)
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> To: Peter Zijlstra <peterz@infradead.org>, Will Deacon <will@kernel.org>, Andrew Morton <akpm@linux-foundation.org>, Nick Piggin <npiggin@gmail.com>Peter Zijlstra <peterz@infradead.org> Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, "David S. Miller" <davem@davemloft.net>, Helge Deller <deller@gmx.de>, Geert Uytterhoeven <geert@linux-m68k.org>, Paul Burton <paulburton@kernel.org>, Tony Luck <tony.luck@intel.com>, Richard Henderson <rth@twiddle.net>, Nick Hu <nickhu@andestech.com>, Paul Walmsley <paul.walmsley@sifive.com> Subject: Re: [PATCH 05/17] asm-generic/tlb: Rename HAVE_RCU_TABLE_NO_INVALIDATE Date: Mon, 16 Dec 2019 18:01:58 +0530 [thread overview] Message-ID: <87woawzc1t.fsf@linux.ibm.com> (raw) In-Reply-To: <20191211122955.940455408@infradead.org> Peter Zijlstra <peterz@infradead.org> writes: > Towards a more consistent naming scheme. > > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> > --- > arch/Kconfig | 3 ++- > arch/powerpc/Kconfig | 2 +- > arch/sparc/Kconfig | 2 +- > include/asm-generic/tlb.h | 2 +- > mm/mmu_gather.c | 2 +- > 5 files changed, 6 insertions(+), 5 deletions(-) > > --- a/arch/Kconfig > +++ b/arch/Kconfig > @@ -396,8 +396,9 @@ config HAVE_ARCH_JUMP_LABEL_RELATIVE > config MMU_GATHER_RCU_TABLE_FREE > bool > > -config HAVE_RCU_TABLE_NO_INVALIDATE > +config MMU_GATHER_NO_TABLE_INVALIDATE > bool > + depends on MMU_GATHER_RCU_TABLE_FREE Can we drop this Kernel config option instead use MMU_GATHER_RCU_TABLE_FREE? IMHO reducing the kernel config related to mmu_gather can reduce the complexity. > > config HAVE_MMU_GATHER_PAGE_SIZE > bool > --- a/arch/powerpc/Kconfig > +++ b/arch/powerpc/Kconfig > @@ -223,7 +223,7 @@ config PPC > select HAVE_PERF_REGS > select HAVE_PERF_USER_STACK_DUMP > select MMU_GATHER_RCU_TABLE_FREE if SMP > - select HAVE_RCU_TABLE_NO_INVALIDATE if MMU_GATHER_RCU_TABLE_FREE > + select MMU_GATHER_NO_TABLE_INVALIDATE if MMU_GATHER_RCU_TABLE_FREE > select HAVE_MMU_GATHER_PAGE_SIZE > select HAVE_REGS_AND_STACK_ACCESS_API > select HAVE_RELIABLE_STACKTRACE if PPC_BOOK3S_64 && CPU_LITTLE_ENDIAN > --- a/arch/sparc/Kconfig > +++ b/arch/sparc/Kconfig > @@ -65,7 +65,7 @@ config SPARC64 > select HAVE_KRETPROBES > select HAVE_KPROBES > select MMU_GATHER_RCU_TABLE_FREE if SMP > - select HAVE_RCU_TABLE_NO_INVALIDATE if MMU_GATHER_RCU_TABLE_FREE > + select MMU_GATHER_NO_TABLE_INVALIDATE if MMU_GATHER_RCU_TABLE_FREE > select HAVE_MEMBLOCK_NODE_MAP > select HAVE_ARCH_TRANSPARENT_HUGEPAGE > select HAVE_DYNAMIC_FTRACE > --- a/include/asm-generic/tlb.h > +++ b/include/asm-generic/tlb.h > @@ -137,7 +137,7 @@ > * When used, an architecture is expected to provide __tlb_remove_table() > * which does the actual freeing of these pages. > * > - * HAVE_RCU_TABLE_NO_INVALIDATE > + * MMU_GATHER_NO_TABLE_INVALIDATE > * > * This makes MMU_GATHER_RCU_TABLE_FREE avoid calling tlb_flush_mmu_tlbonly() before > * freeing the page-table pages. This can be avoided if you use > --- a/mm/mmu_gather.c > +++ b/mm/mmu_gather.c > @@ -102,7 +102,7 @@ bool __tlb_remove_page_size(struct mmu_g > */ > static inline void tlb_table_invalidate(struct mmu_gather *tlb) > { > -#ifndef CONFIG_HAVE_RCU_TABLE_NO_INVALIDATE > +#ifndef CONFIG_MMU_GATHER_NO_TABLE_INVALIDATE > /* > * Invalidate page-table caches used by hardware walkers. Then we still > * need to RCU-sched wait while freeing the pages because software
next prev parent reply other threads:[~2019-12-16 12:33 UTC|newest] Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-11 12:07 [PATCH 00/17] Fixup page directory freeing Peter Zijlstra 2019-12-11 12:07 ` [PATCH 01/17] sh/tlb: Fix PGTABLE_LEVELS > 2 Peter Zijlstra 2019-12-11 12:07 ` [PATCH 02/17] asm-gemeric/tlb: Remove stray function declarations Peter Zijlstra 2019-12-11 13:19 ` Geert Uytterhoeven 2019-12-11 13:19 ` Geert Uytterhoeven 2019-12-11 12:07 ` [PATCH 03/17] asm-generic/tlb: Add missing CONFIG symbol Peter Zijlstra 2019-12-11 12:07 ` [PATCH 04/17] asm-generic/tlb: Rename HAVE_RCU_TABLE_FREE Peter Zijlstra 2019-12-11 12:07 ` [PATCH 05/17] asm-generic/tlb: Rename HAVE_RCU_TABLE_NO_INVALIDATE Peter Zijlstra 2019-12-16 12:31 ` Aneesh Kumar K.V [this message] 2019-12-16 12:31 ` Aneesh Kumar K.V 2019-12-16 12:37 ` Peter Zijlstra 2019-12-16 13:13 ` Aneesh Kumar K.V 2019-12-16 13:20 ` Peter Zijlstra 2019-12-16 13:40 ` Aneesh Kumar K.V 2019-12-16 13:54 ` Aneesh Kumar K.V 2019-12-16 14:50 ` Peter Zijlstra 2019-12-16 15:14 ` Peter Zijlstra 2019-12-16 15:14 ` Peter Zijlstra 2019-12-16 15:30 ` Peter Zijlstra 2019-12-16 17:00 ` Aneesh Kumar K.V 2019-12-17 8:51 ` Peter Zijlstra 2019-12-16 14:00 ` Peter Zijlstra 2019-12-11 12:07 ` [PATCH 06/17] asm-generic/tlb: Rename HAVE_MMU_GATHER_PAGE_SIZE Peter Zijlstra 2019-12-11 12:07 ` [PATCH 07/17] asm-generic/tlb: Rename HAVE_MMU_GATHER_NO_GATHER Peter Zijlstra 2019-12-11 12:07 ` [PATCH 08/17] asm-generic/tlb: Provide MMU_GATHER_TABLE_FREE Peter Zijlstra 2019-12-12 9:30 ` Peter Zijlstra 2019-12-12 9:32 ` [PATCH mk-II " Peter Zijlstra 2020-01-26 15:52 ` Guenter Roeck 2020-01-27 8:11 ` Peter Zijlstra 2020-01-27 8:13 ` Aneesh Kumar K.V 2020-01-27 13:05 ` Peter Zijlstra 2020-01-27 13:42 ` Aneesh Kumar K.V 2019-12-11 12:07 ` [PATCH 09/17] sh/tlb: Fix __pmd_free_tlb() Peter Zijlstra 2019-12-11 12:07 ` [PATCH 10/17] sparc32/tlb: Fix __p*_free_tlb() Peter Zijlstra 2019-12-11 12:07 ` [PATCH 11/17] parisc/tlb: " Peter Zijlstra 2019-12-11 12:07 ` [PATCH 12/17] m68k/tlb: " Peter Zijlstra 2019-12-11 12:07 ` [PATCH 13/17] mips/tlb: " Peter Zijlstra 2019-12-11 12:07 ` [PATCH 14/17] ia64/tlb: " Peter Zijlstra 2019-12-11 12:07 ` [PATCH 15/17] alpha/tlb: " Peter Zijlstra 2019-12-11 12:07 ` [PATCH 16/17] nds32/tlb: " Peter Zijlstra 2019-12-11 12:07 ` [PATCH 17/17] riscv/tlb: " Peter Zijlstra
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87woawzc1t.fsf@linux.ibm.com \ --to=aneesh.kumar@linux.ibm.com \ --cc=akpm@linux-foundation.org \ --cc=dalias@libc.org \ --cc=davem@davemloft.net \ --cc=deller@gmx.de \ --cc=geert@linux-m68k.org \ --cc=linux-arch@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=nickhu@andestech.com \ --cc=npiggin@gmail.com \ --cc=paul.walmsley@sifive.com \ --cc=paulburton@kernel.org \ --cc=peterz@infradead.org \ --cc=rth@twiddle.net \ --cc=tony.luck@intel.com \ --cc=will@kernel.org \ --cc=ysato@users.sourceforge.jp \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.