All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] support/testing: drop docstring in TestPythonPackageBase::test_run()
@ 2018-12-08 14:36 Thomas Petazzoni
  2018-12-08 19:50 ` Peter Korsgaard
  0 siblings, 1 reply; 2+ messages in thread
From: Thomas Petazzoni @ 2018-12-08 14:36 UTC (permalink / raw)
  To: buildroot

Having a docstring in the test_run() method clutters the "run-tests
-l" output:

test_run (tests.package.test_python_crossbar.TestPythonPy3Crossbar)
Test a python package. ... ok
[...]
test_run (tests.package.test_python_pexpect.TestPythonPy2Pexpect)
Test a python package. ... ok
test_run (tests.package.test_python_pexpect.TestPythonPy3Pexpect)
Test a python package. ... ok
test_run (tests.package.test_python_twisted.TestPythonPy2Twisted)
Test a python package. ... ok
test_run (tests.package.test_python_twisted.TestPythonPy3Twisted)
Test a python package. ... ok
test_run (tests.package.test_python_pynacl.TestPythonPy2Pynacl)
Test a python package. ... ok
test_run (tests.package.test_python_pynacl.TestPythonPy3Pynacl)
Test a python package. ... ok

So let's simply drop this docstring that is not particularly useful.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 support/testing/tests/package/test_python.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/support/testing/tests/package/test_python.py b/support/testing/tests/package/test_python.py
index c422bdbf50..bcd363ad1e 100644
--- a/support/testing/tests/package/test_python.py
+++ b/support/testing/tests/package/test_python.py
@@ -120,7 +120,6 @@ class TestPythonPackageBase(TestPythonBase):
             self.assertEqual(exit_code, 0)
 
     def test_run(self):
-        """Test a python package."""
         self.login()
         self.check_sample_scripts_exist()
         self.run_sample_scripts()
-- 
2.19.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH] support/testing: drop docstring in TestPythonPackageBase::test_run()
  2018-12-08 14:36 [Buildroot] [PATCH] support/testing: drop docstring in TestPythonPackageBase::test_run() Thomas Petazzoni
@ 2018-12-08 19:50 ` Peter Korsgaard
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2018-12-08 19:50 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > Having a docstring in the test_run() method clutters the "run-tests
 > -l" output:

 > test_run (tests.package.test_python_crossbar.TestPythonPy3Crossbar)
 > Test a python package. ... ok
 > [...]
 > test_run (tests.package.test_python_pexpect.TestPythonPy2Pexpect)
 > Test a python package. ... ok
 > test_run (tests.package.test_python_pexpect.TestPythonPy3Pexpect)
 > Test a python package. ... ok
 > test_run (tests.package.test_python_twisted.TestPythonPy2Twisted)
 > Test a python package. ... ok
 > test_run (tests.package.test_python_twisted.TestPythonPy3Twisted)
 > Test a python package. ... ok
 > test_run (tests.package.test_python_pynacl.TestPythonPy2Pynacl)
 > Test a python package. ... ok
 > test_run (tests.package.test_python_pynacl.TestPythonPy3Pynacl)
 > Test a python package. ... ok

 > So let's simply drop this docstring that is not particularly useful.

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-12-08 19:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-08 14:36 [Buildroot] [PATCH] support/testing: drop docstring in TestPythonPackageBase::test_run() Thomas Petazzoni
2018-12-08 19:50 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.