All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] libtomcrypt: fix headers installation path
@ 2018-04-29 18:29 Baruch Siach
  2018-04-29 19:37 ` Peter Korsgaard
  2018-05-01  7:33 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Baruch Siach @ 2018-04-29 18:29 UTC (permalink / raw)
  To: buildroot

libtomcrypt installs its headers by default in /usr/local/include under
the staging sysroot. This patch is not in the default search patch of
some toolchains. This breaks the build of dropbear. Set the PREFIX make
variable to fix that.

While at it, split the long install command for better readability.

Fixes (dropbear):
http://autobuild.buildroot.net/results/215/2157679e276623ae875d1b31f3e5a68caf586536/
http://autobuild.buildroot.net/results/956/956d254675e6500c19c3bb7ccdf12ce136858720/
http://autobuild.buildroot.net/results/01e/01ec89a81c4ec6e36e2f81b5a9394050a91df654/

Cc: Francois Perrad <francois.perrad@gadz.org>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 package/libtomcrypt/libtomcrypt.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/package/libtomcrypt/libtomcrypt.mk b/package/libtomcrypt/libtomcrypt.mk
index 974ef3f2f2fd..ff6222cc91ee 100644
--- a/package/libtomcrypt/libtomcrypt.mk
+++ b/package/libtomcrypt/libtomcrypt.mk
@@ -20,7 +20,9 @@ define LIBTOMCRYPT_BUILD_CMDS
 endef
 
 define LIBTOMCRYPT_INSTALL_STAGING_CMDS
-	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR="$(STAGING_DIR)" NODOCS=1 INSTALL_USER=$(shell id -u) INSTALL_GROUP=$(shell id -g) install
+	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR="$(STAGING_DIR)" \
+		PREFIX=/usr NODOCS=1 INSTALL_USER=$(shell id -u) \
+		INSTALL_GROUP=$(shell id -g) install
 endef
 
 $(eval $(generic-package))
-- 
2.17.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] libtomcrypt: fix headers installation path
  2018-04-29 18:29 [Buildroot] [PATCH] libtomcrypt: fix headers installation path Baruch Siach
@ 2018-04-29 19:37 ` Peter Korsgaard
  2018-05-01  7:33 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2018-04-29 19:37 UTC (permalink / raw)
  To: buildroot

>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:

 > libtomcrypt installs its headers by default in /usr/local/include under
 > the staging sysroot. This patch is not in the default search patch of

s/patch/path/.

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] libtomcrypt: fix headers installation path
  2018-04-29 18:29 [Buildroot] [PATCH] libtomcrypt: fix headers installation path Baruch Siach
  2018-04-29 19:37 ` Peter Korsgaard
@ 2018-05-01  7:33 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2018-05-01  7:33 UTC (permalink / raw)
  To: buildroot

>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:

 > libtomcrypt installs its headers by default in /usr/local/include under
 > the staging sysroot. This patch is not in the default search patch of
 > some toolchains. This breaks the build of dropbear. Set the PREFIX make
 > variable to fix that.

 > While at it, split the long install command for better readability.

 > Fixes (dropbear):
 > http://autobuild.buildroot.net/results/215/2157679e276623ae875d1b31f3e5a68caf586536/
 > http://autobuild.buildroot.net/results/956/956d254675e6500c19c3bb7ccdf12ce136858720/
 > http://autobuild.buildroot.net/results/01e/01ec89a81c4ec6e36e2f81b5a9394050a91df654/

 > Cc: Francois Perrad <francois.perrad@gadz.org>
 > Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Committed to 2018.02.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-05-01  7:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-29 18:29 [Buildroot] [PATCH] libtomcrypt: fix headers installation path Baruch Siach
2018-04-29 19:37 ` Peter Korsgaard
2018-05-01  7:33 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.