All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@kernel.org>
To: Romain Izard <romain.izard.pro@gmail.com>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Ludovic Desroches <ludovic.desroches@microchip.com>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
	Romain Izard <romain.izard.pro@gmail.com>
Subject: Re: [PATCH 1/3] usb: gadget: udc: atmel: GPIO inversion is handled by gpiod
Date: Wed, 25 Apr 2018 12:53:43 +0300	[thread overview]
Message-ID: <87wowvhas8.fsf@linux.intel.com> (raw)
In-Reply-To: <20180416093405.16612-2-romain.izard.pro@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 403 bytes --]

Romain Izard <romain.izard.pro@gmail.com> writes:

> When converting to GPIO descriptors, gpiod_get_value automatically
> handles the line inversion flags from the device tree.
>
> Do not invert the line twice.
>
> Fixes: 3df034081021fa4b6967ce3364bc7d867ec1c870

your fixes line is incorrect. Please fix and resend. While at that,
please collect Acked-bys and Tested-bys, etc.

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@kernel.org>
To: Romain Izard <romain.izard.pro@gmail.com>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Ludovic Desroches <ludovic.desroches@microchip.com>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org
Subject: [1/3] usb: gadget: udc: atmel: GPIO inversion is handled by gpiod
Date: Wed, 25 Apr 2018 12:53:43 +0300	[thread overview]
Message-ID: <87wowvhas8.fsf@linux.intel.com> (raw)

Romain Izard <romain.izard.pro@gmail.com> writes:

> When converting to GPIO descriptors, gpiod_get_value automatically
> handles the line inversion flags from the device tree.
>
> Do not invert the line twice.
>
> Fixes: 3df034081021fa4b6967ce3364bc7d867ec1c870

your fixes line is incorrect. Please fix and resend. While at that,
please collect Acked-bys and Tested-bys, etc.

WARNING: multiple messages have this Message-ID (diff)
From: balbi@kernel.org (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] usb: gadget: udc: atmel: GPIO inversion is handled by gpiod
Date: Wed, 25 Apr 2018 12:53:43 +0300	[thread overview]
Message-ID: <87wowvhas8.fsf@linux.intel.com> (raw)
In-Reply-To: <20180416093405.16612-2-romain.izard.pro@gmail.com>

Romain Izard <romain.izard.pro@gmail.com> writes:

> When converting to GPIO descriptors, gpiod_get_value automatically
> handles the line inversion flags from the device tree.
>
> Do not invert the line twice.
>
> Fixes: 3df034081021fa4b6967ce3364bc7d867ec1c870

your fixes line is incorrect. Please fix and resend. While at that,
please collect Acked-bys and Tested-bys, etc.

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180425/d7365672/attachment.sig>

  parent reply	other threads:[~2018-04-25  9:53 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-16  9:34 [PATCH 0/3] Fix an Atmel USBA UDC issue introducted in 4.17-rc1 Romain Izard
2018-04-16  9:34 ` Romain Izard
2018-04-16  9:34 ` [PATCH 1/3] usb: gadget: udc: atmel: GPIO inversion is handled by gpiod Romain Izard
2018-04-16  9:34   ` Romain Izard
2018-04-16  9:34   ` [1/3] " Romain Izard
2018-04-16 11:42   ` [PATCH 1/3] " Ludovic Desroches
2018-04-16 11:42     ` Ludovic Desroches
2018-04-16 11:42     ` [1/3] " Ludovic Desroches
2018-04-25  9:53   ` Felipe Balbi [this message]
2018-04-25  9:53     ` [PATCH 1/3] " Felipe Balbi
2018-04-25  9:53     ` [1/3] " Felipe Balbi
2018-04-16  9:34 ` [PATCH 2/3] usb: gadget: udc: atmel: Remove obsolete include Romain Izard
2018-04-16  9:34   ` Romain Izard
2018-04-16  9:34   ` [2/3] " Romain Izard
2018-04-16 11:44   ` [PATCH 2/3] " Ludovic Desroches
2018-04-16 11:44     ` Ludovic Desroches
2018-04-16 11:44     ` [2/3] " Ludovic Desroches
2018-04-16  9:34 ` [PATCH 3/3] usb: gadget: udc: atmel: Fix indenting Romain Izard
2018-04-16  9:34   ` Romain Izard
2018-04-16  9:34   ` [3/3] " Romain Izard
2018-04-16 11:44   ` [PATCH 3/3] " Ludovic Desroches
2018-04-16 11:44     ` Ludovic Desroches
2018-04-16 11:44     ` [3/3] " Ludovic Desroches
2018-04-17  8:24 ` [PATCH 0/3] Fix an Atmel USBA UDC issue introducted in 4.17-rc1 Nicolas Ferre
2018-04-17  8:24   ` Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wowvhas8.fsf@linux.intel.com \
    --to=balbi@kernel.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=ludovic.desroches@microchip.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=romain.izard.pro@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.