* [PATCH] wcn36xx: Remove unnecessary rcu_read_unlock in wcn36xx_bss_info_changed
@ 2017-10-08 13:06 Jia-Ju Bai
2017-10-11 6:54 ` Bjorn Andersson
2017-10-27 14:00 ` Kalle Valo
0 siblings, 2 replies; 6+ messages in thread
From: Jia-Ju Bai @ 2017-10-08 13:06 UTC (permalink / raw)
To: k.eugene.e, kvalo
Cc: wcn36xx, linux-wireless, netdev, linux-kernel, Jia-Ju Bai
No rcu_read_lock is called, but rcu_read_unlock is still called.
Thus rcu_read_unlock should be removed.
Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
---
drivers/net/wireless/ath/wcn36xx/main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c
index 35bd50b..b83f01d 100644
--- a/drivers/net/wireless/ath/wcn36xx/main.c
+++ b/drivers/net/wireless/ath/wcn36xx/main.c
@@ -812,7 +812,6 @@ static void wcn36xx_bss_info_changed(struct ieee80211_hw *hw,
if (!sta) {
wcn36xx_err("sta %pM is not found\n",
bss_conf->bssid);
- rcu_read_unlock();
goto out;
}
sta_priv = wcn36xx_sta_to_priv(sta);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] wcn36xx: Remove unnecessary rcu_read_unlock in wcn36xx_bss_info_changed
2017-10-08 13:06 [PATCH] wcn36xx: Remove unnecessary rcu_read_unlock in wcn36xx_bss_info_changed Jia-Ju Bai
@ 2017-10-11 6:54 ` Bjorn Andersson
2017-10-11 8:28 ` Kalle Valo
2017-10-27 14:00 ` Kalle Valo
1 sibling, 1 reply; 6+ messages in thread
From: Bjorn Andersson @ 2017-10-11 6:54 UTC (permalink / raw)
To: Jia-Ju Bai
Cc: k.eugene.e, kvalo, wcn36xx, linux-wireless, linux-kernel, netdev
On Sun 08 Oct 06:06 PDT 2017, Jia-Ju Bai wrote:
> No rcu_read_lock is called, but rcu_read_unlock is still called.
> Thus rcu_read_unlock should be removed.
>
Thanks, not sure how I could miss that one. Kalle can you please include
this in a v4.14-rc pull request?
:
Fixes: 39efc7cc7ccf ("wcn36xx: Introduce mutual exclusion of fw configuration")
> Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> drivers/net/wireless/ath/wcn36xx/main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c
> index 35bd50b..b83f01d 100644
> --- a/drivers/net/wireless/ath/wcn36xx/main.c
> +++ b/drivers/net/wireless/ath/wcn36xx/main.c
> @@ -812,7 +812,6 @@ static void wcn36xx_bss_info_changed(struct ieee80211_hw *hw,
> if (!sta) {
> wcn36xx_err("sta %pM is not found\n",
> bss_conf->bssid);
> - rcu_read_unlock();
> goto out;
> }
> sta_priv = wcn36xx_sta_to_priv(sta);
> --
> 1.7.9.5
>
>
>
> _______________________________________________
> wcn36xx mailing list
> wcn36xx@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/wcn36xx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] wcn36xx: Remove unnecessary rcu_read_unlock in wcn36xx_bss_info_changed
2017-10-11 6:54 ` Bjorn Andersson
@ 2017-10-11 8:28 ` Kalle Valo
0 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2017-10-11 8:28 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Jia-Ju Bai, k.eugene.e, wcn36xx, linux-wireless, linux-kernel, netdev
Bjorn Andersson <bjorn.andersson@linaro.org> writes:
> On Sun 08 Oct 06:06 PDT 2017, Jia-Ju Bai wrote:
>
>> No rcu_read_lock is called, but rcu_read_unlock is still called.
>> Thus rcu_read_unlock should be removed.
>>=20
>
> Thanks, not sure how I could miss that one. Kalle can you please include
> this in a v4.14-rc pull request?
>
>
> :
>
> Fixes: 39efc7cc7ccf ("wcn36xx: Introduce mutual exclusion of fw configura=
tion")
>
>> Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
>
> Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Ok, I'll queue this to 4.14.
--=20
Kalle Valo=
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] wcn36xx: Remove unnecessary rcu_read_unlock in wcn36xx_bss_info_changed
@ 2017-10-11 8:28 ` Kalle Valo
0 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2017-10-11 8:28 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Jia-Ju Bai, k.eugene.e, wcn36xx, linux-wireless, linux-kernel, netdev
Bjorn Andersson <bjorn.andersson@linaro.org> writes:
> On Sun 08 Oct 06:06 PDT 2017, Jia-Ju Bai wrote:
>
>> No rcu_read_lock is called, but rcu_read_unlock is still called.
>> Thus rcu_read_unlock should be removed.
>>
>
> Thanks, not sure how I could miss that one. Kalle can you please include
> this in a v4.14-rc pull request?
>
>
> :
>
> Fixes: 39efc7cc7ccf ("wcn36xx: Introduce mutual exclusion of fw configuration")
>
>> Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
>
> Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Ok, I'll queue this to 4.14.
--
Kalle Valo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: wcn36xx: Remove unnecessary rcu_read_unlock in wcn36xx_bss_info_changed
@ 2017-10-27 14:00 ` Kalle Valo
0 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2017-10-27 14:00 UTC (permalink / raw)
To: Jia-Ju Bai
Cc: k.eugene.e, kvalo, wcn36xx, linux-wireless, netdev, linux-kernel,
Jia-Ju Bai
Jia-Ju Bai <baijiaju1990@163.com> wrote:
> No rcu_read_lock is called, but rcu_read_unlock is still called.
> Thus rcu_read_unlock should be removed.
>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
> Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Patch applied to ath-current branch of ath.git, thanks.
c0d5adc35c0b wcn36xx: Remove unnecessary rcu_read_unlock in wcn36xx_bss_info_changed
--
https://patchwork.kernel.org/patch/9991827/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: wcn36xx: Remove unnecessary rcu_read_unlock in wcn36xx_bss_info_changed
@ 2017-10-27 14:00 ` Kalle Valo
0 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2017-10-27 14:00 UTC (permalink / raw)
To: Jia-Ju Bai
Cc: k.eugene.e-Re5JQEeQqe8AvxtiuMwx3w, kvalo-sgV2jX0FEOL9JmXXK+q4OQ,
wcn36xx-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-wireless-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Jia-Ju Bai
Jia-Ju Bai <baijiaju1990-9Onoh4P/yGk@public.gmane.org> wrote:
> No rcu_read_lock is called, but rcu_read_unlock is still called.
> Thus rcu_read_unlock should be removed.
>
> Signed-off-by: Jia-Ju Bai <baijiaju1990-9Onoh4P/yGk@public.gmane.org>
> Acked-by: Bjorn Andersson <bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> Signed-off-by: Kalle Valo <kvalo-A+ZNKFmMK5xy9aJCnZT0Uw@public.gmane.org>
Patch applied to ath-current branch of ath.git, thanks.
c0d5adc35c0b wcn36xx: Remove unnecessary rcu_read_unlock in wcn36xx_bss_info_changed
--
https://patchwork.kernel.org/patch/9991827/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-10-27 14:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-08 13:06 [PATCH] wcn36xx: Remove unnecessary rcu_read_unlock in wcn36xx_bss_info_changed Jia-Ju Bai
2017-10-11 6:54 ` Bjorn Andersson
2017-10-11 8:28 ` Kalle Valo
2017-10-11 8:28 ` Kalle Valo
2017-10-27 14:00 ` Kalle Valo
2017-10-27 14:00 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.