All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Axtens <dja@axtens.net>
To: Michael Ellerman <mpe@ellerman.id.au>,
	linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org
Cc: gabriele.paoloni@huawei.com, airlied@linux.ie,
	catalin.marinas@arm.com, will.deacon@arm.com,
	z.liuxinliang@hisilicon.com, bhelgaas@google.com,
	alex.williamson@redhat.com, zourongrong@gmail.com,
	Brian King <brking@linux.vnet.ibm.com>,
	daniel.vetter@intel.com
Subject: Re: [PATCH 3/3] powerpc: replace vga_fixup() with generic code
Date: Tue, 08 Aug 2017 09:01:06 +1000	[thread overview]
Message-ID: <87wp6fq8y5.fsf@linkitivity.dja.id.au> (raw)
In-Reply-To: <87efsnq217.fsf@concordia.ellerman.id.au>

Michael Ellerman <mpe@ellerman.id.au> writes:

> Daniel Axtens <dja@axtens.net> writes:
>
>> Currently, we do a PCI fixup to mark a default card so that Xorg
>> autoconfiguration works.
>>
>> There is a new generic method to do this sort of vga fixup, and
>> it occurs by default.
>>
>> Drop our old method.
>>
>> This method is different:
>>  - it will only mark a card as default if a driver is bound
>>  - the marking will happen at late_initcall time, or even later
>>    if a card is enabled later on (via an ENABLE hook). Currently
>>    things are enabled in a FINAL hook.
>>
>> This *does* change behaviour under some circumstances.
>>
>> For example, pseries_le_defconfig doesn't have DRM drivers for
>> many of the qemu GPU models, including the 'standard' vga.
>
> Should we enable them/it?

Hard to say.

The 'standard' vga module (bochs_drm) was blacklisted by Ubuntu -
apparently at IBM's request [0] - some years back. Even if you
un-blacklist it, I had trouble with getting it and the openfirmware
framebuffer driver to play nicely together. It may not be worth the
trouble for bochs_drm.

There's a better case for including some of the more modern drivers -
maybe QXL and virtio - but I wasn't able to test them: my particular
build of qemu/TCG refused to start with them and I didn't feel like
rebuilding/debugging qemu.

It would also be legitmate to say that you're focussing on headless use
with pseries_*defconfig and not include them: you need to bring in the
DRM core if you want these drivers.

HTH.

Regards,
Daniel

[0] https://bugs.launchpad.net/ubuntu/+source/kmod/+bug/1378648

>
> cheers

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Axtens <dja@axtens.net>
To: Michael Ellerman <mpe@ellerman.id.au>,
	linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org
Cc: gabriele.paoloni@huawei.com, airlied@linux.ie,
	Brian King <brking@linux.vnet.ibm.com>,
	will.deacon@arm.com, z.liuxinliang@hisilicon.com,
	bhelgaas@google.com, alex.williamson@redhat.com,
	catalin.marinas@arm.com, zourongrong@gmail.com,
	daniel.vetter@intel.com
Subject: Re: [PATCH 3/3] powerpc: replace vga_fixup() with generic code
Date: Tue, 08 Aug 2017 09:01:06 +1000	[thread overview]
Message-ID: <87wp6fq8y5.fsf@linkitivity.dja.id.au> (raw)
In-Reply-To: <87efsnq217.fsf@concordia.ellerman.id.au>

Michael Ellerman <mpe@ellerman.id.au> writes:

> Daniel Axtens <dja@axtens.net> writes:
>
>> Currently, we do a PCI fixup to mark a default card so that Xorg
>> autoconfiguration works.
>>
>> There is a new generic method to do this sort of vga fixup, and
>> it occurs by default.
>>
>> Drop our old method.
>>
>> This method is different:
>>  - it will only mark a card as default if a driver is bound
>>  - the marking will happen at late_initcall time, or even later
>>    if a card is enabled later on (via an ENABLE hook). Currently
>>    things are enabled in a FINAL hook.
>>
>> This *does* change behaviour under some circumstances.
>>
>> For example, pseries_le_defconfig doesn't have DRM drivers for
>> many of the qemu GPU models, including the 'standard' vga.
>
> Should we enable them/it?

Hard to say.

The 'standard' vga module (bochs_drm) was blacklisted by Ubuntu -
apparently at IBM's request [0] - some years back. Even if you
un-blacklist it, I had trouble with getting it and the openfirmware
framebuffer driver to play nicely together. It may not be worth the
trouble for bochs_drm.

There's a better case for including some of the more modern drivers -
maybe QXL and virtio - but I wasn't able to test them: my particular
build of qemu/TCG refused to start with them and I didn't feel like
rebuilding/debugging qemu.

It would also be legitmate to say that you're focussing on headless use
with pseries_*defconfig and not include them: you need to bring in the
DRM core if you want these drivers.

HTH.

Regards,
Daniel

[0] https://bugs.launchpad.net/ubuntu/+source/kmod/+bug/1378648

>
> cheers

WARNING: multiple messages have this Message-ID (diff)
From: dja@axtens.net (Daniel Axtens)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] powerpc: replace vga_fixup() with generic code
Date: Tue, 08 Aug 2017 09:01:06 +1000	[thread overview]
Message-ID: <87wp6fq8y5.fsf@linkitivity.dja.id.au> (raw)
In-Reply-To: <87efsnq217.fsf@concordia.ellerman.id.au>

Michael Ellerman <mpe@ellerman.id.au> writes:

> Daniel Axtens <dja@axtens.net> writes:
>
>> Currently, we do a PCI fixup to mark a default card so that Xorg
>> autoconfiguration works.
>>
>> There is a new generic method to do this sort of vga fixup, and
>> it occurs by default.
>>
>> Drop our old method.
>>
>> This method is different:
>>  - it will only mark a card as default if a driver is bound
>>  - the marking will happen at late_initcall time, or even later
>>    if a card is enabled later on (via an ENABLE hook). Currently
>>    things are enabled in a FINAL hook.
>>
>> This *does* change behaviour under some circumstances.
>>
>> For example, pseries_le_defconfig doesn't have DRM drivers for
>> many of the qemu GPU models, including the 'standard' vga.
>
> Should we enable them/it?

Hard to say.

The 'standard' vga module (bochs_drm) was blacklisted by Ubuntu -
apparently at IBM's request [0] - some years back. Even if you
un-blacklist it, I had trouble with getting it and the openfirmware
framebuffer driver to play nicely together. It may not be worth the
trouble for bochs_drm.

There's a better case for including some of the more modern drivers -
maybe QXL and virtio - but I wasn't able to test them: my particular
build of qemu/TCG refused to start with them and I didn't feel like
rebuilding/debugging qemu.

It would also be legitmate to say that you're focussing on headless use
with pseries_*defconfig and not include them: you need to bring in the
DRM core if you want these drivers.

HTH.

Regards,
Daniel

[0] https://bugs.launchpad.net/ubuntu/+source/kmod/+bug/1378648

>
> cheers

  reply	other threads:[~2017-08-07 23:01 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-04 10:20 [PATCH 0/3] Split VGA default selection from VGA arbiter Daniel Axtens
2017-08-04 10:20 ` Daniel Axtens
2017-08-04 10:20 ` Daniel Axtens
2017-08-04 10:20 ` [PATCH 1/3] powerpc: simplify and fix VGA default device behaviour Daniel Axtens
2017-08-04 10:20   ` Daniel Axtens
2017-08-11 21:44   ` Bjorn Helgaas
2017-08-11 21:44     ` Bjorn Helgaas
2017-08-11 21:44     ` Bjorn Helgaas
2017-08-13 22:34     ` Daniel Axtens
2017-08-13 22:34       ` Daniel Axtens
2017-08-04 10:20 ` [PATCH 2/3] Split VGA default device handler out of VGA arbiter Daniel Axtens
2017-08-04 10:20   ` Daniel Axtens
2017-08-04 10:20   ` Daniel Axtens
2017-08-05  6:57   ` Lukas Wunner
2017-08-05  6:57     ` Lukas Wunner
2017-08-06 23:49     ` Daniel Axtens
2017-08-06 23:49       ` Daniel Axtens
2017-08-06 23:49       ` Daniel Axtens
2017-08-04 10:20 ` [PATCH 3/3] powerpc: replace vga_fixup() with generic code Daniel Axtens
2017-08-04 10:20   ` Daniel Axtens
2017-08-07  7:18   ` Michael Ellerman
2017-08-07  7:18     ` Michael Ellerman
2017-08-07  7:18     ` Michael Ellerman
2017-08-07 23:01     ` Daniel Axtens [this message]
2017-08-07 23:01       ` Daniel Axtens
2017-08-07 23:01       ` Daniel Axtens
2017-08-08 10:12       ` Michael Ellerman
2017-08-08 10:12         ` Michael Ellerman
2017-08-08 10:12         ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wp6fq8y5.fsf@linkitivity.dja.id.au \
    --to=dja@axtens.net \
    --cc=airlied@linux.ie \
    --cc=alex.williamson@redhat.com \
    --cc=bhelgaas@google.com \
    --cc=brking@linux.vnet.ibm.com \
    --cc=catalin.marinas@arm.com \
    --cc=daniel.vetter@intel.com \
    --cc=gabriele.paoloni@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=will.deacon@arm.com \
    --cc=z.liuxinliang@hisilicon.com \
    --cc=zourongrong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.