From: Punit Agrawal <punit.agrawal@arm.com> To: kbuild test robot <lkp@intel.com> Cc: kbuild-all@01.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, will.deacon@arm.com, n-horiguchi@ah.jp.nec.com, kirill.shutemov@linux.intel.com, mike.kravetz@oracle.com, steve.capper@arm.com, mark.rutland@arm.com, hillf.zj@alibaba-inc.com, linux-arch@vger.kernel.org, aneesh.kumar@linux.vnet.ibm.com, Tony Luck <tony.luck@intel.com>, Fenghua Yu <fenghua.yu@intel.com>, James Hogan <james.hogan@imgtec.com>, Ralf Baechle <ralf@linux-mips.org>, "James E.J. Bottomley" <jejb@parisc-linux.org>, Helge Deller <deller@gmx.de>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Paul Mackerras <paulus@samba.org>, Michael Ellerman <mpe@ellerman.id.au>, Martin Schwidefsky <schwidefsky@de.ibm.com>, Heiko Carstens <heiko.carstens@de.ibm.com>, Yoshinori Sato <ysato@users.sourceforge.jp>, Ric Subject: Re: [PATCH v3 3/6] mm/hugetlb: add size parameter to huge_pte_offset() Date: Tue, 23 May 2017 17:13:52 +0100 [thread overview] Message-ID: <87wp97ft4v.fsf@e105922-lin.cambridge.arm.com> (raw) In-Reply-To: <201705231817.OSRI6iib%fengguang.wu@intel.com> (kbuild test robot's message of "Tue, 23 May 2017 18:04:42 +0800") kbuild test robot <lkp@intel.com> writes: > Hi Punit, > > [auto build test ERROR on linus/master] > [also build test ERROR on v4.12-rc2 next-20170523] > [cannot apply to mmotm/master] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/Punit-Agrawal/Support-for-contiguous-pte-hugepages/20170523-142407 > config: arm64-defconfig (attached as .config) > compiler: aarch64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 > reproduce: > wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > make.cross ARCH=arm64 > > All errors (new ones prefixed by >>): > > arch/arm64/mm/hugetlbpage.c: In function 'huge_ptep_get_and_clear': >>> arch/arm64/mm/hugetlbpage.c:200:10: error: too few arguments to function 'huge_pte_offset' > cpte = huge_pte_offset(mm, addr); > ^~~~~~~~~~~~~~~ > arch/arm64/mm/hugetlbpage.c:135:8: note: declared here > pte_t *huge_pte_offset(struct mm_struct *mm, > ^~~~~~~~~~~~~~~ > arch/arm64/mm/hugetlbpage.c: In function 'huge_ptep_set_access_flags': > arch/arm64/mm/hugetlbpage.c:238:10: error: too few arguments to function 'huge_pte_offset' > cpte = huge_pte_offset(vma->vm_mm, addr); > ^~~~~~~~~~~~~~~ > arch/arm64/mm/hugetlbpage.c:135:8: note: declared here > pte_t *huge_pte_offset(struct mm_struct *mm, > ^~~~~~~~~~~~~~~ > arch/arm64/mm/hugetlbpage.c: In function 'huge_ptep_set_wrprotect': > arch/arm64/mm/hugetlbpage.c:263:10: error: too few arguments to function 'huge_pte_offset' > cpte = huge_pte_offset(mm, addr); > ^~~~~~~~~~~~~~~ > arch/arm64/mm/hugetlbpage.c:135:8: note: declared here > pte_t *huge_pte_offset(struct mm_struct *mm, > ^~~~~~~~~~~~~~~ > arch/arm64/mm/hugetlbpage.c: In function 'huge_ptep_clear_flush': > arch/arm64/mm/hugetlbpage.c:280:10: error: too few arguments to function 'huge_pte_offset' > cpte = huge_pte_offset(vma->vm_mm, addr); > ^~~~~~~~~~~~~~~ > arch/arm64/mm/hugetlbpage.c:135:8: note: declared here > pte_t *huge_pte_offset(struct mm_struct *mm, > ^~~~~~~~~~~~~~~ Ok, so we haven't quite managed to remove the dependency of this patch on the following arm64 changes[0]. I'll post a new version fixing this failure soon. [0] https://www.spinics.net/lists/arm-kernel/msg582758.html > > vim +/huge_pte_offset +200 arch/arm64/mm/hugetlbpage.c > > 66b3923a David Woods 2015-12-17 194 if (pte_cont(*ptep)) { > 66b3923a David Woods 2015-12-17 195 int ncontig, i; > 66b3923a David Woods 2015-12-17 196 size_t pgsize; > 66b3923a David Woods 2015-12-17 197 pte_t *cpte; > 66b3923a David Woods 2015-12-17 198 bool is_dirty = false; > 66b3923a David Woods 2015-12-17 199 > 66b3923a David Woods 2015-12-17 @200 cpte = huge_pte_offset(mm, addr); > 66b3923a David Woods 2015-12-17 201 ncontig = find_num_contig(mm, addr, cpte, *cpte, &pgsize); > 66b3923a David Woods 2015-12-17 202 /* save the 1st pte to return */ > 66b3923a David Woods 2015-12-17 203 pte = ptep_get_and_clear(mm, addr, cpte); > > :::::: The code at line 200 was first introduced by commit > :::::: 66b3923a1a0f77a563b43f43f6ad091354abbfe9 arm64: hugetlb: add support for PTE contiguous bit > > :::::: TO: David Woods <dwoods@ezchip.com> > :::::: CC: Will Deacon <will.deacon@arm.com> > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Punit Agrawal <punit.agrawal@arm.com> To: kbuild test robot <lkp@intel.com> Cc: kbuild-all@01.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, will.deacon@arm.com, n-horiguchi@ah.jp.nec.com, kirill.shutemov@linux.intel.com, mike.kravetz@oracle.com, steve.capper@arm.com, mark.rutland@arm.com, hillf.zj@alibaba-inc.com, linux-arch@vger.kernel.org, aneesh.kumar@linux.vnet.ibm.com, Tony Luck <tony.luck@intel.com>, Fenghua Yu <fenghua.yu@intel.com>, James Hogan <james.hogan@imgtec.com>, Ralf Baechle <ralf@linux-mips.org>, "James E.J. Bottomley" <jejb@parisc-linux.org>, Helge Deller <deller@gmx.de>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Paul Mackerras <paulus@samba.org>, Michael Ellerman <mpe@ellerman.id.au>, Martin Schwidefsky <schwidefsky@de.ibm.com>, Heiko Carstens <heiko.carstens@de.ibm.com>, Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, "David S. Miller" <davem@davemloft.net>, Chris Metcalf <"cme tcalf"@mellanox.com>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>, Alexander Viro <viro@zeniv.linux.org.uk>, Michal Hocko <mhocko@suse.com> Subject: Re: [PATCH v3 3/6] mm/hugetlb: add size parameter to huge_pte_offset() Date: Tue, 23 May 2017 17:13:52 +0100 [thread overview] Message-ID: <87wp97ft4v.fsf@e105922-lin.cambridge.arm.com> (raw) In-Reply-To: <201705231817.OSRI6iib%fengguang.wu@intel.com> (kbuild test robot's message of "Tue, 23 May 2017 18:04:42 +0800") kbuild test robot <lkp@intel.com> writes: > Hi Punit, > > [auto build test ERROR on linus/master] > [also build test ERROR on v4.12-rc2 next-20170523] > [cannot apply to mmotm/master] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/Punit-Agrawal/Support-for-contiguous-pte-hugepages/20170523-142407 > config: arm64-defconfig (attached as .config) > compiler: aarch64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 > reproduce: > wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > make.cross ARCH=arm64 > > All errors (new ones prefixed by >>): > > arch/arm64/mm/hugetlbpage.c: In function 'huge_ptep_get_and_clear': >>> arch/arm64/mm/hugetlbpage.c:200:10: error: too few arguments to function 'huge_pte_offset' > cpte = huge_pte_offset(mm, addr); > ^~~~~~~~~~~~~~~ > arch/arm64/mm/hugetlbpage.c:135:8: note: declared here > pte_t *huge_pte_offset(struct mm_struct *mm, > ^~~~~~~~~~~~~~~ > arch/arm64/mm/hugetlbpage.c: In function 'huge_ptep_set_access_flags': > arch/arm64/mm/hugetlbpage.c:238:10: error: too few arguments to function 'huge_pte_offset' > cpte = huge_pte_offset(vma->vm_mm, addr); > ^~~~~~~~~~~~~~~ > arch/arm64/mm/hugetlbpage.c:135:8: note: declared here > pte_t *huge_pte_offset(struct mm_struct *mm, > ^~~~~~~~~~~~~~~ > arch/arm64/mm/hugetlbpage.c: In function 'huge_ptep_set_wrprotect': > arch/arm64/mm/hugetlbpage.c:263:10: error: too few arguments to function 'huge_pte_offset' > cpte = huge_pte_offset(mm, addr); > ^~~~~~~~~~~~~~~ > arch/arm64/mm/hugetlbpage.c:135:8: note: declared here > pte_t *huge_pte_offset(struct mm_struct *mm, > ^~~~~~~~~~~~~~~ > arch/arm64/mm/hugetlbpage.c: In function 'huge_ptep_clear_flush': > arch/arm64/mm/hugetlbpage.c:280:10: error: too few arguments to function 'huge_pte_offset' > cpte = huge_pte_offset(vma->vm_mm, addr); > ^~~~~~~~~~~~~~~ > arch/arm64/mm/hugetlbpage.c:135:8: note: declared here > pte_t *huge_pte_offset(struct mm_struct *mm, > ^~~~~~~~~~~~~~~ Ok, so we haven't quite managed to remove the dependency of this patch on the following arm64 changes[0]. I'll post a new version fixing this failure soon. [0] https://www.spinics.net/lists/arm-kernel/msg582758.html > > vim +/huge_pte_offset +200 arch/arm64/mm/hugetlbpage.c > > 66b3923a David Woods 2015-12-17 194 if (pte_cont(*ptep)) { > 66b3923a David Woods 2015-12-17 195 int ncontig, i; > 66b3923a David Woods 2015-12-17 196 size_t pgsize; > 66b3923a David Woods 2015-12-17 197 pte_t *cpte; > 66b3923a David Woods 2015-12-17 198 bool is_dirty = false; > 66b3923a David Woods 2015-12-17 199 > 66b3923a David Woods 2015-12-17 @200 cpte = huge_pte_offset(mm, addr); > 66b3923a David Woods 2015-12-17 201 ncontig = find_num_contig(mm, addr, cpte, *cpte, &pgsize); > 66b3923a David Woods 2015-12-17 202 /* save the 1st pte to return */ > 66b3923a David Woods 2015-12-17 203 pte = ptep_get_and_clear(mm, addr, cpte); > > :::::: The code at line 200 was first introduced by commit > :::::: 66b3923a1a0f77a563b43f43f6ad091354abbfe9 arm64: hugetlb: add support for PTE contiguous bit > > :::::: TO: David Woods <dwoods@ezchip.com> > :::::: CC: Will Deacon <will.deacon@arm.com> > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-05-23 16:13 UTC|newest] Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-05-22 13:35 [PATCH v3 0/6] Support for contiguous pte hugepages Punit Agrawal 2017-05-22 13:35 ` Punit Agrawal 2017-05-22 13:35 ` Punit Agrawal 2017-05-22 13:35 ` [PATCH v3 1/6] mm, gup: Remove broken VM_BUG_ON_PAGE compound check for hugepages Punit Agrawal 2017-05-22 13:35 ` Punit Agrawal 2017-05-22 13:35 ` Punit Agrawal 2017-05-23 13:09 ` Kirill A. Shutemov 2017-05-23 13:09 ` Kirill A. Shutemov 2017-05-23 13:09 ` Kirill A. Shutemov 2017-05-22 13:36 ` [PATCH v3 2/6] mm, gup: Ensure real head page is ref-counted when using hugepages Punit Agrawal 2017-05-22 13:36 ` Punit Agrawal 2017-05-22 13:36 ` Punit Agrawal 2017-05-23 13:13 ` Kirill A. Shutemov 2017-05-23 13:13 ` Kirill A. Shutemov 2017-05-23 13:13 ` Kirill A. Shutemov 2017-05-23 15:43 ` Punit Agrawal 2017-05-23 15:43 ` Punit Agrawal 2017-05-23 15:43 ` Punit Agrawal 2017-05-22 13:36 ` [PATCH v3 3/6] mm/hugetlb: add size parameter to huge_pte_offset() Punit Agrawal 2017-05-22 13:36 ` Punit Agrawal 2017-05-22 13:36 ` Punit Agrawal 2017-05-22 13:36 ` Punit Agrawal 2017-05-23 10:04 ` kbuild test robot 2017-05-23 10:04 ` kbuild test robot 2017-05-23 10:04 ` kbuild test robot 2017-05-23 10:04 ` kbuild test robot 2017-05-23 16:13 ` Punit Agrawal [this message] 2017-05-23 16:13 ` Punit Agrawal 2017-05-22 13:36 ` [PATCH v3 4/6] mm/hugetlb: Allow architectures to override huge_pte_clear() Punit Agrawal 2017-05-22 13:36 ` Punit Agrawal 2017-05-22 13:36 ` Punit Agrawal 2017-05-22 13:59 ` Arnd Bergmann 2017-05-22 13:59 ` Arnd Bergmann 2017-05-22 13:59 ` Arnd Bergmann 2017-05-22 15:40 ` Punit Agrawal 2017-05-22 15:40 ` Punit Agrawal 2017-05-22 15:40 ` Punit Agrawal 2017-05-22 16:25 ` [PATCH v3.1 " Punit Agrawal 2017-05-22 16:25 ` Punit Agrawal 2017-05-22 16:25 ` Punit Agrawal 2017-05-22 20:34 ` Arnd Bergmann 2017-05-22 20:34 ` Arnd Bergmann 2017-05-22 20:34 ` Arnd Bergmann 2017-05-23 14:53 ` Punit Agrawal 2017-05-23 14:53 ` Punit Agrawal 2017-05-23 14:53 ` Punit Agrawal 2017-05-23 5:26 ` Martin Schwidefsky 2017-05-23 5:26 ` Martin Schwidefsky 2017-05-23 5:26 ` Martin Schwidefsky 2017-05-23 14:53 ` Punit Agrawal 2017-05-23 14:53 ` Punit Agrawal 2017-05-23 14:53 ` Punit Agrawal 2017-05-22 13:36 ` [PATCH v3 5/6] mm/hugetlb: Introduce set_huge_swap_pte_at() helper Punit Agrawal 2017-05-22 13:36 ` Punit Agrawal 2017-05-22 13:36 ` Punit Agrawal 2017-05-22 16:30 ` [PATCH v3.1 " Punit Agrawal 2017-05-22 16:30 ` Punit Agrawal 2017-05-22 16:30 ` Punit Agrawal 2017-05-22 13:36 ` [PATCH v3 6/6] mm: rmap: Use correct helper when poisoning hugepages Punit Agrawal 2017-05-22 13:36 ` Punit Agrawal 2017-05-22 13:36 ` Punit Agrawal
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87wp97ft4v.fsf@e105922-lin.cambridge.arm.com \ --to=punit.agrawal@arm.com \ --cc=akpm@linux-foundation.org \ --cc=aneesh.kumar@linux.vnet.ibm.com \ --cc=benh@kernel.crashing.org \ --cc=catalin.marinas@arm.com \ --cc=deller@gmx.de \ --cc=fenghua.yu@intel.com \ --cc=heiko.carstens@de.ibm.com \ --cc=hillf.zj@alibaba-inc.com \ --cc=james.hogan@imgtec.com \ --cc=jejb@parisc-linux.org \ --cc=kbuild-all@01.org \ --cc=kirill.shutemov@linux.intel.com \ --cc=linux-arch@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=lkp@intel.com \ --cc=mark.rutland@arm.com \ --cc=mike.kravetz@oracle.com \ --cc=mpe@ellerman.id.au \ --cc=n-horiguchi@ah.jp.nec.com \ --cc=paulus@samba.org \ --cc=ralf@linux-mips.org \ --cc=schwidefsky@de.ibm.com \ --cc=steve.capper@arm.com \ --cc=tony.luck@intel.com \ --cc=will.deacon@arm.com \ --cc=ysato@users.sourceforge.jp \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.