[PATCH 0/5] r8a7795/6 Salvator-X PWM enablement

[PATCH 0/5] r8a7795/6 Salvator-X PWM enablement

[Ulrich Hecht]

Hi!

This is a straight port from the BSP, enabling PWM1 and PWM2 on the
Salvator-X boards. For r8a7796 it also adds the required infrastructure
(clock and pins).

Not fully tested because I cannot find my breakout adapter. Looks OK from
the software side, though.

CU
Uli


Ryo Kodama (2):
  clk: renesas: r8a7796: add PWM clock
  arm64: dts: r8a7796-salvator-x: Add PWM device support

Takeshi Kihara (3):
  pinctrl: sh-pfc: r8a7796: Add PWM pins, groups and functions
  arm64: dts: r8a7796: Add PWM device nodes
  arm64: dts: r8a7795-salvator-x: Enable PWM

 arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts |  22 +++
 arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts |  21 +++
 arch/arm64/boot/dts/renesas/r8a7796.dtsi           |  63 +++++++++
 drivers/clk/renesas/r8a7796-cpg-mssr.c             |   1 +
 drivers/pinctrl/sh-pfc/pfc-r8a7796.c               | 153 +++++++++++++++++++++
 5 files changed, 260 insertions(+)

-- 
2.7.4

[PATCH 1/5] pinctrl: sh-pfc: r8a7796: Add PWM pins, groups and functions

[Ulrich Hecht]

From: Takeshi Kihara <takeshi.kihara.df@renesas.com>

This patch adds PWM{0,1,2,3,4,5,6} pins, groups and functions to
R8A7796 SoC.

Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
---
 drivers/pinctrl/sh-pfc/pfc-r8a7796.c | 153 +++++++++++++++++++++++++++++++++++
 1 file changed, 153 insertions(+)

diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7796.c b/drivers/pinctrl/sh-pfc/pfc-r8a7796.c
index b0362ae..668c688 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a7796.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a7796.c
@@ -2955,6 +2955,105 @@ static const unsigned int msiof3_rxd_e_mux[] = {
 	MSIOF3_RXD_E_MARK,
 };
 
+/* - PWM0 --------------------------------------------------------------------*/
+static const unsigned int pwm0_pins[] = {
+	/* PWM */
+	RCAR_GP_PIN(2, 6),
+};
+static const unsigned int pwm0_mux[] = {
+	PWM0_MARK,
+};
+/* - PWM1 --------------------------------------------------------------------*/
+static const unsigned int pwm1_a_pins[] = {
+	/* PWM */
+	RCAR_GP_PIN(2, 7),
+};
+static const unsigned int pwm1_a_mux[] = {
+	PWM1_A_MARK,
+};
+static const unsigned int pwm1_b_pins[] = {
+	/* PWM */
+	RCAR_GP_PIN(1, 8),
+};
+static const unsigned int pwm1_b_mux[] = {
+	PWM1_B_MARK,
+};
+/* - PWM2 --------------------------------------------------------------------*/
+static const unsigned int pwm2_a_pins[] = {
+	/* PWM */
+	RCAR_GP_PIN(2, 8),
+};
+static const unsigned int pwm2_a_mux[] = {
+	PWM2_A_MARK,
+};
+static const unsigned int pwm2_b_pins[] = {
+	/* PWM */
+	RCAR_GP_PIN(1, 11),
+};
+static const unsigned int pwm2_b_mux[] = {
+	PWM2_B_MARK,
+};
+/* - PWM3 --------------------------------------------------------------------*/
+static const unsigned int pwm3_a_pins[] = {
+	/* PWM */
+	RCAR_GP_PIN(1, 0),
+};
+static const unsigned int pwm3_a_mux[] = {
+	PWM3_A_MARK,
+};
+static const unsigned int pwm3_b_pins[] = {
+	/* PWM */
+	RCAR_GP_PIN(2, 2),
+};
+static const unsigned int pwm3_b_mux[] = {
+	PWM3_B_MARK,
+};
+/* - PWM4 --------------------------------------------------------------------*/
+static const unsigned int pwm4_a_pins[] = {
+	/* PWM */
+	RCAR_GP_PIN(1, 1),
+};
+static const unsigned int pwm4_a_mux[] = {
+	PWM4_A_MARK,
+};
+static const unsigned int pwm4_b_pins[] = {
+	/* PWM */
+	RCAR_GP_PIN(2, 3),
+};
+static const unsigned int pwm4_b_mux[] = {
+	PWM4_B_MARK,
+};
+/* - PWM5 --------------------------------------------------------------------*/
+static const unsigned int pwm5_a_pins[] = {
+	/* PWM */
+	RCAR_GP_PIN(1, 2),
+};
+static const unsigned int pwm5_a_mux[] = {
+	PWM5_A_MARK,
+};
+static const unsigned int pwm5_b_pins[] = {
+	/* PWM */
+	RCAR_GP_PIN(2, 4),
+};
+static const unsigned int pwm5_b_mux[] = {
+	PWM5_B_MARK,
+};
+/* - PWM6 --------------------------------------------------------------------*/
+static const unsigned int pwm6_a_pins[] = {
+	/* PWM */
+	RCAR_GP_PIN(1, 3),
+};
+static const unsigned int pwm6_a_mux[] = {
+	PWM6_A_MARK,
+};
+static const unsigned int pwm6_b_pins[] = {
+	/* PWM */
+	RCAR_GP_PIN(2, 5),
+};
+static const unsigned int pwm6_b_mux[] = {
+	PWM6_B_MARK,
+};
+
 /* - SCIF0 ------------------------------------------------------------------ */
 static const unsigned int scif0_data_pins[] = {
 	/* RX, TX */
@@ -3565,6 +3664,19 @@ static const struct sh_pfc_pin_group pinmux_groups[] = {
 	SH_PFC_PIN_GROUP(msiof3_ss2_e),
 	SH_PFC_PIN_GROUP(msiof3_txd_e),
 	SH_PFC_PIN_GROUP(msiof3_rxd_e),
+	SH_PFC_PIN_GROUP(pwm0),
+	SH_PFC_PIN_GROUP(pwm1_a),
+	SH_PFC_PIN_GROUP(pwm1_b),
+	SH_PFC_PIN_GROUP(pwm2_a),
+	SH_PFC_PIN_GROUP(pwm2_b),
+	SH_PFC_PIN_GROUP(pwm3_a),
+	SH_PFC_PIN_GROUP(pwm3_b),
+	SH_PFC_PIN_GROUP(pwm4_a),
+	SH_PFC_PIN_GROUP(pwm4_b),
+	SH_PFC_PIN_GROUP(pwm5_a),
+	SH_PFC_PIN_GROUP(pwm5_b),
+	SH_PFC_PIN_GROUP(pwm6_a),
+	SH_PFC_PIN_GROUP(pwm6_b),
 	SH_PFC_PIN_GROUP(scif0_data),
 	SH_PFC_PIN_GROUP(scif0_clk),
 	SH_PFC_PIN_GROUP(scif0_ctrl),
@@ -3879,6 +3991,40 @@ static const char * const msiof3_groups[] = {
 	"msiof3_rxd_e",
 };
 
+static const char * const pwm0_groups[] = {
+	"pwm0",
+};
+
+static const char * const pwm1_groups[] = {
+	"pwm1_a",
+	"pwm1_b",
+};
+
+static const char * const pwm2_groups[] = {
+	"pwm2_a",
+	"pwm2_b",
+};
+
+static const char * const pwm3_groups[] = {
+	"pwm3_a",
+	"pwm3_b",
+};
+
+static const char * const pwm4_groups[] = {
+	"pwm4_a",
+	"pwm4_b",
+};
+
+static const char * const pwm5_groups[] = {
+	"pwm5_a",
+	"pwm5_b",
+};
+
+static const char * const pwm6_groups[] = {
+	"pwm6_a",
+	"pwm6_b",
+};
+
 static const char * const scif0_groups[] = {
 	"scif0_data",
 	"scif0_clk",
@@ -3991,6 +4137,13 @@ static const struct sh_pfc_function pinmux_functions[] = {
 	SH_PFC_FUNCTION(msiof1),
 	SH_PFC_FUNCTION(msiof2),
 	SH_PFC_FUNCTION(msiof3),
+	SH_PFC_FUNCTION(pwm0),
+	SH_PFC_FUNCTION(pwm1),
+	SH_PFC_FUNCTION(pwm2),
+	SH_PFC_FUNCTION(pwm3),
+	SH_PFC_FUNCTION(pwm4),
+	SH_PFC_FUNCTION(pwm5),
+	SH_PFC_FUNCTION(pwm6),
 	SH_PFC_FUNCTION(scif0),
 	SH_PFC_FUNCTION(scif1),
 	SH_PFC_FUNCTION(scif2),
-- 
2.7.4

[PATCH 2/5] clk: renesas: r8a7796: add PWM clock

[Ulrich Hecht]

From: Ryo Kodama <ryo.kodama.vz@renesas.com>

This patch adds PWM clock for PWM.

Signed-off-by: Ryo Kodama <ryo.kodama.vz@renesas.com>
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
---
 drivers/clk/renesas/r8a7796-cpg-mssr.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/renesas/r8a7796-cpg-mssr.c b/drivers/clk/renesas/r8a7796-cpg-mssr.c
index 9d114b3..be0fc00 100644
--- a/drivers/clk/renesas/r8a7796-cpg-mssr.c
+++ b/drivers/clk/renesas/r8a7796-cpg-mssr.c
@@ -151,6 +151,7 @@ static const struct mssr_mod_clk r8a7796_mod_clks[] __initconst = {
 	DEF_MOD("hscif1",		 519,	R8A7796_CLK_S3D1),
 	DEF_MOD("hscif0",		 520,	R8A7796_CLK_S3D1),
 	DEF_MOD("thermal",		 522,	R8A7796_CLK_CP),
+	DEF_MOD("pwm",			 523,	R8A7796_CLK_S3D4),
 	DEF_MOD("fcpvd2",		 601,	R8A7796_CLK_S0D2),
 	DEF_MOD("fcpvd1",		 602,	R8A7796_CLK_S0D2),
 	DEF_MOD("fcpvd0",		 603,	R8A7796_CLK_S0D2),
-- 
2.7.4

[PATCH 3/5] arm64: dts: r8a7796: Add PWM device nodes

[Ulrich Hecht]

From: Takeshi Kihara <takeshi.kihara.df@renesas.com>

This patch adds PWM{0,1,2,3,4,5,6} device nodes for R8A7796 SoC.

Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
---
 arch/arm64/boot/dts/renesas/r8a7796.dtsi | 63 ++++++++++++++++++++++++++++++++
 1 file changed, 63 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
index 798fe0f..578b318 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
@@ -455,6 +455,69 @@
 			status = "disabled";
 		};
 
+		pwm0: pwm@e6e30000 {
+			compatible = "renesas,pwm-r8a7796", "renesas,pwm-rcar";
+			reg = <0 0xe6e30000 0 0x10>;
+			#pwm-cells = <2>;
+			clocks = <&cpg CPG_MOD 523>;
+			power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
+			status = "disabled";
+		};
+
+		pwm1: pwm@e6e31000 {
+			compatible = "renesas,pwm-r8a7796", "renesas,pwm-rcar";
+			reg = <0 0xe6e31000 0 0x10>;
+			#pwm-cells = <2>;
+			clocks = <&cpg CPG_MOD 523>;
+			power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
+			status = "disabled";
+		};
+
+		pwm2: pwm@e6e32000 {
+			compatible = "renesas,pwm-r8a7796", "renesas,pwm-rcar";
+			reg = <0 0xe6e32000 0 0x10>;
+			#pwm-cells = <2>;
+			clocks = <&cpg CPG_MOD 523>;
+			power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
+			status = "disabled";
+		};
+
+		pwm3: pwm@e6e33000 {
+			compatible = "renesas,pwm-r8a7796", "renesas,pwm-rcar";
+			reg = <0 0xe6e33000 0 0x10>;
+			#pwm-cells = <2>;
+			clocks = <&cpg CPG_MOD 523>;
+			power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
+			status = "disabled";
+		};
+
+		pwm4: pwm@e6e34000 {
+			compatible = "renesas,pwm-r8a7796", "renesas,pwm-rcar";
+			reg = <0 0xe6e34000 0 0x10>;
+			#pwm-cells = <2>;
+			clocks = <&cpg CPG_MOD 523>;
+			power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
+			status = "disabled";
+		};
+
+		pwm5: pwm@e6e35000 {
+			compatible = "renesas,pwm-r8a7796", "renesas,pwm-rcar";
+			reg = <0 0xe6e35000 0 0x10>;
+			#pwm-cells = <2>;
+			clocks = <&cpg CPG_MOD 523>;
+			power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
+			status = "disabled";
+		};
+
+		pwm6: pwm@e6e36000 {
+			compatible = "renesas,pwm-r8a7796", "renesas,pwm-rcar";
+			reg = <0 0xe6e36000 0 0x10>;
+			#pwm-cells = <2>;
+			clocks = <&cpg CPG_MOD 523>;
+			power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
+			status = "disabled";
+		};
+
 		i2c0: i2c@e6500000 {
 			#address-cells = <1>;
 			#size-cells = <0>;
-- 
2.7.4

[PATCH 4/5] arm64: dts: r8a7796-salvator-x: Add PWM device support

[Ulrich Hecht]

From: Ryo Kodama <ryo.kodama.vz@renesas.com>

This patch adds support of PWM{1,2} device for Salvator-X board on
R8A7796 SoC.

Signed-off-by: Ryo Kodama <ryo.kodama.vz@renesas.com>
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
---
 arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
index 14d9e51..b4ff1b6 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
@@ -105,6 +105,18 @@
 	};
 };
 
+&pwm1 {
+	pinctrl-0 = <&pwm1_pins>;
+	pinctrl-names = "default";
+	status = "okay";
+};
+
+&pwm2 {
+	pinctrl-0 = <&pwm2_pins>;
+	pinctrl-names = "default";
+	status = "okay";
+};
+
 &pfc {
 	pinctrl-0 = <&scif_clk_pins>;
 	pinctrl-names = "default";
@@ -114,6 +126,15 @@
 		function = "avb";
 	};
 
+	pwm1_pins: pwm1 {
+		groups = "pwm1_a", "pwm1_b";
+		function = "pwm1";
+	};
+	pwm2_pins: pwm2 {
+		groups = "pwm2_a", "pwm2_b";
+		function = "pwm2";
+	};
+
 	scif1_pins: scif1 {
 		groups = "scif1_data_a", "scif1_ctrl";
 		function = "scif1";
-- 
2.7.4

[PATCH 5/5] arm64: dts: r8a7795-salvator-x: Enable PWM

[Ulrich Hecht]

From: Takeshi Kihara <takeshi.kihara.df@renesas.com>

This patch enables PWM{1,2} for Salvator-X board on R8A7795 SoC.

Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
---
 arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
index bf4674e..842b0dd 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
@@ -282,6 +282,18 @@
 	};
 };
 
+&pwm1 {
+	pinctrl-0 = <&pwm1_pins>;
+	pinctrl-names = "default";
+	status = "okay";
+};
+
+&pwm2 {
+	pinctrl-0 = <&pwm2_pins>;
+	pinctrl-names = "default";
+	status = "okay";
+};
+
 &du {
 	pinctrl-0 = <&du_pins>;
 	pinctrl-names = "default";
@@ -324,6 +336,16 @@
 	pinctrl-0 = <&scif_clk_pins>;
 	pinctrl-names = "default";
 
+	pwm1_pins: pwm1 {
+		groups = "pwm1_a", "pwm1_b";
+		function = "pwm1";
+	};
+
+	pwm2_pins: pwm2 {
+		groups = "pwm2_a", "pwm2_b";
+		function = "pwm2";
+	};
+
 	scif1_pins: scif1 {
 		groups = "scif1_data_a", "scif1_ctrl";
 		function = "scif1";
-- 
2.7.4

Re: [PATCH 0/5] r8a7795/6 Salvator-X PWM enablement

[Geert Uytterhoeven]

Hi Uli,

On Wed, Apr 19, 2017 at 3:24 PM, Ulrich Hecht
<ulrich.hecht+renesas@gmail.com> wrote:
> This is a straight port from the BSP, enabling PWM1 and PWM2 on the
> Salvator-X boards. For r8a7796 it also adds the required infrastructure
> (clock and pins).
>
> Not fully tested because I cannot find my breakout adapter. Looks OK from
> the software side, though.

Did you manage to test it with the new "Easter bunny" adapter?

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 1/5] pinctrl: sh-pfc: r8a7796: Add PWM pins, groups and functions

[Geert Uytterhoeven]

On Wed, Apr 19, 2017 at 3:24 PM, Ulrich Hecht
<ulrich.hecht+renesas@gmail.com> wrote:
> From: Takeshi Kihara <takeshi.kihara.df@renesas.com>
>
> This patch adds PWM{0,1,2,3,4,5,6} pins, groups and functions to
> R8A7796 SoC.
>
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

i.e. will queue in sh-pfc-for-v4.13.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 2/5] clk: renesas: r8a7796: add PWM clock

[Geert Uytterhoeven]

On Wed, Apr 19, 2017 at 3:24 PM, Ulrich Hecht
<ulrich.hecht+renesas@gmail.com> wrote:
> From: Ryo Kodama <ryo.kodama.vz@renesas.com>
>
> This patch adds PWM clock for PWM.
>
> Signed-off-by: Ryo Kodama <ryo.kodama.vz@renesas.com>
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> ---
>  drivers/clk/renesas/r8a7796-cpg-mssr.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/renesas/r8a7796-cpg-mssr.c b/drivers/clk/renesas/r8a7796-cpg-mssr.c
> index 9d114b3..be0fc00 100644
> --- a/drivers/clk/renesas/r8a7796-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a7796-cpg-mssr.c
> @@ -151,6 +151,7 @@ static const struct mssr_mod_clk r8a7796_mod_clks[] __initconst = {
>         DEF_MOD("hscif1",                519,   R8A7796_CLK_S3D1),
>         DEF_MOD("hscif0",                520,   R8A7796_CLK_S3D1),
>         DEF_MOD("thermal",               522,   R8A7796_CLK_CP),
> +       DEF_MOD("pwm",                   523,   R8A7796_CLK_S3D4),

My copy of the R-Car Gen3 user manual rev. 0.53 says S0D12.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 3/5] arm64: dts: r8a7796: Add PWM device nodes

[Geert Uytterhoeven]

Hi Uli,

On Wed, Apr 19, 2017 at 3:24 PM, Ulrich Hecht
<ulrich.hecht+renesas@gmail.com> wrote:
> From: Takeshi Kihara <takeshi.kihara.df@renesas.com>
>
> This patch adds PWM{0,1,2,3,4,5,6} device nodes for R8A7796 SoC.
>
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> ---
>  arch/arm64/boot/dts/renesas/r8a7796.dtsi | 63 ++++++++++++++++++++++++++++++++
>  1 file changed, 63 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> index 798fe0f..578b318 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> @@ -455,6 +455,69 @@
>                         status = "disabled";
>                 };
>
> +               pwm0: pwm@e6e30000 {
> +                       compatible = "renesas,pwm-r8a7796", "renesas,pwm-rcar";

Please also send a patch to document "renesas,pwm-r8a7796" in the
renesas,pwm-rcar DT bindings.

> +                       reg = <0 0xe6e30000 0 0x10>;

A length of 8 would be sufficient.  Not a big issue due, as ioremap()
granularity
is PAGE_SIZE anyway.

> +                       #pwm-cells = <2>;
> +                       clocks = <&cpg CPG_MOD 523>;
> +                       power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;

Missing "resets = <&cpg 523>;"

> +                       status = "disabled";
> +               };

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 5/5] arm64: dts: r8a7795-salvator-x: Enable PWM

[Geert Uytterhoeven]

Hi Uli,

On Wed, Apr 19, 2017 at 3:24 PM, Ulrich Hecht
<ulrich.hecht+renesas@gmail.com> wrote:
> From: Takeshi Kihara <takeshi.kihara.df@renesas.com>
>
> This patch enables PWM{1,2} for Salvator-X board on R8A7795 SoC.
>
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> ---
>  arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> index bf4674e..842b0dd 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> @@ -282,6 +282,18 @@
>         };
>  };
>
> +&pwm1 {
> +       pinctrl-0 = <&pwm1_pins>;
> +       pinctrl-names = "default";
> +       status = "okay";
> +};
> +
> +&pwm2 {
> +       pinctrl-0 = <&pwm2_pins>;
> +       pinctrl-names = "default";
> +       status = "okay";
> +};
> +
>  &du {
>         pinctrl-0 = <&du_pins>;
>         pinctrl-names = "default";
> @@ -324,6 +336,16 @@
>         pinctrl-0 = <&scif_clk_pins>;
>         pinctrl-names = "default";
>
> +       pwm1_pins: pwm1 {
> +               groups = "pwm1_a", "pwm1_b";

Enabling both the A and B alternative pins?

> +               function = "pwm1";
> +       };
> +
> +       pwm2_pins: pwm2 {
> +               groups = "pwm2_a", "pwm2_b";

Enabling both the A and B alternative pins?

> +               function = "pwm2";
> +       };
> +

Oh, I wrote that before:
http://www.spinics.net/lists/linux-renesas-soc/msg00026.html

And we already have a correct v3 from you in patchwork:
https://patchwork.kernel.org/patch/8711801/

And Laurent enabled backlight independently:
https://lists.freedesktop.org/archives/dri-devel/2016-November/124385.html

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 4/5] arm64: dts: r8a7796-salvator-x: Add PWM device support

[Geert Uytterhoeven]

On Wed, Apr 19, 2017 at 3:24 PM, Ulrich Hecht
<ulrich.hecht+renesas@gmail.com> wrote:
> From: Ryo Kodama <ryo.kodama.vz@renesas.com>
>
> This patch adds support of PWM{1,2} device for Salvator-X board on
> R8A7796 SoC.
>
> Signed-off-by: Ryo Kodama <ryo.kodama.vz@renesas.com>
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> ---
>  arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
> index 14d9e51..b4ff1b6 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts

> @@ -114,6 +126,15 @@
>                 function = "avb";
>         };
>
> +       pwm1_pins: pwm1 {
> +               groups = "pwm1_a", "pwm1_b";
> +               function = "pwm1";
> +       };
> +       pwm2_pins: pwm2 {
> +               groups = "pwm2_a", "pwm2_b";
> +               function = "pwm2";
> +       };

Same brain damage as the r8a7795 counterpart...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 0/5] r8a7795/6 Salvator-X PWM enablement

[Ulrich Hecht]

On Thu, Apr 20, 2017 at 4:23 PM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> Hi Uli,
>
> On Wed, Apr 19, 2017 at 3:24 PM, Ulrich Hecht
> <ulrich.hecht+renesas@gmail.com> wrote:
>> This is a straight port from the BSP, enabling PWM1 and PWM2 on the
>> Salvator-X boards. For r8a7796 it also adds the required infrastructure
>> (clock and pins).
>>
>> Not fully tested because I cannot find my breakout adapter. Looks OK from
>> the software side, though.
>
> Did you manage to test it with the new "Easter bunny" adapter?

Yup, works. (Both the adapter and the PWMs.)

CU
Uli

Re: [PATCH 5/5] arm64: dts: r8a7795-salvator-x: Enable PWM

[Ulrich Hecht]

On Thu, Apr 20, 2017 at 7:51 PM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> And we already have a correct v3 from you in patchwork:
> https://patchwork.kernel.org/patch/8711801/

Whoops...

In my defense, that was over a year ago. Simon, any reason this didn't
make it in?

CU
Uli

Re: [PATCH 5/5] arm64: dts: r8a7795-salvator-x: Enable PWM

[Kuninori Morimoto]

Hi Ulrich

> > And we already have a correct v3 from you in patchwork:
> > https://patchwork.kernel.org/patch/8711801/
> 
> Whoops...
> 
> In my defense, that was over a year ago. Simon, any reason this didn't
> make it in?

If I were you, I track posted my patch, and re-send it
after 2weeks if nothing happen ;P

Best regards
---
Kuninori Morimoto

Re: [PATCH 5/5] arm64: dts: r8a7795-salvator-x: Enable PWM

[Ulrich Hecht]

On Fri, Apr 21, 2017 at 9:35 AM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
>
> Hi Ulrich
>
>> > And we already have a correct v3 from you in patchwork:
>> > https://patchwork.kernel.org/patch/8711801/
>>
>> Whoops...
>>
>> In my defense, that was over a year ago. Simon, any reason this didn't
>> make it in?
>
> If I were you, I track posted my patch, and re-send it
> after 2weeks if nothing happen ;P

Yes, mom...

(And to whoever might consider telling me that I should clean up my
office so I don't lose track of my equipment: I will make sure my next
patch will accidentally electrocute you. At compile time.)

CU
Uli

Re: [PATCH 5/5] arm64: dts: r8a7795-salvator-x: Enable PWM

[Simon Horman]

On Fri, Apr 21, 2017 at 09:26:04AM +0200, Ulrich Hecht wrote:
> On Thu, Apr 20, 2017 at 7:51 PM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
> > And we already have a correct v3 from you in patchwork:
> > https://patchwork.kernel.org/patch/8711801/
> 
> Whoops...
> 
> In my defense, that was over a year ago. Simon, any reason this didn't
> make it in?

Given it was over a year ago I hope you can understand that I don't recall
why this wasn't accepted. It is entirely possible that it was an oversight
on my part in which case I apologise - I am not a machine and I make mistakes.

I see that patches 3/5 and 4/5 also need updating.
Could you repost them along with this patch with the review comments
addressed? I will try not to let them slip through the cracks again.

Re: [PATCH 5/5] arm64: dts: r8a7795-salvator-x: Enable PWM

[Laurent Pinchart]

Hi Simon,

On Monday 24 Apr 2017 09:49:01 Simon Horman wrote:
> On Fri, Apr 21, 2017 at 09:26:04AM +0200, Ulrich Hecht wrote:
> > On Thu, Apr 20, 2017 at 7:51 PM, Geert Uytterhoeven wrote:
> > > And we already have a correct v3 from you in patchwork:
> > > https://patchwork.kernel.org/patch/8711801/
> > 
> > Whoops...
> > 
> > In my defense, that was over a year ago. Simon, any reason this didn't
> > make it in?
> 
> Given it was over a year ago I hope you can understand that I don't recall
> why this wasn't accepted. It is entirely possible that it was an oversight
> on my part in which case I apologise - I am not a machine and I make
> mistakes.
> 
> I see that patches 3/5 and 4/5 also need updating.
> Could you repost them along with this patch with the review comments
> addressed? I will try not to let them slip through the cracks again.

How about using pwm1 for backlight as done in "[PATCH v2 09/13] arm64: dts: 
r8a7795: salvator-x: Add panel backlight support" ?

-- 
Regards,

Laurent Pinchart

Re: [PATCH 5/5] arm64: dts: r8a7795-salvator-x: Enable PWM

[Ulrich Hecht]

On Mon, Apr 24, 2017 at 9:49 AM, Simon Horman <horms@verge.net.au> wrote:
> Given it was over a year ago I hope you can understand that I don't recall
> why this wasn't accepted.

I didn't remember having sent it myself, so, yes, I do understand. :)
I just thought there might be something obvious about it that I'm
missing.

> I see that patches 3/5 and 4/5 also need updating.
> Could you repost them along with this patch with the review comments
> addressed? I will try not to let them slip through the cracks again.

Will do, thank you.

CU
Uli

Re: [PATCH 5/5] arm64: dts: r8a7795-salvator-x: Enable PWM

[Ulrich Hecht]

On Mon, Apr 24, 2017 at 9:59 AM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> How about using pwm1 for backlight as done in "[PATCH v2 09/13] arm64: dts:
> r8a7795: salvator-x: Add panel backlight support" ?

Makes sense. Simon, should that go in a separate patch, or should I
add it to this one?

CU
Uli

Re: [PATCH 5/5] arm64: dts: r8a7795-salvator-x: Enable PWM

[Laurent Pinchart]

Hi Ulrich,

On Monday 24 Apr 2017 10:22:31 Ulrich Hecht wrote:
> On Mon, Apr 24, 2017 at 9:59 AM, Laurent Pinchart wrote:
> > How about using pwm1 for backlight as done in "[PATCH v2 09/13] arm64:
> > dts: r8a7795: salvator-x: Add panel backlight support" ?
> 
> Makes sense. Simon, should that go in a separate patch, or should I
> add it to this one?

How about applying "[PATCH v2 09/13] arm64: dts: r8a7795: salvator-x: Add 
panel backlight support" and rebasing this patch to only handle pwm2 ?

-- 
Regards,

Laurent Pinchart

Re: [PATCH 5/5] arm64: dts: r8a7795-salvator-x: Enable PWM

[Ulrich Hecht]

On Mon, Apr 24, 2017 at 10:35 AM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> Hi Ulrich,
>
> On Monday 24 Apr 2017 10:22:31 Ulrich Hecht wrote:
>> On Mon, Apr 24, 2017 at 9:59 AM, Laurent Pinchart wrote:
>> > How about using pwm1 for backlight as done in "[PATCH v2 09/13] arm64:
>> > dts: r8a7795: salvator-x: Add panel backlight support" ?
>>
>> Makes sense. Simon, should that go in a separate patch, or should I
>> add it to this one?
>
> How about applying "[PATCH v2 09/13] arm64: dts: r8a7795: salvator-x: Add
> panel backlight support" and rebasing this patch to only handle pwm2 ?

I'll do that then.

CU
Uli

Re: [PATCH 5/5] arm64: dts: r8a7795-salvator-x: Enable PWM

[Simon Horman]

On Mon, Apr 24, 2017 at 12:02:17PM +0200, Ulrich Hecht wrote:
> On Mon, Apr 24, 2017 at 10:35 AM, Laurent Pinchart
> <laurent.pinchart@ideasonboard.com> wrote:
> > Hi Ulrich,
> >
> > On Monday 24 Apr 2017 10:22:31 Ulrich Hecht wrote:
> >> On Mon, Apr 24, 2017 at 9:59 AM, Laurent Pinchart wrote:
> >> > How about using pwm1 for backlight as done in "[PATCH v2 09/13] arm64:
> >> > dts: r8a7795: salvator-x: Add panel backlight support" ?
> >>
> >> Makes sense. Simon, should that go in a separate patch, or should I
> >> add it to this one?
> >
> > How about applying "[PATCH v2 09/13] arm64: dts: r8a7795: salvator-x: Add
> > panel backlight support" and rebasing this patch to only handle pwm2 ?
> 
> I'll do that then.

Do you need any more input from me at this time?

Re: [PATCH 5/5] arm64: dts: r8a7795-salvator-x: Enable PWM

[Ulrich Hecht]

On Wed, Apr 26, 2017 at 9:50 AM, Simon Horman <horms@verge.net.au> wrote:
> On Mon, Apr 24, 2017 at 12:02:17PM +0200, Ulrich Hecht wrote:
>> On Mon, Apr 24, 2017 at 10:35 AM, Laurent Pinchart
>> <laurent.pinchart@ideasonboard.com> wrote:
>> > Hi Ulrich,
>> >
>> > On Monday 24 Apr 2017 10:22:31 Ulrich Hecht wrote:
>> >> On Mon, Apr 24, 2017 at 9:59 AM, Laurent Pinchart wrote:
>> >> > How about using pwm1 for backlight as done in "[PATCH v2 09/13] arm64:
>> >> > dts: r8a7795: salvator-x: Add panel backlight support" ?
>> >>
>> >> Makes sense. Simon, should that go in a separate patch, or should I
>> >> add it to this one?
>> >
>> > How about applying "[PATCH v2 09/13] arm64: dts: r8a7795: salvator-x: Add
>> > panel backlight support" and rebasing this patch to only handle pwm2 ?
>>
>> I'll do that then.
>
> Do you need any more input from me at this time?

No, I'm fine, thanks.

CU
Uli