All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Haozhong Zhang <haozhong.zhang@intel.com>
Cc: qemu-devel@nongnu.org, xen-devel@lists.xen.org,
	Xiao Guangrong <guangrong.xiao@linux.intel.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>,
	Konrad Rzeszutek Wilk <konrad@darnok.org>,
	Dan Williams <dan.j.williams@intel.com>
Subject: Re: [Qemu-devel] [RFC QEMU PATCH v2 10/10] qapi: extend 'query-memory-devices' to list devices of specified type
Date: Tue, 11 Apr 2017 10:56:53 +0200	[thread overview]
Message-ID: <87wparcofe.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20170320001249.25521-11-haozhong.zhang@intel.com> (Haozhong Zhang's message of "Mon, 20 Mar 2017 08:12:49 +0800")

Haozhong Zhang <haozhong.zhang@intel.com> writes:

> Add an optional argument 'devtype' to 'query-memory-devices', which
> is either 'dimm' or 'nvdimm'. If 'devtype' is missed or 'dimm', all
> memory devices will be listed. If 'devtype' is 'nvdimm', only nvdimm
> devices will be listed.

Basically, the argument provides limited server-side filtering of the
output of query-memory-devices.

> Signed-off-by: Haozhong Zhang <haozhong.zhang@intel.com>
> ---
> Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> Cc: Xiao Guangrong <guangrong.xiao@linux.intel.com>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Igor Mammedov <imammedo@redhat.com>
> Cc: Eric Blake <eblake@redhat.com>
> Cc: Markus Armbruster <armbru@redhat.com>
> ---
>  hmp.c                    |  3 +-
>  hw/mem/nvdimm.c          | 38 ++++++++++++++++++++++++++
>  hw/mem/pc-dimm.c         | 71 ++++++++++++++++++++++++++++--------------------
>  include/hw/mem/nvdimm.h  |  2 ++
>  include/hw/mem/pc-dimm.h |  1 +
>  qapi-schema.json         | 48 +++++++++++++++++++++++++++++---
>  qmp.c                    | 13 +++++++--
>  7 files changed, 140 insertions(+), 36 deletions(-)

Why is this server-side filtering worth the additional code and
complexity?  Why not simply filter in the client?  What's your use case?

[...]

WARNING: multiple messages have this Message-ID (diff)
From: Markus Armbruster <armbru@redhat.com>
To: Haozhong Zhang <haozhong.zhang@intel.com>
Cc: Xiao Guangrong <guangrong.xiao@linux.intel.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	qemu-devel@nongnu.org,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Konrad Rzeszutek Wilk <konrad@darnok.org>,
	Igor Mammedov <imammedo@redhat.com>,
	Dan Williams <dan.j.williams@intel.com>,
	xen-devel@lists.xen.org
Subject: Re: [Qemu-devel] [RFC QEMU PATCH v2 10/10] qapi: extend 'query-memory-devices' to list devices of specified type
Date: Tue, 11 Apr 2017 10:56:53 +0200	[thread overview]
Message-ID: <87wparcofe.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20170320001249.25521-11-haozhong.zhang@intel.com> (Haozhong Zhang's message of "Mon, 20 Mar 2017 08:12:49 +0800")

Haozhong Zhang <haozhong.zhang@intel.com> writes:

> Add an optional argument 'devtype' to 'query-memory-devices', which
> is either 'dimm' or 'nvdimm'. If 'devtype' is missed or 'dimm', all
> memory devices will be listed. If 'devtype' is 'nvdimm', only nvdimm
> devices will be listed.

Basically, the argument provides limited server-side filtering of the
output of query-memory-devices.

> Signed-off-by: Haozhong Zhang <haozhong.zhang@intel.com>
> ---
> Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> Cc: Xiao Guangrong <guangrong.xiao@linux.intel.com>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Igor Mammedov <imammedo@redhat.com>
> Cc: Eric Blake <eblake@redhat.com>
> Cc: Markus Armbruster <armbru@redhat.com>
> ---
>  hmp.c                    |  3 +-
>  hw/mem/nvdimm.c          | 38 ++++++++++++++++++++++++++
>  hw/mem/pc-dimm.c         | 71 ++++++++++++++++++++++++++++--------------------
>  include/hw/mem/nvdimm.h  |  2 ++
>  include/hw/mem/pc-dimm.h |  1 +
>  qapi-schema.json         | 48 +++++++++++++++++++++++++++++---
>  qmp.c                    | 13 +++++++--
>  7 files changed, 140 insertions(+), 36 deletions(-)

Why is this server-side filtering worth the additional code and
complexity?  Why not simply filter in the client?  What's your use case?

[...]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-04-11  8:57 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-20  0:12 [Qemu-devel] [RFC QEMU PATCH v2 00/10] Implement vNVDIMM for Xen HVM guest Haozhong Zhang
2017-03-20  0:12 ` Haozhong Zhang
2017-03-20  0:12 ` [Qemu-devel] [RFC QEMU PATCH v2 01/10] nvdimm xen: disable label support on Xen Haozhong Zhang
2017-03-20  0:12   ` Haozhong Zhang
2017-04-01 12:25   ` [Qemu-devel] " Konrad Rzeszutek Wilk
2017-04-01 12:25     ` Konrad Rzeszutek Wilk
2017-03-20  0:12 ` [Qemu-devel] [RFC QEMU PATCH v2 02/10] xen-hvm: initialize DM ACPI Haozhong Zhang
2017-03-20  0:12   ` Haozhong Zhang
2017-03-20  0:12 ` [Qemu-devel] [RFC QEMU PATCH v2 03/10] xen-hvm: support copying ACPI to guest memory Haozhong Zhang
2017-03-20  0:12   ` Haozhong Zhang
2017-03-20  0:12 ` [Qemu-devel] [RFC QEMU PATCH v2 04/10] nvdimm acpi: do not use fw_cfg on Xen Haozhong Zhang
2017-03-20  0:12   ` Haozhong Zhang
2017-03-20  0:12 ` [Qemu-devel] [RFC QEMU PATCH v2 05/10] nvdimm acpi: copy NFIT to Xen guest Haozhong Zhang
2017-03-20  0:12   ` Haozhong Zhang
2017-03-20  0:12 ` [Qemu-devel] [RFC QEMU PATCH v2 06/10] nvdimm acpi: build and copy NVDIMM namespace devices to guest on Xen Haozhong Zhang
2017-03-20  0:12   ` Haozhong Zhang
2017-03-20  0:12 ` [Qemu-devel] [RFC QEMU PATCH v2 07/10] xen-hvm: initiate building DM ACPI on i386 machine Haozhong Zhang
2017-03-20  0:12   ` Haozhong Zhang
2017-03-20  0:12 ` [Qemu-devel] [RFC QEMU PATCH v2 08/10] hostmem: add a host memory backend for Xen Haozhong Zhang
2017-03-20  0:12   ` Haozhong Zhang
2017-03-20  0:12 ` [Qemu-devel] [RFC QEMU PATCH v2 09/10] xen-hvm: create hotplug memory region on Xen Haozhong Zhang
2017-03-20  0:12   ` Haozhong Zhang
2017-03-20  0:12 ` [Qemu-devel] [RFC QEMU PATCH v2 10/10] qapi: extend 'query-memory-devices' to list devices of specified type Haozhong Zhang
2017-03-20  0:12   ` Haozhong Zhang
2017-04-11  8:56   ` Markus Armbruster [this message]
2017-04-11  8:56     ` [Qemu-devel] " Markus Armbruster
2017-03-20  0:26 ` [Qemu-devel] [RFC QEMU PATCH v2 00/10] Implement vNVDIMM for Xen HVM guest no-reply
2017-03-20  0:26   ` no-reply
2017-03-28 13:18 ` no-reply
2017-03-28 13:18   ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wparcofe.fsf@dusky.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=dan.j.williams@intel.com \
    --cc=dgilbert@redhat.com \
    --cc=guangrong.xiao@linux.intel.com \
    --cc=haozhong.zhang@intel.com \
    --cc=imammedo@redhat.com \
    --cc=konrad@darnok.org \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.