From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: stable@vger.kernel.org, nsekhar@ti.com, rogerq@ti.com,
januszx.dziedzic@intel.com
Subject: Re: [PATCH v4.4, v4.9] usb: dwc3: gadget: delay unmap of bounced requests
Date: Tue, 11 Apr 2017 10:02:04 +0300 [thread overview]
Message-ID: <87wparctqr.fsf@linux.intel.com> (raw)
In-Reply-To: <20170410152121.GA27662@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 1186 bytes --]
Hi,
Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
> On Mon, Apr 10, 2017 at 06:00:07PM +0300, Felipe Balbi wrote:
>> From: Janusz Dziedzic <januszx.dziedzic@intel.com>
>>
>> commit de288e36fe33f7e06fa272bc8e2f85aa386d99aa upstream.
>>
>> In the case of bounced ep0 requests, we must delay DMA operation until
>> after ->complete() otherwise we might overwrite contents of req->buf.
>>
>> This caused problems with RNDIS gadget.
>>
>> Cc: <stable@vger.kernel.org> # v4.4 v4.9
>> Fixes: d62145929992 ("usb: dwc3: gadget: always unmap EP0 requests")
>> Signed-off-by: Janusz Dziedzic <januszx.dziedzic@intel.com>
>> Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
>> ---
>>
>> cherry-picked, fixed up and compile tested
>
> This only would apply to 4.9-stable, 4.4-stable it still fails:
> patching file drivers/usb/dwc3/gadget.c
> Hunk #1 succeeded at 1193 with fuzz 2 (offset 1019 lines).
> Hunk #2 FAILED at 183.
> Hunk #3 FAILED at 195.
> 2 out of 3 hunks FAILED -- rejects in file drivers/usb/dwc3/gadget.c
>
> Care to send one for that tree?
dang, don't remember that code changing. Will do it shortly.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2017-04-11 7:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-10 15:00 [PATCH v4.4, v4.9] usb: dwc3: gadget: delay unmap of bounced requests Felipe Balbi
2017-04-10 15:21 ` Greg Kroah-Hartman
2017-04-11 7:02 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wparctqr.fsf@linux.intel.com \
--to=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=januszx.dziedzic@intel.com \
--cc=nsekhar@ti.com \
--cc=rogerq@ti.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.