All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ssb: Silence warning for unknown backplane revision
@ 2015-02-18 20:09 Larry Finger
  2015-02-26 12:57 ` Kalle Valo
  2015-03-03 13:54 ` Kalle Valo
  0 siblings, 2 replies; 4+ messages in thread
From: Larry Finger @ 2015-02-18 20:09 UTC (permalink / raw)
  To: kvalo; +Cc: linux-wireless, Larry Finger, Rafał Miłecki

When using a BCM4318 in a PCMCIA format, I get a startup message that the
device uses backplane revision 0xF000000. Next a WARNING is logged. Despite
the message, the device works fine, This patch silences the warning.

Cc: Rafał Miłecki <zajec5@gmail.com>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
 drivers/ssb/main.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
index 1e180c4..a48a743 100644
--- a/drivers/ssb/main.c
+++ b/drivers/ssb/main.c
@@ -1135,6 +1135,8 @@ static u32 ssb_tmslow_reject_bitmask(struct ssb_device *dev)
 	case SSB_IDLOW_SSBREV_25:     /* TODO - find the proper REJECT bit */
 	case SSB_IDLOW_SSBREV_27:     /* same here */
 		return SSB_TMSLOW_REJECT;	/* this is a guess */
+	case SSB_IDLOW_SSBREV:
+		break;
 	default:
 		WARN(1, KERN_INFO "ssb: Backplane Revision 0x%.8X\n", rev);
 	}
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ssb: Silence warning for unknown backplane revision
  2015-02-18 20:09 [PATCH] ssb: Silence warning for unknown backplane revision Larry Finger
@ 2015-02-26 12:57 ` Kalle Valo
  2015-02-26 16:06   ` Larry Finger
  2015-03-03 13:54 ` Kalle Valo
  1 sibling, 1 reply; 4+ messages in thread
From: Kalle Valo @ 2015-02-26 12:57 UTC (permalink / raw)
  To: Larry Finger; +Cc: linux-wireless, Rafał Miłecki

Larry Finger <Larry.Finger@lwfinger.net> writes:

> When using a BCM4318 in a PCMCIA format, I get a startup message that the
> device uses backplane revision 0xF000000. Next a WARNING is logged. Despite
> the message, the device works fine, This patch silences the warning.
>
> Cc: Rafał Miłecki <zajec5@gmail.com>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>

Should this go to 4.0?

-- 
Kalle Valo

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ssb: Silence warning for unknown backplane revision
  2015-02-26 12:57 ` Kalle Valo
@ 2015-02-26 16:06   ` Larry Finger
  0 siblings, 0 replies; 4+ messages in thread
From: Larry Finger @ 2015-02-26 16:06 UTC (permalink / raw)
  To: Kalle Valo; +Cc: linux-wireless, Rafał Miłecki

On 02/26/2015 06:57 AM, Kalle Valo wrote:
> Larry Finger <Larry.Finger@lwfinger.net> writes:
>
>> When using a BCM4318 in a PCMCIA format, I get a startup message that the
>> device uses backplane revision 0xF000000. Next a WARNING is logged. Despite
>> the message, the device works fine, This patch silences the warning.
>>
>> Cc: Rafał Miłecki <zajec5@gmail.com>
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>
> Should this go to 4.0?

As this one merely stops log spamming, sending it through NEXT is OK.

Larry



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ssb: Silence warning for unknown backplane revision
  2015-02-18 20:09 [PATCH] ssb: Silence warning for unknown backplane revision Larry Finger
  2015-02-26 12:57 ` Kalle Valo
@ 2015-03-03 13:54 ` Kalle Valo
  1 sibling, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2015-03-03 13:54 UTC (permalink / raw)
  To: Larry Finger; +Cc: linux-wireless, Rafał Miłecki

Larry Finger <Larry.Finger@lwfinger.net> writes:

> When using a BCM4318 in a PCMCIA format, I get a startup message that the
> device uses backplane revision 0xF000000. Next a WARNING is logged. Despite
> the message, the device works fine, This patch silences the warning.
>
> Cc: Rafał Miłecki <zajec5@gmail.com>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>

Thanks, applied to wireless-drivers-next.git.

-- 
Kalle Valo

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-03-03 13:54 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-18 20:09 [PATCH] ssb: Silence warning for unknown backplane revision Larry Finger
2015-02-26 12:57 ` Kalle Valo
2015-02-26 16:06   ` Larry Finger
2015-03-03 13:54 ` Kalle Valo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.