* [PATCH] drm/mgag200: Add missing write to index before accessing data register
@ 2013-05-31 20:33 Christopher Harvey
2013-05-31 20:40 ` Christopher Harvey
0 siblings, 1 reply; 2+ messages in thread
From: Christopher Harvey @ 2013-05-31 20:33 UTC (permalink / raw)
To: dri-devel; +Cc: Mathieu Larouche
This is a bug fix for some versions of g200se cards while doing
mode-setting.
Signed-off-by: Christopher Harvey <charvey@matrox.com>
Tested-by: Julia Lemire <jlemire@matrox.com>
Acked-by: Julia Lemire <jlemire@matrox.com>Julia Lemire <jlemire@matrox.com>
---
drivers/gpu/drm/mgag200/mgag200_mode.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c
index deed0bd..5b1a9e7 100644
--- a/drivers/gpu/drm/mgag200/mgag200_mode.c
+++ b/drivers/gpu/drm/mgag200/mgag200_mode.c
@@ -1034,13 +1034,14 @@ static int mga_crtc_mode_set(struct drm_crtc *crtc,
else
hi_pri_lvl = 5;
- WREG8(0x1fde, 0x06);
- WREG8(0x1fdf, hi_pri_lvl);
+ WREG8(MGAREG_CRTCEXT_INDEX, 0x06);
+ WREG8(MGAREG_CRTCEXT_DATA, hi_pri_lvl);
} else {
+ WREG8(MGAREG_CRTCEXT_INDEX, 0x06);
if (mdev->reg_1e24 >= 0x01)
- WREG8(0x1fdf, 0x03);
+ WREG8(MGAREG_CRTCEXT_DATA, 0x03);
else
- WREG8(0x1fdf, 0x04);
+ WREG8(MGAREG_CRTCEXT_DATA, 0x04);
}
}
return 0;
--
1.8.1.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/mgag200: Add missing write to index before accessing data register
2013-05-31 20:33 [PATCH] drm/mgag200: Add missing write to index before accessing data register Christopher Harvey
@ 2013-05-31 20:40 ` Christopher Harvey
0 siblings, 0 replies; 2+ messages in thread
From: Christopher Harvey @ 2013-05-31 20:40 UTC (permalink / raw)
To: dri-devel; +Cc: Mathieu Larouche
On Fri, May 31 2013, Christopher Harvey <charvey@matrox.com> wrote:
> This is a bug fix for some versions of g200se cards while doing
> mode-setting.
>
> Signed-off-by: Christopher Harvey <charvey@matrox.com>
> Tested-by: Julia Lemire <jlemire@matrox.com>
> Acked-by: Julia Lemire <jlemire@matrox.com>Julia Lemire <jlemire@matrox.com>
hmmm, feel free to delete the extra "Julia Lemire <jlemire@matrox.com>"
before applying. (or I could just re-send)
thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-31 20:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-31 20:33 [PATCH] drm/mgag200: Add missing write to index before accessing data register Christopher Harvey
2013-05-31 20:40 ` Christopher Harvey
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.