* [PATCH] ARM: mach-shmobile: r8a7740: cleanup I2C workaround method
@ 2012-04-13 9:41 Kuninori Morimoto
2012-04-16 1:41 ` Simon Horman
2012-04-17 22:18 ` Rafael J. Wysocki
0 siblings, 2 replies; 3+ messages in thread
From: Kuninori Morimoto @ 2012-04-13 9:41 UTC (permalink / raw)
To: linux-sh
Current workaround of I2C on r8a7740 used mdelay(),
but it were overkill.
This patch cleanup workaround delay.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
arch/arm/mach-shmobile/setup-r8a7740.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm/mach-shmobile/setup-r8a7740.c b/arch/arm/mach-shmobile/setup-r8a7740.c
index 14edb5c..34a1548 100644
--- a/arch/arm/mach-shmobile/setup-r8a7740.c
+++ b/arch/arm/mach-shmobile/setup-r8a7740.c
@@ -350,19 +350,19 @@ static void r8a7740_i2c_workaround(struct platform_device *pdev)
i2c_write(reg, ICSTART, i2c_read(reg, ICSTART) | 0x10);
i2c_read(reg, ICSTART); /* dummy read */
- mdelay(100);
+ udelay(10);
i2c_write(reg, ICCR, 0x01);
- i2c_read(reg, ICCR);
i2c_write(reg, ICSTART, 0x00);
- i2c_read(reg, ICSTART);
+
+ udelay(10);
i2c_write(reg, ICCR, 0x10);
- mdelay(100);
+ udelay(10);
i2c_write(reg, ICCR, 0x00);
- mdelay(100);
+ udelay(10);
i2c_write(reg, ICCR, 0x10);
- mdelay(100);
+ udelay(10);
iounmap(reg);
}
--
1.7.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: mach-shmobile: r8a7740: cleanup I2C workaround method
2012-04-13 9:41 [PATCH] ARM: mach-shmobile: r8a7740: cleanup I2C workaround method Kuninori Morimoto
@ 2012-04-16 1:41 ` Simon Horman
2012-04-17 22:18 ` Rafael J. Wysocki
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2012-04-16 1:41 UTC (permalink / raw)
To: linux-sh
On Fri, Apr 13, 2012 at 02:41:06AM -0700, Kuninori Morimoto wrote:
>
> Current workaround of I2C on r8a7740 used mdelay(),
> but it were overkill.
> This patch cleanup workaround delay.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Tested-by: Simon Horman <horms@verge.net.au>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: mach-shmobile: r8a7740: cleanup I2C workaround method
2012-04-13 9:41 [PATCH] ARM: mach-shmobile: r8a7740: cleanup I2C workaround method Kuninori Morimoto
2012-04-16 1:41 ` Simon Horman
@ 2012-04-17 22:18 ` Rafael J. Wysocki
1 sibling, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2012-04-17 22:18 UTC (permalink / raw)
To: linux-sh
On Monday, April 16, 2012, Simon Horman wrote:
> On Fri, Apr 13, 2012 at 02:41:06AM -0700, Kuninori Morimoto wrote:
> >
> > Current workaround of I2C on r8a7740 used mdelay(),
> > but it were overkill.
> > This patch cleanup workaround delay.
> >
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Tested-by: Simon Horman <horms@verge.net.au>
Applied to the r8a7740 branch of the renesas.git tree.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-04-17 22:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-13 9:41 [PATCH] ARM: mach-shmobile: r8a7740: cleanup I2C workaround method Kuninori Morimoto
2012-04-16 1:41 ` Simon Horman
2012-04-17 22:18 ` Rafael J. Wysocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.