All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet-OfajU3CKLf1/SzgSGea1oA@public.gmane.org>
To: Esben Haabendal <esbenhaabendal-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
	linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Esben Haabendal
	<eha-SIcX2qgNSybd/EuGEV170n9LOBIZ5rWg@public.gmane.org>,
	Joakim Tjernlund
	<joakim.tjernlund-SNLAxHN9vbcOP4wsBPIw7w@public.gmane.org>
Subject: Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by  read i2c_msg
Date: Thu, 28 May 2009 22:34:18 +0200	[thread overview]
Message-ID: <87ws8155md.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <d2b9ea600905281310p16f47ed0i454e25bf256d3010-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> (Esben Haabendal's message of "Thu\, 28 May 2009 22\:10\:56 +0200")

>>>>> "Esben" == Esben Haabendal <esbenhaabendal-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> writes:

Hi,

 >> I wanted to test it, but it does not apply due to line breaks (check
 >> @@-line). Also, I don't really have the time to dig into the topic, so I
 >> would only test it and give a tested-by-tag if it doesn't break anything
 >> here. I think Joakim would be a good candidate for an acked-by .

 Esben> I've checked both my copy in my "Sent" folder and the copy
 Esben> received from the list, and I cannot see any "line break"
 Esben> breakage of the patch.

I guess Wolfram referred to the context line which was clearly word wrapped:

@@ -456,17 +456,22 @@ static int mpc_xfer(struct i2c_adapter *adap,
struct i2c_msg *msgs, int num)

The other lines look fine.

-- 
Bye, Peter Korsgaard

WARNING: multiple messages have this Message-ID (diff)
From: Peter Korsgaard <jacmet@sunsite.dk>
To: Esben Haabendal <esbenhaabendal@gmail.com>
Cc: Esben Haabendal <eha@doredevelopment.dk>,
	linuxppc-dev@ozlabs.org, linux-i2c@vger.kernel.org,
	Ben Dooks <ben-linux@fluff.org>
Subject: Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg
Date: Thu, 28 May 2009 22:34:18 +0200	[thread overview]
Message-ID: <87ws8155md.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <d2b9ea600905281310p16f47ed0i454e25bf256d3010@mail.gmail.com> (Esben Haabendal's message of "Thu\, 28 May 2009 22\:10\:56 +0200")

>>>>> "Esben" == Esben Haabendal <esbenhaabendal@gmail.com> writes:

Hi,

 >> I wanted to test it, but it does not apply due to line breaks (check
 >> @@-line). Also, I don't really have the time to dig into the topic, so I
 >> would only test it and give a tested-by-tag if it doesn't break anything
 >> here. I think Joakim would be a good candidate for an acked-by .

 Esben> I've checked both my copy in my "Sent" folder and the copy
 Esben> received from the list, and I cannot see any "line break"
 Esben> breakage of the patch.

I guess Wolfram referred to the context line which was clearly word wrapped:

@@ -456,17 +456,22 @@ static int mpc_xfer(struct i2c_adapter *adap,
struct i2c_msg *msgs, int num)

The other lines look fine.

-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2009-05-28 20:34 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-19  5:22 [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg Esben Haabendal
2009-05-19  5:22 ` Esben Haabendal
2009-05-26 11:30 ` Esben Haabendal
2009-05-26 11:30   ` Esben Haabendal
     [not found]   ` <d2b9ea600905260430i72290901p9266de4cade049c1-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-05-26 21:33     ` Ben Dooks
2009-05-26 21:33       ` Ben Dooks
     [not found]       ` <20090526213351.GG23114-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
2009-05-28 17:17         ` Wolfram Sang
2009-05-28 17:17           ` Wolfram Sang
     [not found]           ` <20090528171726.GE3112-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2009-05-28 18:43             ` Joakim Tjernlund
2009-05-28 18:43               ` Joakim Tjernlund
2009-05-28 20:10           ` Esben Haabendal
     [not found]             ` <d2b9ea600905281310p16f47ed0i454e25bf256d3010-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-05-28 20:34               ` Peter Korsgaard [this message]
2009-05-28 20:34                 ` Peter Korsgaard
     [not found]                 ` <87ws8155md.fsf-uXGAPMMVk8amE9MCos8gUmSdvHPH+/yF@public.gmane.org>
2009-05-28 20:41                   ` Esben Haabendal
2009-05-28 20:41                     ` Esben Haabendal
     [not found]                     ` <d2b9ea600905281341s24efa4e3l6277a8aa5dec5bd-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-05-28 21:08                       ` Peter Korsgaard
2009-05-28 21:08                         ` Peter Korsgaard
     [not found]                         ` <87octd5415.fsf-uXGAPMMVk8amE9MCos8gUmSdvHPH+/yF@public.gmane.org>
2009-05-28 21:22                           ` Esben Haabendal
2009-05-28 21:22                             ` Esben Haabendal
2009-12-03 15:09         ` Michael Lawnick
2009-12-03 15:09           ` Michael Lawnick
     [not found]           ` <4B17D4C5.3070100-Mmb7MZpHnFY@public.gmane.org>
2009-12-03 15:29             ` Ben Dooks
2009-12-03 15:29               ` Ben Dooks
     [not found]               ` <20091203152916.GC23152-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>
2009-12-03 15:49                 ` Joakim Tjernlund
2009-12-03 15:49                   ` Joakim Tjernlund
2009-12-04  6:58                 ` Michael Lawnick
2009-12-04  6:58                   ` Michael Lawnick
2009-12-03 15:42           ` Joakim Tjernlund
2009-05-28 19:31     ` Grant Likely
2009-05-28 19:31       ` Grant Likely
     [not found]       ` <fa686aa40905281231o26c74a13v250bcedbd066e77b-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-05-28 20:15         ` Esben Haabendal
2009-05-28 20:15           ` Esben Haabendal
2009-06-02 22:25           ` Ben Dooks
2009-06-02 23:12 ` Grant Likely
2009-06-02 23:12   ` Grant Likely
2009-06-03  6:01   ` Grant Likely
2009-06-03  6:01     ` Grant Likely
     [not found] ` <4A124202.4010201-SIcX2qgNSybd/EuGEV170n9LOBIZ5rWg@public.gmane.org>
2009-06-14 13:16   ` Ben Dooks
2009-06-14 13:16     ` Ben Dooks
     [not found]     ` <20090614131605.GK20446-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
2009-06-14 14:04       ` Esben Haabendal
2009-06-14 14:04         ` Esben Haabendal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ws8155md.fsf@macbook.be.48ers.dk \
    --to=jacmet-ofaju3cklf1/szgsgea1oa@public.gmane.org \
    --cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
    --cc=eha-SIcX2qgNSybd/EuGEV170n9LOBIZ5rWg@public.gmane.org \
    --cc=esbenhaabendal-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=joakim.tjernlund-SNLAxHN9vbcOP4wsBPIw7w@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
    --cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.