* [PATCH] wifi: ath9k: convert msecs to jiffies where needed
@ 2023-06-13 13:46 Dmitry Antipov
2023-06-13 18:15 ` Toke Høiland-Jørgensen
2023-06-21 18:07 ` Kalle Valo
0 siblings, 2 replies; 7+ messages in thread
From: Dmitry Antipov @ 2023-06-13 13:46 UTC (permalink / raw)
To: Toke Høiland-Jørgensen
Cc: Kalle Valo, linux-wireless, Dmitry Antipov
Since 'ieee80211_queue_delayed_work()' expects timeout in
jiffies and not milliseconds, 'msecs_to_jiffies()' should
be used in 'ath_restart_work()' and '__ath9k_flush()'.
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
---
drivers/net/wireless/ath/ath9k/main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
index a4197c14f0a9..8311a45c5ea8 100644
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -203,7 +203,7 @@ void ath_cancel_work(struct ath_softc *sc)
void ath_restart_work(struct ath_softc *sc)
{
ieee80211_queue_delayed_work(sc->hw, &sc->hw_check_work,
- ATH_HW_CHECK_POLL_INT);
+ msecs_to_jiffies(ATH_HW_CHECK_POLL_INT));
if (AR_SREV_9340(sc->sc_ah) || AR_SREV_9330(sc->sc_ah))
ieee80211_queue_delayed_work(sc->hw, &sc->hw_pll_work,
@@ -2239,7 +2239,7 @@ void __ath9k_flush(struct ieee80211_hw *hw, u32 queues, bool drop,
}
ieee80211_queue_delayed_work(hw, &sc->hw_check_work,
- ATH_HW_CHECK_POLL_INT);
+ msecs_to_jiffies(ATH_HW_CHECK_POLL_INT));
}
static bool ath9k_tx_frames_pending(struct ieee80211_hw *hw)
--
2.40.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] wifi: ath9k: convert msecs to jiffies where needed
2023-06-13 13:46 [PATCH] wifi: ath9k: convert msecs to jiffies where needed Dmitry Antipov
@ 2023-06-13 18:15 ` Toke Høiland-Jørgensen
2023-06-14 5:14 ` Kalle Valo
2023-06-21 18:07 ` Kalle Valo
1 sibling, 1 reply; 7+ messages in thread
From: Toke Høiland-Jørgensen @ 2023-06-13 18:15 UTC (permalink / raw)
To: Dmitry Antipov; +Cc: Kalle Valo, linux-wireless, Dmitry Antipov
Dmitry Antipov <dmantipov@yandex.ru> writes:
> Since 'ieee80211_queue_delayed_work()' expects timeout in
> jiffies and not milliseconds, 'msecs_to_jiffies()' should
> be used in 'ath_restart_work()' and '__ath9k_flush()'.
>
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
I believe this warrants a:
Fixes: d63ffc45c5d3 ("ath9k: rename tx_complete_work to hw_check_work")
with that:
Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] wifi: ath9k: convert msecs to jiffies where needed
2023-06-13 18:15 ` Toke Høiland-Jørgensen
@ 2023-06-14 5:14 ` Kalle Valo
2023-06-14 11:39 ` Toke Høiland-Jørgensen
0 siblings, 1 reply; 7+ messages in thread
From: Kalle Valo @ 2023-06-14 5:14 UTC (permalink / raw)
To: Toke Høiland-Jørgensen; +Cc: Dmitry Antipov, linux-wireless
Toke Høiland-Jørgensen <toke@toke.dk> writes:
> Dmitry Antipov <dmantipov@yandex.ru> writes:
>
>> Since 'ieee80211_queue_delayed_work()' expects timeout in
>> jiffies and not milliseconds, 'msecs_to_jiffies()' should
>> be used in 'ath_restart_work()' and '__ath9k_flush()'.
>>
>> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
>
> I believe this warrants a:
>
> Fixes: d63ffc45c5d3 ("ath9k: rename tx_complete_work to hw_check_work")
I can add that.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] wifi: ath9k: convert msecs to jiffies where needed
2023-06-14 5:14 ` Kalle Valo
@ 2023-06-14 11:39 ` Toke Høiland-Jørgensen
2023-06-14 14:21 ` Kalle Valo
0 siblings, 1 reply; 7+ messages in thread
From: Toke Høiland-Jørgensen @ 2023-06-14 11:39 UTC (permalink / raw)
To: Kalle Valo; +Cc: Dmitry Antipov, linux-wireless
Kalle Valo <kvalo@kernel.org> writes:
> Toke Høiland-Jørgensen <toke@toke.dk> writes:
>
>> Dmitry Antipov <dmantipov@yandex.ru> writes:
>>
>>> Since 'ieee80211_queue_delayed_work()' expects timeout in
>>> jiffies and not milliseconds, 'msecs_to_jiffies()' should
>>> be used in 'ath_restart_work()' and '__ath9k_flush()'.
>>>
>>> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
>>
>> I believe this warrants a:
>>
>> Fixes: d63ffc45c5d3 ("ath9k: rename tx_complete_work to hw_check_work")
>
> I can add that.
I was hoping you'd say that - thanks :)
-Toke
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] wifi: ath9k: convert msecs to jiffies where needed
2023-06-14 11:39 ` Toke Høiland-Jørgensen
@ 2023-06-14 14:21 ` Kalle Valo
2023-06-15 12:26 ` Toke Høiland-Jørgensen
0 siblings, 1 reply; 7+ messages in thread
From: Kalle Valo @ 2023-06-14 14:21 UTC (permalink / raw)
To: Toke Høiland-Jørgensen; +Cc: Dmitry Antipov, linux-wireless
Toke Høiland-Jørgensen <toke@toke.dk> writes:
> Kalle Valo <kvalo@kernel.org> writes:
>
>> Toke Høiland-Jørgensen <toke@toke.dk> writes:
>>
>>> Dmitry Antipov <dmantipov@yandex.ru> writes:
>>>
>>>> Since 'ieee80211_queue_delayed_work()' expects timeout in
>>>> jiffies and not milliseconds, 'msecs_to_jiffies()' should
>>>> be used in 'ath_restart_work()' and '__ath9k_flush()'.
>>>>
>>>> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
>>>
>>> I believe this warrants a:
>>>
>>> Fixes: d63ffc45c5d3 ("ath9k: rename tx_complete_work to hw_check_work")
>>
>> I can add that.
>
> I was hoping you'd say that - thanks :)
BTW you can always assume that I can change or fix the commit messages.
Just let me know exactly what to change, being able to copy paste is
best :)
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] wifi: ath9k: convert msecs to jiffies where needed
2023-06-14 14:21 ` Kalle Valo
@ 2023-06-15 12:26 ` Toke Høiland-Jørgensen
0 siblings, 0 replies; 7+ messages in thread
From: Toke Høiland-Jørgensen @ 2023-06-15 12:26 UTC (permalink / raw)
To: Kalle Valo; +Cc: Dmitry Antipov, linux-wireless
Kalle Valo <kvalo@kernel.org> writes:
> Toke Høiland-Jørgensen <toke@toke.dk> writes:
>
>> Kalle Valo <kvalo@kernel.org> writes:
>>
>>> Toke Høiland-Jørgensen <toke@toke.dk> writes:
>>>
>>>> Dmitry Antipov <dmantipov@yandex.ru> writes:
>>>>
>>>>> Since 'ieee80211_queue_delayed_work()' expects timeout in
>>>>> jiffies and not milliseconds, 'msecs_to_jiffies()' should
>>>>> be used in 'ath_restart_work()' and '__ath9k_flush()'.
>>>>>
>>>>> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
>>>>
>>>> I believe this warrants a:
>>>>
>>>> Fixes: d63ffc45c5d3 ("ath9k: rename tx_complete_work to hw_check_work")
>>>
>>> I can add that.
>>
>> I was hoping you'd say that - thanks :)
>
> BTW you can always assume that I can change or fix the commit messages.
> Just let me know exactly what to change, being able to copy paste is
> best :)
ACK :)
-Toke
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] wifi: ath9k: convert msecs to jiffies where needed
2023-06-13 13:46 [PATCH] wifi: ath9k: convert msecs to jiffies where needed Dmitry Antipov
2023-06-13 18:15 ` Toke Høiland-Jørgensen
@ 2023-06-21 18:07 ` Kalle Valo
1 sibling, 0 replies; 7+ messages in thread
From: Kalle Valo @ 2023-06-21 18:07 UTC (permalink / raw)
To: Dmitry Antipov
Cc: Toke Høiland-Jørgensen, linux-wireless, Dmitry Antipov
Dmitry Antipov <dmantipov@yandex.ru> wrote:
> Since 'ieee80211_queue_delayed_work()' expects timeout in
> jiffies and not milliseconds, 'msecs_to_jiffies()' should
> be used in 'ath_restart_work()' and '__ath9k_flush()'.
>
> Fixes: d63ffc45c5d3 ("ath9k: rename tx_complete_work to hw_check_work")
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
> Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Patch applied to ath-next branch of ath.git, thanks.
2aa083acea9f wifi: ath9k: convert msecs to jiffies where needed
--
https://patchwork.kernel.org/project/linux-wireless/patch/20230613134655.248728-1-dmantipov@yandex.ru/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-06-21 18:07 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-13 13:46 [PATCH] wifi: ath9k: convert msecs to jiffies where needed Dmitry Antipov
2023-06-13 18:15 ` Toke Høiland-Jørgensen
2023-06-14 5:14 ` Kalle Valo
2023-06-14 11:39 ` Toke Høiland-Jørgensen
2023-06-14 14:21 ` Kalle Valo
2023-06-15 12:26 ` Toke Høiland-Jørgensen
2023-06-21 18:07 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.