From: Marc Zyngier <maz@kernel.org> To: Linus Walleij <linus.walleij@linaro.org> Cc: Bert Vermeulen <bert@biot.com>, Catalin Marinas <catalin.marinas@arm.com>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, linux-kernel <linux-kernel@vger.kernel.org>, Linux ARM <linux-arm-kernel@lists.infradead.org>, Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>, SoC Team <soc@kernel.org>, Rob Herring <robh+dt@kernel.org>, John Crispin <john@phrozen.org>, Felix Fietkau <nbd@nbd.name> Subject: Re: [PATCH 3/5] ARM: dts: Add basic support for EcoNet EN7523 Date: Fri, 30 Jul 2021 15:53:55 +0100 [thread overview] Message-ID: <87y29n26po.wl-maz@kernel.org> (raw) In-Reply-To: <CACRpkdYvMtE8b-Xiy6=Aiz20jvY0M0Bz9XmcEQDHhqeS+LErEA@mail.gmail.com> On Fri, 30 Jul 2021 15:31:36 +0100, Linus Walleij <linus.walleij@linaro.org> wrote: > > Paging Marc Z and Catalin just so they can see this: > > On Fri, Jul 30, 2021 at 3:49 PM Bert Vermeulen <bert@biot.com> wrote: > > > From: John Crispin <john@phrozen.org> > > > > Add basic support for EcoNet EN7523, enough for booting to console. > > > > The UART is basically 8250-compatible, except for the clock selection. > > A clock-frequency value is synthesized to get this to run at 115200 bps. > > > > Signed-off-by: John Crispin <john@phrozen.org> > > Signed-off-by: Bert Vermeulen <bert@biot.com> > (...) > > + gic: interrupt-controller@09000000 { > > + compatible = "arm,gic-v3"; > > + interrupt-controller; > > + #interrupt-cells = <3>; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + reg = <0x09000000 0x20000>, > > + <0x09080000 0x80000>; > > + interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_LOW>; > > + > > + its: gic-its@09020000 { > > + compatible = "arm,gic-v3-its"; > > + msi-controller; > > + #msi-cell = <1>; > > + reg = <0x090200000 0x20000>; > > + }; > > + }; > > Yup GICv3 on ARM32-only silicon. Hey, why not. But that's very unlikely, as Cortex-A7 doesn't have a GICv3 CPU interface built in (it only has the memory mapped version), and A53/57 were the first CPUs to ever support GICv3. I don't believe the description of the CPU in the DT is accurate. Bert, please send a kernel boot log. > > > + timer { > > + compatible = "arm,armv8-timer"; > > + interrupt-parent = <&gic>; > > + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, > > + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, > > + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, > > + <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>; Copy paste bug. These are not valid intspecs for GICv3. > > + clock-frequency = <25000000>; > > + }; > > Also arm,armv8-timer on ARM32-only silicon. Probably because that's not what it actually is. My bet is on A53 with a crippled firmware. > This is kind of a first. Thanks, M. -- Without deviation from the norm, progress is not possible.
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org> To: Linus Walleij <linus.walleij@linaro.org> Cc: Bert Vermeulen <bert@biot.com>, Catalin Marinas <catalin.marinas@arm.com>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, linux-kernel <linux-kernel@vger.kernel.org>, Linux ARM <linux-arm-kernel@lists.infradead.org>, Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>, SoC Team <soc@kernel.org>, Rob Herring <robh+dt@kernel.org>, John Crispin <john@phrozen.org>, Felix Fietkau <nbd@nbd.name> Subject: Re: [PATCH 3/5] ARM: dts: Add basic support for EcoNet EN7523 Date: Fri, 30 Jul 2021 15:53:55 +0100 [thread overview] Message-ID: <87y29n26po.wl-maz@kernel.org> (raw) Message-ID: <20210730145355.DNknVmm0WKTTCko-LtJSuF-rhInf0h3BWAu454q5pqo@z> (raw) In-Reply-To: <CACRpkdYvMtE8b-Xiy6=Aiz20jvY0M0Bz9XmcEQDHhqeS+LErEA@mail.gmail.com> On Fri, 30 Jul 2021 15:31:36 +0100, Linus Walleij <linus.walleij@linaro.org> wrote: > > Paging Marc Z and Catalin just so they can see this: > > On Fri, Jul 30, 2021 at 3:49 PM Bert Vermeulen <bert@biot.com> wrote: > > > From: John Crispin <john@phrozen.org> > > > > Add basic support for EcoNet EN7523, enough for booting to console. > > > > The UART is basically 8250-compatible, except for the clock selection. > > A clock-frequency value is synthesized to get this to run at 115200 bps. > > > > Signed-off-by: John Crispin <john@phrozen.org> > > Signed-off-by: Bert Vermeulen <bert@biot.com> > (...) > > + gic: interrupt-controller@09000000 { > > + compatible = "arm,gic-v3"; > > + interrupt-controller; > > + #interrupt-cells = <3>; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + reg = <0x09000000 0x20000>, > > + <0x09080000 0x80000>; > > + interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_LOW>; > > + > > + its: gic-its@09020000 { > > + compatible = "arm,gic-v3-its"; > > + msi-controller; > > + #msi-cell = <1>; > > + reg = <0x090200000 0x20000>; > > + }; > > + }; > > Yup GICv3 on ARM32-only silicon. Hey, why not. But that's very unlikely, as Cortex-A7 doesn't have a GICv3 CPU interface built in (it only has the memory mapped version), and A53/57 were the first CPUs to ever support GICv3. I don't believe the description of the CPU in the DT is accurate. Bert, please send a kernel boot log. > > > + timer { > > + compatible = "arm,armv8-timer"; > > + interrupt-parent = <&gic>; > > + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, > > + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, > > + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, > > + <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>; Copy paste bug. These are not valid intspecs for GICv3. > > + clock-frequency = <25000000>; > > + }; > > Also arm,armv8-timer on ARM32-only silicon. Probably because that's not what it actually is. My bet is on A53 with a crippled firmware. > This is kind of a first. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-30 14:53 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-30 13:45 [PATCH 0/4] Add support for EcoNet EN7523 SoC Bert Vermeulen 2021-07-30 13:45 ` Bert Vermeulen 2021-07-30 13:45 ` [PATCH 1/5] dt-bindings: Add vendor prefix for EcoNet Bert Vermeulen 2021-07-30 13:45 ` Bert Vermeulen 2021-08-06 21:02 ` Rob Herring 2021-08-06 21:02 ` Rob Herring 2021-07-30 13:45 ` [PATCH 2/5] dt-bindings: arm: econet: Add binding for EN7523 SoC and EVB Bert Vermeulen 2021-07-30 13:45 ` Bert Vermeulen 2021-08-06 21:04 ` Rob Herring 2021-08-06 21:04 ` Rob Herring 2021-07-30 13:45 ` [PATCH 3/5] ARM: dts: Add basic support for EcoNet EN7523 Bert Vermeulen 2021-07-30 13:45 ` Bert Vermeulen 2021-07-30 14:31 ` Linus Walleij 2021-07-30 14:31 ` Linus Walleij 2021-07-30 14:31 ` Linus Walleij 2021-07-30 14:53 ` Marc Zyngier [this message] 2021-07-30 14:53 ` Marc Zyngier 2021-08-01 9:07 ` Bert Vermeulen 2021-08-01 9:07 ` Bert Vermeulen 2021-08-01 9:07 ` Bert Vermeulen 2021-08-01 9:40 ` Arnd Bergmann 2021-08-01 9:40 ` Arnd Bergmann 2021-08-01 9:40 ` Arnd Bergmann 2021-08-01 9:50 ` Marc Zyngier 2021-08-01 9:50 ` Marc Zyngier 2021-07-30 14:45 ` Daniel Palmer 2021-07-30 14:45 ` Daniel Palmer 2021-07-30 14:45 ` Daniel Palmer 2021-07-30 14:46 ` Mark Rutland 2021-07-30 14:46 ` Mark Rutland 2021-08-04 16:41 ` Bert Vermeulen 2021-08-04 16:41 ` Bert Vermeulen 2021-08-06 20:59 ` Rob Herring 2021-08-06 20:59 ` Rob Herring 2021-07-30 14:59 ` Mark Rutland 2021-07-30 14:59 ` Mark Rutland 2021-08-06 20:52 ` Rob Herring 2021-08-06 20:52 ` Rob Herring 2021-07-30 16:47 ` Andre Przywara 2021-07-30 16:47 ` Andre Przywara 2021-07-30 17:23 ` Marc Zyngier 2021-07-30 17:23 ` Marc Zyngier 2021-07-30 13:45 ` [PATCH 4/5] ARM: Add basic support for EcoNet EN7523 SoC Bert Vermeulen 2021-07-30 13:45 ` Bert Vermeulen 2021-07-30 14:48 ` Arnd Bergmann 2021-07-30 14:48 ` Arnd Bergmann 2021-07-30 15:15 ` John Crispin 2021-07-30 15:15 ` John Crispin 2021-07-30 16:55 ` Arnd Bergmann 2021-07-30 16:55 ` Arnd Bergmann 2021-08-01 16:44 ` Ard Biesheuvel 2021-08-01 16:44 ` Ard Biesheuvel 2021-09-03 16:20 ` Felix Fietkau 2021-09-03 16:20 ` Felix Fietkau 2021-09-03 17:47 ` Ard Biesheuvel 2021-09-03 17:47 ` Ard Biesheuvel 2021-08-04 16:43 ` Bert Vermeulen 2021-08-04 16:43 ` Bert Vermeulen 2021-08-09 12:46 ` Geert Uytterhoeven 2021-08-09 12:46 ` Geert Uytterhoeven 2021-08-09 12:49 ` Ard Biesheuvel 2021-08-09 12:49 ` Ard Biesheuvel 2021-08-09 13:00 ` Bert Vermeulen 2021-08-09 13:00 ` Bert Vermeulen 2021-07-30 13:45 ` [PATCH 5/5] ARM: multi_v7_defconfig: Add " Bert Vermeulen 2021-07-30 13:45 ` Bert Vermeulen 2021-07-30 14:26 ` [PATCH 0/4] " Linus Walleij 2021-07-30 14:26 ` Linus Walleij
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87y29n26po.wl-maz@kernel.org \ --to=maz@kernel.org \ --cc=arnd@arndb.de \ --cc=bert@biot.com \ --cc=catalin.marinas@arm.com \ --cc=devicetree@vger.kernel.org \ --cc=john@phrozen.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=nbd@nbd.name \ --cc=olof@lixom.net \ --cc=robh+dt@kernel.org \ --cc=soc@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.