All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Jakub Kicinski <kuba@kernel.org>, Jiri Pirko <jiri@mellanox.com>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org
Subject: Is test_offload.py supposed to work?
Date: Fri, 20 Nov 2020 16:46:51 +0100	[thread overview]
Message-ID: <87y2iwqbdg.fsf@toke.dk> (raw)

Hi Jakub and Jiri

I am investigating an error with XDP offload mode, and figured I'd run
'test_offload.py' from selftests. However, I'm unable to get it to run
successfully; am I missing some config options, or has it simply
bit-rotted to the point where it no longer works?

[root@(none) bpf]# ./test_offload.py 
Test destruction of generic XDP...
Test TC non-offloaded...
Test TC non-offloaded isn't getting bound...
Test TC offloads are off by default...
FAIL: Missing or incorrect netlink extack message
  File "./test_offload.py", line 836, in <module>
    check_extack(err, "TC offload is disabled on net device.", args)
  File "./test_offload.py", line 657, in check_extack
    fail(not comp, "Missing or incorrect netlink extack message")
  File "./test_offload.py", line 86, in fail
    tb = "".join(traceback.extract_stack().format())


Commenting out that line gets me a bit further:

[root@(none) bpf]# ./test_offload.py 
Test destruction of generic XDP...
Test TC non-offloaded...
Test TC non-offloaded isn't getting bound...
Test TC offloads are off by default...
Test TC offload by default...
Test TC cBPF bytcode tries offload by default...
Test TC cBPF unbound bytecode doesn't offload...
Test non-0 chain offload...
FAIL: Missing or incorrect netlink extack message
  File "./test_offload.py", line 876, in <module>
    check_extack(err, "Driver supports only offload of chain 0.", args)
  File "./test_offload.py", line 657, in check_extack
    fail(not comp, "Missing or incorrect netlink extack message")
  File "./test_offload.py", line 86, in fail
    tb = "".join(traceback.extract_stack().format())


And again, after which I gave up:

[root@(none) bpf]# ./test_offload.py 
Test destruction of generic XDP...
Test TC non-offloaded...
Test TC non-offloaded isn't getting bound...
Test TC offloads are off by default...
Test TC offload by default...
Test TC cBPF bytcode tries offload by default...
Test TC cBPF unbound bytecode doesn't offload...
Test non-0 chain offload...
Test TC replace...
Test TC replace bad flags...
Test spurious extack from the driver...
Test TC offloads work...
FAIL: Missing or incorrect message from netdevsim in verifier log
  File "./test_offload.py", line 920, in <module>
    check_verifier_log(err, "[netdevsim] Hello from netdevsim!")
  File "./test_offload.py", line 671, in check_verifier_log
    fail(True, "Missing or incorrect message from netdevsim in verifier log")
  File "./test_offload.py", line 86, in fail
    tb = "".join(traceback.extract_stack().format())

-Toke


             reply	other threads:[~2020-11-20 15:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-20 15:46 Toke Høiland-Jørgensen [this message]
2020-11-20 16:48 ` Is test_offload.py supposed to work? Jakub Kicinski
2020-11-23 10:31   ` Toke Høiland-Jørgensen
2020-11-20 20:02 ` Andrii Nakryiko
2020-11-23 10:31   ` Toke Høiland-Jørgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y2iwqbdg.fsf@toke.dk \
    --to=toke@redhat.com \
    --cc=bpf@vger.kernel.org \
    --cc=jiri@mellanox.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.