Re: Is test_offload.py supposed to work?

From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: Jakub Kicinski <kuba@kernel.org>, Jiri Pirko <jiri@mellanox.com>,
	bpf <bpf@vger.kernel.org>, Networking <netdev@vger.kernel.org>
Subject: Re: Is test_offload.py supposed to work?
Date: Fri, 20 Nov 2020 12:02:52 -0800	[thread overview]
Message-ID: <CAEf4BzaYPXKCSUX50UrkvbGZ+Ne_YqHLfcgtXzwWFpCvugC8jg@mail.gmail.com> (raw)
In-Reply-To: <87y2iwqbdg.fsf@toke.dk>

On Fri, Nov 20, 2020 at 7:49 AM Toke Høiland-Jørgensen <toke@redhat.com> wrote:
>
> Hi Jakub and Jiri
>
> I am investigating an error with XDP offload mode, and figured I'd run
> 'test_offload.py' from selftests. However, I'm unable to get it to run
> successfully; am I missing some config options, or has it simply
> bit-rotted to the point where it no longer works?
>

See also discussion in [0]

  [0] https://www.spinics.net/lists/netdev/msg697523.html

> [root@(none) bpf]# ./test_offload.py
> Test destruction of generic XDP...
> Test TC non-offloaded...
> Test TC non-offloaded isn't getting bound...
> Test TC offloads are off by default...
> FAIL: Missing or incorrect netlink extack message
>   File "./test_offload.py", line 836, in <module>
>     check_extack(err, "TC offload is disabled on net device.", args)
>   File "./test_offload.py", line 657, in check_extack
>     fail(not comp, "Missing or incorrect netlink extack message")
>   File "./test_offload.py", line 86, in fail
>     tb = "".join(traceback.extract_stack().format())
>
>
> Commenting out that line gets me a bit further:
>
> [root@(none) bpf]# ./test_offload.py
> Test destruction of generic XDP...
> Test TC non-offloaded...
> Test TC non-offloaded isn't getting bound...
> Test TC offloads are off by default...
> Test TC offload by default...
> Test TC cBPF bytcode tries offload by default...
> Test TC cBPF unbound bytecode doesn't offload...
> Test non-0 chain offload...
> FAIL: Missing or incorrect netlink extack message
>   File "./test_offload.py", line 876, in <module>
>     check_extack(err, "Driver supports only offload of chain 0.", args)
>   File "./test_offload.py", line 657, in check_extack
>     fail(not comp, "Missing or incorrect netlink extack message")
>   File "./test_offload.py", line 86, in fail
>     tb = "".join(traceback.extract_stack().format())
>
>
> And again, after which I gave up:
>
> [root@(none) bpf]# ./test_offload.py
> Test destruction of generic XDP...
> Test TC non-offloaded...
> Test TC non-offloaded isn't getting bound...
> Test TC offloads are off by default...
> Test TC offload by default...
> Test TC cBPF bytcode tries offload by default...
> Test TC cBPF unbound bytecode doesn't offload...
> Test non-0 chain offload...
> Test TC replace...
> Test TC replace bad flags...
> Test spurious extack from the driver...
> Test TC offloads work...
> FAIL: Missing or incorrect message from netdevsim in verifier log
>   File "./test_offload.py", line 920, in <module>
>     check_verifier_log(err, "[netdevsim] Hello from netdevsim!")
>   File "./test_offload.py", line 671, in check_verifier_log
>     fail(True, "Missing or incorrect message from netdevsim in verifier log")
>   File "./test_offload.py", line 86, in fail
>     tb = "".join(traceback.extract_stack().format())
>
> -Toke
>