From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> To: Vaibhav Jain <vaibhav@linux.ibm.com>, linuxppc-dev@lists.ozlabs.org, linux-nvdimm@lists.01.org Cc: Vaibhav Jain <vaibhav@linux.ibm.com>, Michael Ellerman <mpe@ellerman.id.au> Subject: Re: [PATCH 1/2] powerpc/papr_scm: Fetch nvdimm performance stats from PHYP Date: Tue, 23 Jun 2020 11:22:07 +0530 [thread overview] Message-ID: <87y2oe2ut4.fsf@linux.ibm.com> (raw) In-Reply-To: <871rm649u0.fsf@linux.ibm.com> Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com> writes: > Vaibhav Jain <vaibhav@linux.ibm.com> writes: > + */ >> + seq_buf_init(&s, buf, PAGE_SIZE); >> + for (index = 0, stat = stats->scm_statistic; >> + index < stats->num_statistics; ++index, ++stat) { >> + seq_buf_printf(&s, "%.8s = 0x%016llX\n", >> + stat->statistic_id, stat->statistic_value); > > > That is raw number (statistic_id). Is that useful? Can we map them to user readable > strings? Ok i missed that "%.8s" . > >> + } >> + } >> + >> + kfree(stats); >> + return rc ? rc : seq_buf_used(&s); >> +} >> +DEVICE_ATTR_RO(perf_stats); -aneesh _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> To: Vaibhav Jain <vaibhav@linux.ibm.com>, linuxppc-dev@lists.ozlabs.org, linux-nvdimm@lists.01.org Cc: Vaibhav Jain <vaibhav@linux.ibm.com> Subject: Re: [PATCH 1/2] powerpc/papr_scm: Fetch nvdimm performance stats from PHYP Date: Tue, 23 Jun 2020 11:22:07 +0530 [thread overview] Message-ID: <87y2oe2ut4.fsf@linux.ibm.com> (raw) In-Reply-To: <871rm649u0.fsf@linux.ibm.com> Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com> writes: > Vaibhav Jain <vaibhav@linux.ibm.com> writes: > + */ >> + seq_buf_init(&s, buf, PAGE_SIZE); >> + for (index = 0, stat = stats->scm_statistic; >> + index < stats->num_statistics; ++index, ++stat) { >> + seq_buf_printf(&s, "%.8s = 0x%016llX\n", >> + stat->statistic_id, stat->statistic_value); > > > That is raw number (statistic_id). Is that useful? Can we map them to user readable > strings? Ok i missed that "%.8s" . > >> + } >> + } >> + >> + kfree(stats); >> + return rc ? rc : seq_buf_used(&s); >> +} >> +DEVICE_ATTR_RO(perf_stats); -aneesh
next prev parent reply other threads:[~2020-06-23 5:52 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-22 4:24 [PATCH 0/2] powerpc/papr_scm: add support for reporting NVDIMM 'life_used_percentage' metric Vaibhav Jain 2020-06-22 4:24 ` Vaibhav Jain 2020-06-22 4:24 ` [PATCH 1/2] powerpc/papr_scm: Fetch nvdimm performance stats from PHYP Vaibhav Jain 2020-06-22 4:24 ` Vaibhav Jain 2020-06-23 5:42 ` Aneesh Kumar K.V 2020-06-23 5:42 ` Aneesh Kumar K.V 2020-06-23 5:52 ` Aneesh Kumar K.V [this message] 2020-06-23 5:52 ` Aneesh Kumar K.V 2020-06-23 19:02 ` Ira Weiny 2020-06-23 19:02 ` Ira Weiny 2020-06-24 14:58 ` Vaibhav Jain 2020-06-24 14:58 ` Vaibhav Jain 2020-06-24 17:33 ` Ira Weiny 2020-06-24 17:33 ` Ira Weiny 2020-06-22 4:24 ` [PATCH 2/2] powerpc/papr_scm: Add support for fetching nvdimm 'fuel-gauge' metric Vaibhav Jain 2020-06-22 4:24 ` Vaibhav Jain 2020-06-23 19:14 ` Ira Weiny 2020-06-23 19:14 ` Ira Weiny 2020-06-24 14:03 ` Vaibhav Jain 2020-06-24 14:03 ` Vaibhav Jain
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87y2oe2ut4.fsf@linux.ibm.com \ --to=aneesh.kumar@linux.ibm.com \ --cc=linux-nvdimm@lists.01.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mpe@ellerman.id.au \ --cc=vaibhav@linux.ibm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.