All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Allow qca988x family to support ack rssi of tx data packets.
@ 2020-02-13  6:30 ` Yibo Zhao
  0 siblings, 0 replies; 8+ messages in thread
From: Yibo Zhao @ 2020-02-13  6:30 UTC (permalink / raw)
  To: ath10k; +Cc: linux-wireless, Yibo Zhao

Hardwares tested : QCA9887
Firmwares tested : 10.4-3.9.0.1-00036

Signed-off-by: Yibo Zhao <yiboz@codeaurora.org>
---
 drivers/net/wireless/ath/ath10k/hw.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/ath/ath10k/hw.c b/drivers/net/wireless/ath/ath10k/hw.c
index 2451e0f..57c58af 100644
--- a/drivers/net/wireless/ath/ath10k/hw.c
+++ b/drivers/net/wireless/ath/ath10k/hw.c
@@ -1131,6 +1131,7 @@ static int ath10k_get_htt_tx_data_rssi_pad(struct htt_resp *resp)
 
 const struct ath10k_hw_ops qca988x_ops = {
 	.set_coverage_class = ath10k_hw_qca988x_set_coverage_class,
+	.is_rssi_enable = ath10k_htt_tx_rssi_enable,
 };
 
 static int ath10k_qca99x0_rx_desc_get_l3_pad_bytes(struct htt_rx_desc *rxd)
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH] Allow qca988x family to support ack rssi of tx data packets.
@ 2020-02-13  6:30 ` Yibo Zhao
  0 siblings, 0 replies; 8+ messages in thread
From: Yibo Zhao @ 2020-02-13  6:30 UTC (permalink / raw)
  To: ath10k; +Cc: Yibo Zhao, linux-wireless

Hardwares tested : QCA9887
Firmwares tested : 10.4-3.9.0.1-00036

Signed-off-by: Yibo Zhao <yiboz@codeaurora.org>
---
 drivers/net/wireless/ath/ath10k/hw.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/ath/ath10k/hw.c b/drivers/net/wireless/ath/ath10k/hw.c
index 2451e0f..57c58af 100644
--- a/drivers/net/wireless/ath/ath10k/hw.c
+++ b/drivers/net/wireless/ath/ath10k/hw.c
@@ -1131,6 +1131,7 @@ static int ath10k_get_htt_tx_data_rssi_pad(struct htt_resp *resp)
 
 const struct ath10k_hw_ops qca988x_ops = {
 	.set_coverage_class = ath10k_hw_qca988x_set_coverage_class,
+	.is_rssi_enable = ath10k_htt_tx_rssi_enable,
 };
 
 static int ath10k_qca99x0_rx_desc_get_l3_pad_bytes(struct htt_rx_desc *rxd)
-- 
1.9.1

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH] Allow qca988x family to support ack rssi of tx data packets.
  2020-02-13  6:30 ` Yibo Zhao
  (?)
  (?)
@ 2020-03-12  8:20 ` Kalle Valo
  -1 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2020-03-12  8:20 UTC (permalink / raw)
  To: Yibo Zhao; +Cc: ath10k, linux-wireless, Yibo Zhao

Yibo Zhao <yiboz@codeaurora.org> wrote:

> Hardwares tested : QCA9887
> Firmwares tested : 10.4-3.9.0.1-00036
> 
> Signed-off-by: Yibo Zhao <yiboz@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

5637c4ca961b ath10k: allow qca988x family to support ack rssi of tx data packets.

-- 
https://patchwork.kernel.org/patch/11379917/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] Allow qca988x family to support ack rssi of tx data packets.
  2020-02-13  6:30 ` Yibo Zhao
  (?)
@ 2020-03-12  8:20 ` Kalle Valo
  2020-04-29 20:38   ` John Deere
  -1 siblings, 1 reply; 8+ messages in thread
From: Kalle Valo @ 2020-03-12  8:20 UTC (permalink / raw)
  To: Yibo Zhao; +Cc: linux-wireless, ath10k

Yibo Zhao <yiboz@codeaurora.org> wrote:

> Hardwares tested : QCA9887
> Firmwares tested : 10.4-3.9.0.1-00036
> 
> Signed-off-by: Yibo Zhao <yiboz@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

5637c4ca961b ath10k: allow qca988x family to support ack rssi of tx data packets.

-- 
https://patchwork.kernel.org/patch/11379917/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Re: [PATCH] Allow qca988x family to support ack rssi of tx data packets.
  2020-03-12  8:20 ` Kalle Valo
@ 2020-04-29 20:38   ` John Deere
  2020-04-30 10:28     ` Kalle Valo
  0 siblings, 1 reply; 8+ messages in thread
From: John Deere @ 2020-04-29 20:38 UTC (permalink / raw)
  To: ath10k

Hello,

 > Firmwares tested : 10.4-3.9.0.1-00036

The firmware above is unavailable anywhere.

This patch doesn't seem to work on the latest publicly available 
firmware, 10.2.4-1.0-00047.

Best regards,

John

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] Allow qca988x family to support ack rssi of tx data packets.
  2020-04-29 20:38   ` John Deere
@ 2020-04-30 10:28     ` Kalle Valo
  2020-04-30 14:16       ` John Deere
  0 siblings, 1 reply; 8+ messages in thread
From: Kalle Valo @ 2020-04-30 10:28 UTC (permalink / raw)
  To: John Deere; +Cc: ath10k

John Deere <24601deerej@gmail.com> writes:

> Hello,
>
>> Firmwares tested : 10.4-3.9.0.1-00036
>
> The firmware above is unavailable anywhere.

It's here:

https://github.com/kvalo/ath10k-firmware/blob/master/QCA9984/hw1.0/3.9.0.1/firmware-5.bin_10.4-3.9.0.1-00036

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] Allow qca988x family to support ack rssi of tx data packets.
  2020-04-30 10:28     ` Kalle Valo
@ 2020-04-30 14:16       ` John Deere
  2020-05-04  9:17         ` Kalle Valo
  0 siblings, 1 reply; 8+ messages in thread
From: John Deere @ 2020-04-30 14:16 UTC (permalink / raw)
  To: Kalle Valo; +Cc: ath10k

Hi Kalle,

That is for the QCA9884, not the QCA9887 as listed in the hardware tested.

On 4/30/20 6:28 PM, Kalle Valo wrote:
> John Deere <24601deerej@gmail.com> writes:
> 
>> Hello,
>>
>>> Firmwares tested : 10.4-3.9.0.1-00036
>>
>> The firmware above is unavailable anywhere.
> 
> It's here:
> 
> https://github.com/kvalo/ath10k-firmware/blob/master/QCA9984/hw1.0/3.9.0.1/firmware-5.bin_10.4-3.9.0.1-00036
> 

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] Allow qca988x family to support ack rssi of tx data packets.
  2020-04-30 14:16       ` John Deere
@ 2020-05-04  9:17         ` Kalle Valo
  0 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2020-05-04  9:17 UTC (permalink / raw)
  To: John Deere; +Cc: Yibo Zhao, ath10k

(Fixing top posting and adding Yibo)

John Deere <24601deerej@gmail.com> writes:

> On 4/30/20 6:28 PM, Kalle Valo wrote:
>> John Deere <24601deerej@gmail.com> writes:
>>
>>> Hello,
>>>
>>>> Firmwares tested : 10.4-3.9.0.1-00036
>>>
>>> The firmware above is unavailable anywhere.
>>
>> It's here:
>>
>> https://github.com/kvalo/ath10k-firmware/blob/master/QCA9984/hw1.0/3.9.0.1/firmware-5.bin_10.4-3.9.0.1-00036
>
> That is for the QCA9884, not the QCA9887 as listed in the hardware tested.

Good point, I missed that. Thanks for pointing it out.

So we are talking about this commit:

commit 5637c4ca961bc72ae3cce4bd5cbcecb5b8e32a54
Author:     Yibo Zhao <yiboz@codeaurora.org>
AuthorDate: Wed Mar 11 19:23:29 2020 +0200
Commit:     Kalle Valo <kvalo@codeaurora.org>
CommitDate: Thu Mar 12 10:20:02 2020 +0200

    ath10k: allow qca988x family to support ack rssi of tx data packets.
    
    Hardwares tested : QCA9887
    Firmwares tested : 10.4-3.9.0.1-00036
    
    Signed-off-by: Yibo Zhao <yiboz@codeaurora.org>
    Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Yibo, we don't have 10.4 firmware for QCA9887 so the commit log doesn't
make sense. How did you test this on QCA9887?

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2020-05-04  9:17 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-13  6:30 [PATCH] Allow qca988x family to support ack rssi of tx data packets Yibo Zhao
2020-02-13  6:30 ` Yibo Zhao
2020-03-12  8:20 ` Kalle Valo
2020-04-29 20:38   ` John Deere
2020-04-30 10:28     ` Kalle Valo
2020-04-30 14:16       ` John Deere
2020-05-04  9:17         ` Kalle Valo
2020-03-12  8:20 ` Kalle Valo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.