All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] board/ci20/genimage.cfg: drop hardcoded rootfs partition size
@ 2020-01-21 21:03 Peter Korsgaard
  2020-01-22 19:49 ` Peter Korsgaard
  2020-03-05 22:39 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Peter Korsgaard @ 2020-01-21 21:03 UTC (permalink / raw)
  To: buildroot

As recently reported to the list:
http://lists.busybox.net/pipermail/buildroot/2020-January/271937.html

The hardcoded rootfs partition size can lead to hard to understand build
failures if more packages are added.

So drop the hardcoded partition size.  Genimage will then size the partition
to match the size of the rootfs image (which by default is also 60MB for ext4).

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 board/ci20/genimage.cfg | 1 -
 1 file changed, 1 deletion(-)

diff --git a/board/ci20/genimage.cfg b/board/ci20/genimage.cfg
index fa3e7368d3..5f8a16c610 100644
--- a/board/ci20/genimage.cfg
+++ b/board/ci20/genimage.cfg
@@ -24,6 +24,5 @@ image sdcard.img {
         partition-type = 0x83
         image = "rootfs.ext4"
         offset = 2M
-        size = 60M
     }
 }
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] board/ci20/genimage.cfg: drop hardcoded rootfs partition size
  2020-01-21 21:03 [Buildroot] [PATCH] board/ci20/genimage.cfg: drop hardcoded rootfs partition size Peter Korsgaard
@ 2020-01-22 19:49 ` Peter Korsgaard
  2020-03-05 22:39 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2020-01-22 19:49 UTC (permalink / raw)
  To: buildroot

>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:

 > As recently reported to the list:
 > http://lists.busybox.net/pipermail/buildroot/2020-January/271937.html

 > The hardcoded rootfs partition size can lead to hard to understand build
 > failures if more packages are added.

 > So drop the hardcoded partition size.  Genimage will then size the partition
 > to match the size of the rootfs image (which by default is also 60MB for ext4).

 > Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] board/ci20/genimage.cfg: drop hardcoded rootfs partition size
  2020-01-21 21:03 [Buildroot] [PATCH] board/ci20/genimage.cfg: drop hardcoded rootfs partition size Peter Korsgaard
  2020-01-22 19:49 ` Peter Korsgaard
@ 2020-03-05 22:39 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2020-03-05 22:39 UTC (permalink / raw)
  To: buildroot

>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:

 > As recently reported to the list:
 > http://lists.busybox.net/pipermail/buildroot/2020-January/271937.html

 > The hardcoded rootfs partition size can lead to hard to understand build
 > failures if more packages are added.

 > So drop the hardcoded partition size.  Genimage will then size the partition
 > to match the size of the rootfs image (which by default is also 60MB for ext4).

 > Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

Committed to 2019.02.x and 2019.11.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-03-05 22:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-21 21:03 [Buildroot] [PATCH] board/ci20/genimage.cfg: drop hardcoded rootfs partition size Peter Korsgaard
2020-01-22 19:49 ` Peter Korsgaard
2020-03-05 22:39 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.