[Buildroot] [PATCH 1/1] package/go: bump to 1.13.6

[Buildroot] [PATCH 1/1] package/go: bump to 1.13.6

[Christian Stewart]

go1.13.6 (released 2020/01/09) includes fixes to the runtime and the net/http
package.

https://github.com/golang/go/issues?q=milestone=Go1.13.6

Signed-off-by: Christian Stewart <christian@paral.in>
---
 package/go/go.hash | 2 +-
 package/go/go.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/go/go.hash b/package/go/go.hash
index 7d92c80f2b..f440490b4e 100644
--- a/package/go/go.hash
+++ b/package/go/go.hash
@@ -1,3 +1,3 @@
 # From https://golang.org/dl/
-sha256	27d356e2a0b30d9983b60a788cf225da5f914066b37a6b4f69d457ba55a626ff  go1.13.5.src.tar.gz
+sha256	aae5be954bdc40bcf8006eb77e8d8a5dde412722bc8effcdaf9772620d06420c  go1.13.6.src.tar.gz
 sha256	2d36597f7117c38b006835ae7f537487207d8ec407aa9d9980794b2030cbc067  LICENSE
diff --git a/package/go/go.mk b/package/go/go.mk
index d6c732ccfd..ced44bbee0 100644
--- a/package/go/go.mk
+++ b/package/go/go.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-GO_VERSION = 1.13.5
+GO_VERSION = 1.13.6
 GO_SITE = https://storage.googleapis.com/golang
 GO_SOURCE = go$(GO_VERSION).src.tar.gz
 
-- 
2.24.1

[Buildroot] [PATCH 1/1] package/go: bump to 1.13.6

[Peter Korsgaard]

>>>>> "Christian" == Christian Stewart <christian@paral.in> writes:

 > go1.13.6 (released 2020/01/09) includes fixes to the runtime and the net/http
 > package.

 > https://github.com/golang/go/issues?q=milestone=Go1.13.6

 > Signed-off-by: Christian Stewart <christian@paral.in>

Committed, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 1/1] package/go: bump to 1.13.6

[Thomas Petazzoni]

Hello Christian,

On Thu,  9 Jan 2020 20:45:51 -0800
Christian Stewart <christian@paral.in> wrote:

> go1.13.6 (released 2020/01/09) includes fixes to the runtime and the net/http
> package.
> 
> https://github.com/golang/go/issues?q=milestone=Go1.13.6
> 
> Signed-off-by: Christian Stewart <christian@paral.in>

Since you're bumping Go, I was wondering what is the status of the "Go
module" support, that you started a while ago ? This was not a simple
topic, but I think this is something we can to get into Buildroot at
some point.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/1] package/go: bump to 1.13.6

[Christian Stewart]

Hi Thomas,

On Fri, Jan 10, 2020 at 12:17 AM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
> Since you're bumping Go, I was wondering what is the status of the "Go
> module" support, that you started a while ago ? This was not a simple
> topic, but I think this is something we can to get into Buildroot at
> some point.

It's less complex than you might think. Simply put: Go code is
organized into "packages." A package might be identified as
"github.com/urfave/cli" for example. Today, projects in Buildroot have
all code dependencies included with them under a "vendor" directory.
Buildroot creates a directory called "gopath" and symlinks the code
into the correct root import path within this "gopath" directory.

With Go modules, the compiler builds a virtual mapping of paths to
package identifiers, rather than relying on having the package
identifiers as paths on the filesystem.

In practice, this means that the patch is compatible with existing
code. The only difference is that we no longer need to create the
"gopath" directory.

The patch series is here: https://github.com/paralin/buildroot/tree/go-module

This particular version of the series uses the "extract" step to
download code dependencies to vendor/ if the vendor/ directory does
not exist. This should be moved into some sort of a extra part of the
download step. This way, vendor/ as downloaded by the Go tool when
running the "go mod vendor" command would be included in the source
archive.

I am going to submit a version of the series which assumes vendor/ is
always there (as is the case currently) and simply introduces the
change of removing the gopath symlink step. This will be a good
conservative first step.

Best regards,
Christian