All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: pxa: remove CONFIG_SND_PXA2XX_AC97 in pxa_defconfig
@ 2019-02-19 14:51 ` Arnd Bergmann
  0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2019-02-19 14:51 UTC (permalink / raw)
  To: arm
  Cc: Robert Jarzmik, Daniel Mack, Haojian Zhuang, linux-arm-kernel,
	Arnd Bergmann, linux-kernel

The CONFIG_SND_PXA2XX_AC97 driver is for the old AC97 bus implementation,
and conflicts with all the new-style AC97 drivers after the conversion,
so the drivers we want all get turned off.

Not disabling the symbol however does the right thing, and we get
the drivers that are selectively enabled here.

Fixes: 25540f68c871 ("ASoC: pxa: change ac97 dependencies")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm/configs/pxa_defconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/configs/pxa_defconfig b/arch/arm/configs/pxa_defconfig
index 6bb506edb1f5..7f0f1fda2584 100644
--- a/arch/arm/configs/pxa_defconfig
+++ b/arch/arm/configs/pxa_defconfig
@@ -482,7 +482,6 @@ CONFIG_SND_PCM_OSS=m
 CONFIG_SND_DYNAMIC_MINORS=y
 CONFIG_SND_VERBOSE_PRINTK=y
 CONFIG_SND_DEBUG=y
-CONFIG_SND_PXA2XX_AC97=m
 CONFIG_SND_USB_AUDIO=m
 CONFIG_SND_SOC=m
 CONFIG_SND_ATMEL_SOC=m
-- 
2.20.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] ARM: pxa: remove CONFIG_SND_PXA2XX_AC97 in pxa_defconfig
@ 2019-02-19 14:51 ` Arnd Bergmann
  0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2019-02-19 14:51 UTC (permalink / raw)
  To: arm
  Cc: Arnd Bergmann, linux-kernel, Haojian Zhuang, Daniel Mack,
	Robert Jarzmik, linux-arm-kernel

The CONFIG_SND_PXA2XX_AC97 driver is for the old AC97 bus implementation,
and conflicts with all the new-style AC97 drivers after the conversion,
so the drivers we want all get turned off.

Not disabling the symbol however does the right thing, and we get
the drivers that are selectively enabled here.

Fixes: 25540f68c871 ("ASoC: pxa: change ac97 dependencies")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm/configs/pxa_defconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/configs/pxa_defconfig b/arch/arm/configs/pxa_defconfig
index 6bb506edb1f5..7f0f1fda2584 100644
--- a/arch/arm/configs/pxa_defconfig
+++ b/arch/arm/configs/pxa_defconfig
@@ -482,7 +482,6 @@ CONFIG_SND_PCM_OSS=m
 CONFIG_SND_DYNAMIC_MINORS=y
 CONFIG_SND_VERBOSE_PRINTK=y
 CONFIG_SND_DEBUG=y
-CONFIG_SND_PXA2XX_AC97=m
 CONFIG_SND_USB_AUDIO=m
 CONFIG_SND_SOC=m
 CONFIG_SND_ATMEL_SOC=m
-- 
2.20.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: pxa: remove CONFIG_SND_PXA2XX_AC97 in pxa_defconfig
  2019-02-19 14:51 ` Arnd Bergmann
@ 2019-02-27 22:00   ` Robert Jarzmik
  -1 siblings, 0 replies; 6+ messages in thread
From: Robert Jarzmik @ 2019-02-27 22:00 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: arm, Daniel Mack, Haojian Zhuang, linux-arm-kernel, linux-kernel

Arnd Bergmann <arnd@arndb.de> writes:

> The CONFIG_SND_PXA2XX_AC97 driver is for the old AC97 bus implementation,
> and conflicts with all the new-style AC97 drivers after the conversion,
> so the drivers we want all get turned off.
>
> Not disabling the symbol however does the right thing, and we get
> the drivers that are selectively enabled here.
>
> Fixes: 25540f68c871 ("ASoC: pxa: change ac97 dependencies")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Yes, most certainly.

Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>

Cheers.

--
Robert

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: pxa: remove CONFIG_SND_PXA2XX_AC97 in pxa_defconfig
@ 2019-02-27 22:00   ` Robert Jarzmik
  0 siblings, 0 replies; 6+ messages in thread
From: Robert Jarzmik @ 2019-02-27 22:00 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: linux-arm-kernel, arm, Haojian Zhuang, Daniel Mack, linux-kernel

Arnd Bergmann <arnd@arndb.de> writes:

> The CONFIG_SND_PXA2XX_AC97 driver is for the old AC97 bus implementation,
> and conflicts with all the new-style AC97 drivers after the conversion,
> so the drivers we want all get turned off.
>
> Not disabling the symbol however does the right thing, and we get
> the drivers that are selectively enabled here.
>
> Fixes: 25540f68c871 ("ASoC: pxa: change ac97 dependencies")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Yes, most certainly.

Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>

Cheers.

--
Robert

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: pxa: remove CONFIG_SND_PXA2XX_AC97 in pxa_defconfig
  2019-02-27 22:00   ` Robert Jarzmik
@ 2019-03-01 14:03     ` Arnd Bergmann
  -1 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2019-03-01 14:03 UTC (permalink / raw)
  To: Robert Jarzmik
  Cc: arm-soc, Daniel Mack, Haojian Zhuang, Linux ARM,
	Linux Kernel Mailing List

On Wed, Feb 27, 2019 at 11:01 PM Robert Jarzmik <robert.jarzmik@free.fr> wrote:
>
> Arnd Bergmann <arnd@arndb.de> writes:
>
> > The CONFIG_SND_PXA2XX_AC97 driver is for the old AC97 bus implementation,
> > and conflicts with all the new-style AC97 drivers after the conversion,
> > so the drivers we want all get turned off.
> >
> > Not disabling the symbol however does the right thing, and we get
> > the drivers that are selectively enabled here.
> >
> > Fixes: 25540f68c871 ("ASoC: pxa: change ac97 dependencies")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Yes, most certainly.
>
> Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>

Applied to arm/defconfig for 5.1 now, thanks for taking a look

    Arnd

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: pxa: remove CONFIG_SND_PXA2XX_AC97 in pxa_defconfig
@ 2019-03-01 14:03     ` Arnd Bergmann
  0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2019-03-01 14:03 UTC (permalink / raw)
  To: Robert Jarzmik
  Cc: Linux ARM, arm-soc, Haojian Zhuang, Daniel Mack,
	Linux Kernel Mailing List

On Wed, Feb 27, 2019 at 11:01 PM Robert Jarzmik <robert.jarzmik@free.fr> wrote:
>
> Arnd Bergmann <arnd@arndb.de> writes:
>
> > The CONFIG_SND_PXA2XX_AC97 driver is for the old AC97 bus implementation,
> > and conflicts with all the new-style AC97 drivers after the conversion,
> > so the drivers we want all get turned off.
> >
> > Not disabling the symbol however does the right thing, and we get
> > the drivers that are selectively enabled here.
> >
> > Fixes: 25540f68c871 ("ASoC: pxa: change ac97 dependencies")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Yes, most certainly.
>
> Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>

Applied to arm/defconfig for 5.1 now, thanks for taking a look

    Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-03-01 14:03 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-19 14:51 [PATCH] ARM: pxa: remove CONFIG_SND_PXA2XX_AC97 in pxa_defconfig Arnd Bergmann
2019-02-19 14:51 ` Arnd Bergmann
2019-02-27 22:00 ` Robert Jarzmik
2019-02-27 22:00   ` Robert Jarzmik
2019-03-01 14:03   ` Arnd Bergmann
2019-03-01 14:03     ` Arnd Bergmann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.