* [lustre-devel] [PATCH] lustre: lprocfs: fix return value of lprocfs_read_helper
@ 2018-10-18 4:40 NeilBrown
2018-10-20 19:06 ` James Simmons
0 siblings, 1 reply; 2+ messages in thread
From: NeilBrown @ 2018-10-18 4:40 UTC (permalink / raw)
To: lustre-devel
This should be 'ret', not zero.
Fixes: fdedd94509fd ("staging/lustre/lvfs: remove the lvfs layer")
Signed-off-by: NeilBrown <neilb@suse.com>
---
drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
index dc1d540e05c7..edac88440b41 100644
--- a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
+++ b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
@@ -1509,7 +1509,7 @@ __s64 lprocfs_read_helper(struct lprocfs_counter *lc,
break;
}
- return 0;
+ return ret;
}
EXPORT_SYMBOL(lprocfs_read_helper);
--
2.14.0.rc0.dirty
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.lustre.org/pipermail/lustre-devel-lustre.org/attachments/20181018/4d0fd838/attachment.sig>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [lustre-devel] [PATCH] lustre: lprocfs: fix return value of lprocfs_read_helper
2018-10-18 4:40 [lustre-devel] [PATCH] lustre: lprocfs: fix return value of lprocfs_read_helper NeilBrown
@ 2018-10-20 19:06 ` James Simmons
0 siblings, 0 replies; 2+ messages in thread
From: James Simmons @ 2018-10-20 19:06 UTC (permalink / raw)
To: lustre-devel
> This should be 'ret', not zero.
I bet that was one of my first patches to the linux lustre client since
its a really old patch. Thanks for figuring that out.
Reviewed-by: James Simmons <jsimmons@infradead.org>
> Fixes: fdedd94509fd ("staging/lustre/lvfs: remove the lvfs layer")
> Signed-off-by: NeilBrown <neilb@suse.com>
> ---
> drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
> index dc1d540e05c7..edac88440b41 100644
> --- a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
> +++ b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
> @@ -1509,7 +1509,7 @@ __s64 lprocfs_read_helper(struct lprocfs_counter *lc,
> break;
> }
>
> - return 0;
> + return ret;
> }
> EXPORT_SYMBOL(lprocfs_read_helper);
>
> --
> 2.14.0.rc0.dirty
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-20 19:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-18 4:40 [lustre-devel] [PATCH] lustre: lprocfs: fix return value of lprocfs_read_helper NeilBrown
2018-10-20 19:06 ` James Simmons
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.