All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH for-2.10 00/19] crypto: add af_alg-backend support
@ 2017-04-10  9:03 Longpeng(Mike)
  2017-04-10  9:28 ` Gonglei (Arei)
  2017-04-11 14:43 ` Markus Armbruster
  0 siblings, 2 replies; 4+ messages in thread
From: Longpeng(Mike) @ 2017-04-10  9:03 UTC (permalink / raw)
  To: berrange, kraxel, pbonzini, eblake, armbru
  Cc: xuquan8, arei.gonglei, qemu-devel, Longpeng(Mike)

The AF_ALG socket family is the userspace interface for linux
crypto API, users can use it to access hardware accelerators.

This patchset adds a afalg-backend for qemu crypto subsystem. Currently
when performs encrypt/decrypt, we'll try afalg-backend first and will
back to libiary-backend if it failed.

In the next step, It would support a command parameter to specifies
which backends prefer to and some other improvements.

Longpeng(Mike) (19):
  crypto: cipher: introduce context free function
  crypto: cipher: introduce qcrypto_cipher_ctx_new for gcrypt-backend
  crypto: cipher: introduce qcrypto_cipher_ctx_new for nettle-backend
  crypto: cipher: introduce qcrypto_cipher_ctx_new for builtin-backend
  crypto: cipher: add cipher driver framework
  crypto: hash: add hash driver framework
  crypto: hmac: move crypto/hmac.h into include/crypto/
  crypto: hmac: introduce qcrypto_hmac_ctx_new for gcrypt-backend
  crypto: hmac: introduce qcrypto_hmac_ctx_new for nettle-backend
  crypto: hmac: introduce qcrypto_hmac_ctx_new for glib-backend
  crypto: hmac: add hmac driver framework
  socket: add af_alg family support
  crypto: introduce some common functions for af_alg backend
  crypto: cipher: add af_alg cipher support
  tests: crypto: add cipher speed case
  crypto: hash: add af_alg hash support
  tests: crypto: add hash speed case
  crypto: hmac: add af_alg hmac support
  tests: crypto: add hmac speed case

 configure                   |  21 ++++
 crypto/Makefile.objs        |   3 +
 crypto/afalg-comm.c         |  71 ++++++++++++++
 crypto/cipher-afalg.c       | 229 +++++++++++++++++++++++++++++++++++++++++++
 crypto/cipher-builtin.c     | 120 +++++++++++------------
 crypto/cipher-gcrypt.c      |  99 ++++++++++---------
 crypto/cipher-nettle.c      |  78 ++++++++-------
 crypto/cipher.c             |  87 +++++++++++++++++
 crypto/hash-afalg.c         | 232 ++++++++++++++++++++++++++++++++++++++++++++
 crypto/hash-gcrypt.c        |  17 ++--
 crypto/hash-glib.c          |  17 ++--
 crypto/hash-nettle.c        |  17 ++--
 crypto/hash.c               |  22 +++++
 crypto/hmac-gcrypt.c        |  39 ++++----
 crypto/hmac-glib.c          |  58 +++++------
 crypto/hmac-nettle.c        |  39 +++-----
 crypto/hmac.c               |  65 +++++++++++++
 crypto/hmac.h               | 166 -------------------------------
 include/crypto/afalg-comm.h |  74 ++++++++++++++
 include/crypto/cipher.h     |  29 ++++++
 include/crypto/hash.h       |  13 +++
 include/crypto/hmac.h       | 199 +++++++++++++++++++++++++++++++++++++
 include/qemu/sockets.h      |   6 ++
 qapi-schema.json            |  21 +++-
 tests/test-crypto-cipher.c  |  92 ++++++++++++++++--
 tests/test-crypto-hash.c    |  56 ++++++++++-
 tests/test-crypto-hmac.c    |  66 ++++++++++++-
 util/qemu-sockets.c         |  91 +++++++++++++++++
 28 files changed, 1599 insertions(+), 428 deletions(-)
 create mode 100644 crypto/afalg-comm.c
 create mode 100644 crypto/cipher-afalg.c
 create mode 100644 crypto/hash-afalg.c
 delete mode 100644 crypto/hmac.h
 create mode 100644 include/crypto/afalg-comm.h
 create mode 100644 include/crypto/hmac.h

-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 00/19] crypto: add af_alg-backend support
  2017-04-10  9:03 [Qemu-devel] [PATCH for-2.10 00/19] crypto: add af_alg-backend support Longpeng(Mike)
@ 2017-04-10  9:28 ` Gonglei (Arei)
  2017-04-10  9:40   ` Longpeng (Mike)
  2017-04-11 14:43 ` Markus Armbruster
  1 sibling, 1 reply; 4+ messages in thread
From: Gonglei (Arei) @ 2017-04-10  9:28 UTC (permalink / raw)
  To: longpeng, berrange, kraxel, pbonzini, eblake, armbru
  Cc: Xuquan (Quan Xu), qemu-devel


> -----Original Message-----
> From: longpeng
> Sent: Monday, April 10, 2017 5:03 PM
> To: berrange@redhat.com; kraxel@redhat.com; pbonzini@redhat.com;
> eblake@redhat.com; armbru@redhat.com
> Cc: Xuquan (Quan Xu); Gonglei (Arei); qemu-devel@nongnu.org; longpeng
> Subject: [PATCH for-2.10 00/19] crypto: add af_alg-backend support
> 
> The AF_ALG socket family is the userspace interface for linux
> crypto API, users can use it to access hardware accelerators.
> 
> This patchset adds a afalg-backend for qemu crypto subsystem. Currently
> when performs encrypt/decrypt, we'll try afalg-backend first and will
> back to libiary-backend if it failed.
> 
Cool.

You'd better add the performance compared results in the cover letter. :)


Regards,
-Gonglei

> In the next step, It would support a command parameter to specifies
> which backends prefer to and some other improvements.
> 
> Longpeng(Mike) (19):
>   crypto: cipher: introduce context free function
>   crypto: cipher: introduce qcrypto_cipher_ctx_new for gcrypt-backend
>   crypto: cipher: introduce qcrypto_cipher_ctx_new for nettle-backend
>   crypto: cipher: introduce qcrypto_cipher_ctx_new for builtin-backend
>   crypto: cipher: add cipher driver framework
>   crypto: hash: add hash driver framework
>   crypto: hmac: move crypto/hmac.h into include/crypto/
>   crypto: hmac: introduce qcrypto_hmac_ctx_new for gcrypt-backend
>   crypto: hmac: introduce qcrypto_hmac_ctx_new for nettle-backend
>   crypto: hmac: introduce qcrypto_hmac_ctx_new for glib-backend
>   crypto: hmac: add hmac driver framework
>   socket: add af_alg family support
>   crypto: introduce some common functions for af_alg backend
>   crypto: cipher: add af_alg cipher support
>   tests: crypto: add cipher speed case
>   crypto: hash: add af_alg hash support
>   tests: crypto: add hash speed case
>   crypto: hmac: add af_alg hmac support
>   tests: crypto: add hmac speed case
> 
>  configure                   |  21 ++++
>  crypto/Makefile.objs        |   3 +
>  crypto/afalg-comm.c         |  71 ++++++++++++++
>  crypto/cipher-afalg.c       | 229
> +++++++++++++++++++++++++++++++++++++++++++
>  crypto/cipher-builtin.c     | 120 +++++++++++------------
>  crypto/cipher-gcrypt.c      |  99 ++++++++++---------
>  crypto/cipher-nettle.c      |  78 ++++++++-------
>  crypto/cipher.c             |  87 +++++++++++++++++
>  crypto/hash-afalg.c         | 232
> ++++++++++++++++++++++++++++++++++++++++++++
>  crypto/hash-gcrypt.c        |  17 ++--
>  crypto/hash-glib.c          |  17 ++--
>  crypto/hash-nettle.c        |  17 ++--
>  crypto/hash.c               |  22 +++++
>  crypto/hmac-gcrypt.c        |  39 ++++----
>  crypto/hmac-glib.c          |  58 +++++------
>  crypto/hmac-nettle.c        |  39 +++-----
>  crypto/hmac.c               |  65 +++++++++++++
>  crypto/hmac.h               | 166 -------------------------------
>  include/crypto/afalg-comm.h |  74 ++++++++++++++
>  include/crypto/cipher.h     |  29 ++++++
>  include/crypto/hash.h       |  13 +++
>  include/crypto/hmac.h       | 199
> +++++++++++++++++++++++++++++++++++++
>  include/qemu/sockets.h      |   6 ++
>  qapi-schema.json            |  21 +++-
>  tests/test-crypto-cipher.c  |  92 ++++++++++++++++--
>  tests/test-crypto-hash.c    |  56 ++++++++++-
>  tests/test-crypto-hmac.c    |  66 ++++++++++++-
>  util/qemu-sockets.c         |  91 +++++++++++++++++
>  28 files changed, 1599 insertions(+), 428 deletions(-)
>  create mode 100644 crypto/afalg-comm.c
>  create mode 100644 crypto/cipher-afalg.c
>  create mode 100644 crypto/hash-afalg.c
>  delete mode 100644 crypto/hmac.h
>  create mode 100644 include/crypto/afalg-comm.h
>  create mode 100644 include/crypto/hmac.h
> 
> --
> 1.8.3.1
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 00/19] crypto: add af_alg-backend support
  2017-04-10  9:28 ` Gonglei (Arei)
@ 2017-04-10  9:40   ` Longpeng (Mike)
  0 siblings, 0 replies; 4+ messages in thread
From: Longpeng (Mike) @ 2017-04-10  9:40 UTC (permalink / raw)
  To: Gonglei (Arei)
  Cc: berrange, kraxel, pbonzini, eblake, armbru, Xuquan (Quan Xu), qemu-devel

On 2017/4/10 17:28, Gonglei (Arei) wrote:

> 
>> -----Original Message-----
>> From: longpeng
>> Sent: Monday, April 10, 2017 5:03 PM
>> To: berrange@redhat.com; kraxel@redhat.com; pbonzini@redhat.com;
>> eblake@redhat.com; armbru@redhat.com
>> Cc: Xuquan (Quan Xu); Gonglei (Arei); qemu-devel@nongnu.org; longpeng
>> Subject: [PATCH for-2.10 00/19] crypto: add af_alg-backend support
>>
>> The AF_ALG socket family is the userspace interface for linux
>> crypto API, users can use it to access hardware accelerators.
>>
>> This patchset adds a afalg-backend for qemu crypto subsystem. Currently
>> when performs encrypt/decrypt, we'll try afalg-backend first and will
>> back to libiary-backend if it failed.
>>
> Cool.
> 
> You'd better add the performance compared results in the cover letter. :)
> 


OK, I'll add the results in V2.

In addition, I find a BUG in patch 18, please review other parts and I'll fix
them together in next version.

> 
> Regards,
> -Gonglei
> 
>> In the next step, It would support a command parameter to specifies
>> which backends prefer to and some other improvements.
>>
>> Longpeng(Mike) (19):
>>   crypto: cipher: introduce context free function
>>   crypto: cipher: introduce qcrypto_cipher_ctx_new for gcrypt-backend
>>   crypto: cipher: introduce qcrypto_cipher_ctx_new for nettle-backend
>>   crypto: cipher: introduce qcrypto_cipher_ctx_new for builtin-backend
>>   crypto: cipher: add cipher driver framework
>>   crypto: hash: add hash driver framework
>>   crypto: hmac: move crypto/hmac.h into include/crypto/
>>   crypto: hmac: introduce qcrypto_hmac_ctx_new for gcrypt-backend
>>   crypto: hmac: introduce qcrypto_hmac_ctx_new for nettle-backend
>>   crypto: hmac: introduce qcrypto_hmac_ctx_new for glib-backend
>>   crypto: hmac: add hmac driver framework
>>   socket: add af_alg family support
>>   crypto: introduce some common functions for af_alg backend
>>   crypto: cipher: add af_alg cipher support
>>   tests: crypto: add cipher speed case
>>   crypto: hash: add af_alg hash support
>>   tests: crypto: add hash speed case
>>   crypto: hmac: add af_alg hmac support
>>   tests: crypto: add hmac speed case
>>
>>  configure                   |  21 ++++
>>  crypto/Makefile.objs        |   3 +
>>  crypto/afalg-comm.c         |  71 ++++++++++++++
>>  crypto/cipher-afalg.c       | 229
>> +++++++++++++++++++++++++++++++++++++++++++
>>  crypto/cipher-builtin.c     | 120 +++++++++++------------
>>  crypto/cipher-gcrypt.c      |  99 ++++++++++---------
>>  crypto/cipher-nettle.c      |  78 ++++++++-------
>>  crypto/cipher.c             |  87 +++++++++++++++++
>>  crypto/hash-afalg.c         | 232
>> ++++++++++++++++++++++++++++++++++++++++++++
>>  crypto/hash-gcrypt.c        |  17 ++--
>>  crypto/hash-glib.c          |  17 ++--
>>  crypto/hash-nettle.c        |  17 ++--
>>  crypto/hash.c               |  22 +++++
>>  crypto/hmac-gcrypt.c        |  39 ++++----
>>  crypto/hmac-glib.c          |  58 +++++------
>>  crypto/hmac-nettle.c        |  39 +++-----
>>  crypto/hmac.c               |  65 +++++++++++++
>>  crypto/hmac.h               | 166 -------------------------------
>>  include/crypto/afalg-comm.h |  74 ++++++++++++++
>>  include/crypto/cipher.h     |  29 ++++++
>>  include/crypto/hash.h       |  13 +++
>>  include/crypto/hmac.h       | 199
>> +++++++++++++++++++++++++++++++++++++
>>  include/qemu/sockets.h      |   6 ++
>>  qapi-schema.json            |  21 +++-
>>  tests/test-crypto-cipher.c  |  92 ++++++++++++++++--
>>  tests/test-crypto-hash.c    |  56 ++++++++++-
>>  tests/test-crypto-hmac.c    |  66 ++++++++++++-
>>  util/qemu-sockets.c         |  91 +++++++++++++++++
>>  28 files changed, 1599 insertions(+), 428 deletions(-)
>>  create mode 100644 crypto/afalg-comm.c
>>  create mode 100644 crypto/cipher-afalg.c
>>  create mode 100644 crypto/hash-afalg.c
>>  delete mode 100644 crypto/hmac.h
>>  create mode 100644 include/crypto/afalg-comm.h
>>  create mode 100644 include/crypto/hmac.h
>>
>> --
>> 1.8.3.1
>>
> 
> 
> .
> 


-- 
Regards,
Longpeng(Mike)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.10 00/19] crypto: add af_alg-backend support
  2017-04-10  9:03 [Qemu-devel] [PATCH for-2.10 00/19] crypto: add af_alg-backend support Longpeng(Mike)
  2017-04-10  9:28 ` Gonglei (Arei)
@ 2017-04-11 14:43 ` Markus Armbruster
  1 sibling, 0 replies; 4+ messages in thread
From: Markus Armbruster @ 2017-04-11 14:43 UTC (permalink / raw)
  To: Longpeng(Mike)
  Cc: berrange, kraxel, pbonzini, eblake, xuquan8, arei.gonglei, qemu-devel

"Longpeng(Mike)" <longpeng2@huawei.com> writes:

> The AF_ALG socket family is the userspace interface for linux
> crypto API, users can use it to access hardware accelerators.
>
> This patchset adds a afalg-backend for qemu crypto subsystem. Currently
> when performs encrypt/decrypt, we'll try afalg-backend first and will
> back to libiary-backend if it failed.
>
> In the next step, It would support a command parameter to specifies
> which backends prefer to and some other improvements.

Series isn't threaded properly even though your Message-Id suggests use
of git-send-email.  Did you pass --no-thread, or do you have
sendemail.thread configured off?

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-04-11 14:44 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-10  9:03 [Qemu-devel] [PATCH for-2.10 00/19] crypto: add af_alg-backend support Longpeng(Mike)
2017-04-10  9:28 ` Gonglei (Arei)
2017-04-10  9:40   ` Longpeng (Mike)
2017-04-11 14:43 ` Markus Armbruster

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.