From: Ioan-Adrian Ratiu <adi@adirat.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: perex@perex.cz, o-takashi@sakamocchi.jp,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] ALSA: usb-audio: Fix irq/process data synchronization
Date: Wed, 04 Jan 2017 11:15:58 +0200 [thread overview]
Message-ID: <87y3yrdw35.fsf@adiPC.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <s5h7f6bmj8z.wl-tiwai@suse.de>
On Wed, 04 Jan 2017, Takashi Iwai <tiwai@suse.de> wrote:
> On Mon, 02 Jan 2017 16:50:30 +0100,
> Ioan-Adrian Ratiu wrote:
>>
>> --- a/sound/usb/pcm.c
>> +++ b/sound/usb/pcm.c
> (snip)
>> @@ -850,7 +850,7 @@ static int snd_usb_pcm_prepare(struct snd_pcm_substream *substream)
>> /* for playback, submit the URBs now; otherwise, the first hwptr_done
>> * updates for all URBs would happen at the same time when starting */
>> if (subs->direction == SNDRV_PCM_STREAM_PLAYBACK)
>> - ret = start_endpoints(subs, true);
>> + return start_endpoints(subs);
>
> Here you miss the unlock below.
>
>>
>> unlock:
>> snd_usb_unlock_shutdown(subs->stream->chip);
>
> ... and this must be the reason of the hang up at disconnection, where
> the driver ways forever at wait_event() in usb_audio_disconnect().
>
> Could you fix this and resubmit v3? Other than that, it looks OK.
Sure, I'll resubmit v3 by tonight hopefully.
Thank you for taking a look at this, I didn't have a chance to look it
again since I posted v2.
Ionel
>
>
> thanks,
>
> Takashi
next prev parent reply other threads:[~2017-01-04 9:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-02 15:50 [PATCH v2 0/2] ALSA: Fix usb-audio races Ioan-Adrian Ratiu
2017-01-02 15:50 ` [PATCH v2 1/2] ALSA: usb-audio: Fix irq/process data synchronization Ioan-Adrian Ratiu
2017-01-04 6:28 ` Takashi Iwai
2017-01-04 6:28 ` Takashi Iwai
2017-01-04 9:15 ` Ioan-Adrian Ratiu [this message]
2017-01-02 15:50 ` [PATCH v2 2/2] ALSA: usb-audio: test EP_FLAG_RUNNING at urb completion Ioan-Adrian Ratiu
2017-01-03 7:30 ` [PATCH v2 0/2] ALSA: Fix usb-audio races Ioan-Adrian Ratiu
2017-01-03 8:47 ` Ioan-Adrian Ratiu
2017-01-03 9:15 ` Takashi Iwai
2017-01-03 9:15 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3yrdw35.fsf@adiPC.i-did-not-set--mail-host-address--so-tickle-me \
--to=adi@adirat.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=o-takashi@sakamocchi.jp \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.