All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] dhcp: add config option for delayed-ack feature of dhcp server
@ 2013-07-19 12:46 Thomas De Schampheleire
  2013-07-19 13:15 ` Gustavo Zacarias
  2013-07-19 21:40 ` Peter Korsgaard
  0 siblings, 2 replies; 6+ messages in thread
From: Thomas De Schampheleire @ 2013-07-19 12:46 UTC (permalink / raw)
  To: buildroot

This patch creates a config option for the ISC DHCP server to allow passing
--enable-delayed-ack to its configure script.

Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>

---
 package/dhcp/Config.in |  5 +++++
 package/dhcp/dhcp.mk   |  4 ++++
 2 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/package/dhcp/Config.in b/package/dhcp/Config.in
--- a/package/dhcp/Config.in
+++ b/package/dhcp/Config.in
@@ -13,6 +13,11 @@ config BR2_PACKAGE_DHCP_SERVER
 	help
 	  DHCP server from the ISC DHCP distribution.
 
+config BR2_PACKAGE_DHCP_SERVER_DELAYED_ACK
+	bool "Enable delayed ACK feature"
+	depends on BR2_PACKAGE_DHCP_SERVER
+	help
+	  Enable delayed ACK feature in the ISC DHCP server.
 
 config BR2_PACKAGE_DHCP_RELAY
 	bool "dhcp relay"
diff --git a/package/dhcp/dhcp.mk b/package/dhcp/dhcp.mk
--- a/package/dhcp/dhcp.mk
+++ b/package/dhcp/dhcp.mk
@@ -17,6 +17,10 @@ DHCP_CONF_OPT = \
 	--with-cli-pid-file=/var/run/dhclient.pid \
 	--with-relay-pid-file=/var/run/dhcrelay.pid
 
+ifeq ($(BR2_PACKAGE_DHCP_SERVER_DELAYED_ACK),y)
+        DHCP_CONF_OPT += --enable-delayed-ack
+endif
+
 ifneq ($(BR2_INET_IPV6),y)
         DHCP_CONF_OPT += --disable-dhcpv6
 endif

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] dhcp: add config option for delayed-ack feature of dhcp server
  2013-07-19 12:46 [Buildroot] [PATCH] dhcp: add config option for delayed-ack feature of dhcp server Thomas De Schampheleire
@ 2013-07-19 13:15 ` Gustavo Zacarias
  2013-07-19 13:32   ` Thomas De Schampheleire
  2013-07-19 21:40 ` Peter Korsgaard
  1 sibling, 1 reply; 6+ messages in thread
From: Gustavo Zacarias @ 2013-07-19 13:15 UTC (permalink / raw)
  To: buildroot

On 07/19/2013 09:46 AM, Thomas De Schampheleire wrote:
> +config BR2_PACKAGE_DHCP_SERVER_DELAYED_ACK
> +	bool "Enable delayed ACK feature"
> +	depends on BR2_PACKAGE_DHCP_SERVER
> +	help
> +	  Enable delayed ACK feature in the ISC DHCP server.

Can't you just enable it to avoid config cluttering?
AFAIK it's not a default-on option in dhcpd.conf
Regards.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] dhcp: add config option for delayed-ack feature of dhcp server
  2013-07-19 13:15 ` Gustavo Zacarias
@ 2013-07-19 13:32   ` Thomas De Schampheleire
  2013-07-19 13:43     ` Gustavo Zacarias
  0 siblings, 1 reply; 6+ messages in thread
From: Thomas De Schampheleire @ 2013-07-19 13:32 UTC (permalink / raw)
  To: buildroot

Hi Gustavo,

On Fri, Jul 19, 2013 at 3:15 PM, Gustavo Zacarias
<gustavo@zacarias.com.ar> wrote:
> On 07/19/2013 09:46 AM, Thomas De Schampheleire wrote:
>> +config BR2_PACKAGE_DHCP_SERVER_DELAYED_ACK
>> +     bool "Enable delayed ACK feature"
>> +     depends on BR2_PACKAGE_DHCP_SERVER
>> +     help
>> +       Enable delayed ACK feature in the ISC DHCP server.
>
> Can't you just enable it to avoid config cluttering?
> AFAIK it's not a default-on option in dhcpd.conf

Maybe, I'm not an expert on the matter. The RELNOTES file says the
following for 4.1.0a2:
 "Delayed-ack is now a compile-time option, compiled out by default.
  This feature is simply too experimental for right now, and causes
  some problems to some failover installations.  We will revisit this
  in future releases."

and also the man page:
"Please note that as delayed-ack is currently experimental, the delayed-ack
feature is not compiled in by default, but must be enabled at compile time
with \'./configure --enable-delayed-ack\'."

but in the meantime we're several releases further. I don't know if it
is still accurate.

I think you're right that it's not default-on in dhcpd.conf.

What do you say, enable it always at compile time?

Thanks,
Thomas

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] dhcp: add config option for delayed-ack feature of dhcp server
  2013-07-19 13:32   ` Thomas De Schampheleire
@ 2013-07-19 13:43     ` Gustavo Zacarias
  2013-07-19 14:52       ` Thomas De Schampheleire
  0 siblings, 1 reply; 6+ messages in thread
From: Gustavo Zacarias @ 2013-07-19 13:43 UTC (permalink / raw)
  To: buildroot

On 07/19/2013 10:32 AM, Thomas De Schampheleire wrote:

> but in the meantime we're several releases further. I don't know if it
> is still accurate.
> 
> I think you're right that it's not default-on in dhcpd.conf.
> 
> What do you say, enable it always at compile time?

Oh yes it's a default, so let's just keep the option.
(includes/dhcpd.h -> DEFAULT_DELAYED_ACK)
I hate build options :)
Regards.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] dhcp: add config option for delayed-ack feature of dhcp server
  2013-07-19 13:43     ` Gustavo Zacarias
@ 2013-07-19 14:52       ` Thomas De Schampheleire
  0 siblings, 0 replies; 6+ messages in thread
From: Thomas De Schampheleire @ 2013-07-19 14:52 UTC (permalink / raw)
  To: buildroot

On Fri, Jul 19, 2013 at 3:43 PM, Gustavo Zacarias
<gustavo@zacarias.com.ar> wrote:
> On 07/19/2013 10:32 AM, Thomas De Schampheleire wrote:
>
>> but in the meantime we're several releases further. I don't know if it
>> is still accurate.
>>
>> I think you're right that it's not default-on in dhcpd.conf.
>>
>> What do you say, enable it always at compile time?
>
> Oh yes it's a default, so let's just keep the option.
> (includes/dhcpd.h -> DEFAULT_DELAYED_ACK)

You're right, so we have to keep the option.
Hence, the patch remains as it is.

Thanks for your feedback,
Thomas

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] dhcp: add config option for delayed-ack feature of dhcp server
  2013-07-19 12:46 [Buildroot] [PATCH] dhcp: add config option for delayed-ack feature of dhcp server Thomas De Schampheleire
  2013-07-19 13:15 ` Gustavo Zacarias
@ 2013-07-19 21:40 ` Peter Korsgaard
  1 sibling, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2013-07-19 21:40 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin+buildroot@gmail.com> writes:

 Thomas> This patch creates a config option for the ISC DHCP server to
 Thomas> allow passing --enable-delayed-ack to its configure script.

Committed, thanks.

Are you really building such a big system with Buildroot that the fsyncs
matter?

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-07-19 21:40 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-19 12:46 [Buildroot] [PATCH] dhcp: add config option for delayed-ack feature of dhcp server Thomas De Schampheleire
2013-07-19 13:15 ` Gustavo Zacarias
2013-07-19 13:32   ` Thomas De Schampheleire
2013-07-19 13:43     ` Gustavo Zacarias
2013-07-19 14:52       ` Thomas De Schampheleire
2013-07-19 21:40 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.