[Buildroot] [PATCH 1/1] package/hiredis: fix debug install

[Buildroot] [PATCH 1/1] package/hiredis: fix debug install

[Fabrice Fontaine]

hiredis suffix its debug libraries with "d" since version 1.1.0 and
https://github.com/redis/hiredis/commit/dde6916b42a4723b364355eff8fbb477723a789a
resulting in the following build failure with collectd since commit
bd7e90779861bb603fc1cca03f6fad4d951f7bd9:

    redis . . . . . . . . no (symbol 'redisCommand' not found) (dependency error)

Fixes:
 - http://autobuild.buildroot.org/results/394ebf2b6816c69dbdd7901491c0e3fd52befedc

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/hiredis/hiredis.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/package/hiredis/hiredis.mk b/package/hiredis/hiredis.mk
index a5efb61acc..dbb59f44ba 100644
--- a/package/hiredis/hiredis.mk
+++ b/package/hiredis/hiredis.mk
@@ -11,7 +11,9 @@ HIREDIS_LICENSE = BSD-3-Clause
 HIREDIS_LICENSE_FILES = COPYING
 HIREDIS_CPE_ID_VENDOR = redis
 HIREDIS_INSTALL_STAGING = YES
-HIREDIS_CONF_OPTS = -DDISABLE_TESTS=ON
+# Set CMAKE_BUILD_TYPE to Release or the libraries will be suffixed with "d"
+# resulting in a build failure with collectd
+HIREDIS_CONF_OPTS = -DCMAKE_BUILD_TYPE=Release -DDISABLE_TESTS=ON
 
 ifeq ($(BR2_PACKAGE_OPENSSL)$(BR2_TOOLCHAIN_HAS_THREADS),yy)
 HIREDIS_CONF_OPTS += -DENABLE_SSL=ON
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/hiredis: fix debug install

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > hiredis suffix its debug libraries with "d" since version 1.1.0 and
 > https://github.com/redis/hiredis/commit/dde6916b42a4723b364355eff8fbb477723a789a
 > resulting in the following build failure with collectd since commit
 > bd7e90779861bb603fc1cca03f6fad4d951f7bd9:

 >     redis . . . . . . . . no (symbol 'redisCommand' not found) (dependency error)

 > Fixes:
 >  - http://autobuild.buildroot.org/results/394ebf2b6816c69dbdd7901491c0e3fd52befedc

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
 > ---
 >  package/hiredis/hiredis.mk | 4 +++-
 >  1 file changed, 3 insertions(+), 1 deletion(-)

 > diff --git a/package/hiredis/hiredis.mk b/package/hiredis/hiredis.mk
 > index a5efb61acc..dbb59f44ba 100644
 > --- a/package/hiredis/hiredis.mk
 > +++ b/package/hiredis/hiredis.mk
 > @@ -11,7 +11,9 @@ HIREDIS_LICENSE = BSD-3-Clause
 >  HIREDIS_LICENSE_FILES = COPYING
 >  HIREDIS_CPE_ID_VENDOR = redis

Local change? On master this is set to redislabs

>  HIREDIS_INSTALL_STAGING = YES
 > -HIREDIS_CONF_OPTS = -DDISABLE_TESTS=ON
 > +# Set CMAKE_BUILD_TYPE to Release or the libraries will be suffixed with "d"
 > +# resulting in a build failure with collectd
 > +HIREDIS_CONF_OPTS = -DCMAKE_BUILD_TYPE=Release -DDISABLE_TESTS=ON

Committed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot