[Buildroot] [PATCH 1/1] package/libkrb5: doesn't build with libressl

[Buildroot] [PATCH 1/1] package/libkrb5: doesn't build with libressl

[Fabrice Fontaine]

libkrb5 does not build with libressl since commit
b7a5b9d06d484700fc4fcbd354f2c15e0422688c and upstream is not interested
in fixing this issue as a PR is opened for more than 4 years
(https://github.com/krb5/krb5/pull/607):

pkinit_crypto_openssl.c: In function 'cms_signeddata_verify':
pkinit_crypto_openssl.c:1700:22: error: implicit declaration of function 'OBJ_get0_data'; did you mean 'BIO_get_data'? [-Werror=implicit-function-declaration]
 1700 |         print_buffer(OBJ_get0_data(etype), OBJ_length(etype));
      |                      ^~~~~~~~~~~~~
      |                      BIO_get_data

Fixes:
 - http://autobuild.buildroot.org/results/e623f4e1d6b6004e98815b8b7da3938238890bd8

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/libkrb5/libkrb5.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/libkrb5/libkrb5.mk b/package/libkrb5/libkrb5.mk
index f406cd9e49..bd751d9c77 100644
--- a/package/libkrb5/libkrb5.mk
+++ b/package/libkrb5/libkrb5.mk
@@ -49,7 +49,7 @@ else
 LIBKRB5_CONF_OPTS += --without-ldap
 endif
 
-ifeq ($(BR2_PACKAGE_OPENSSL),y)
+ifeq ($(BR2_PACKAGE_LIBOPENSSL),y)
 LIBKRB5_CONF_OPTS += \
 	--enable-pkinit \
 	--with-crypto-impl=openssl \
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libkrb5: doesn't build with libressl

[Petr Vorel]

Hi Fabrice,

> libkrb5 does not build with libressl since commit
> b7a5b9d06d484700fc4fcbd354f2c15e0422688c and upstream is not interested
> in fixing this issue as a PR is opened for more than 4 years
> (https://github.com/krb5/krb5/pull/607):

Good catch!

Reviewed-by: Petr Vorel <petr.vorel@gmail.com>

Kind regards,
Petr
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libkrb5: doesn't build with libressl

[Arnout Vandecappelle]

On 18/04/2022 13:41, Fabrice Fontaine wrote:
> libkrb5 does not build with libressl since commit
> b7a5b9d06d484700fc4fcbd354f2c15e0422688c and upstream is not interested
> in fixing this issue as a PR is opened for more than 4 years
> (https://github.com/krb5/krb5/pull/607):
> 
> pkinit_crypto_openssl.c: In function 'cms_signeddata_verify':
> pkinit_crypto_openssl.c:1700:22: error: implicit declaration of function 'OBJ_get0_data'; did you mean 'BIO_get_data'? [-Werror=implicit-function-declaration]
>   1700 |         print_buffer(OBJ_get0_data(etype), OBJ_length(etype));
>        |                      ^~~~~~~~~~~~~
>        |                      BIO_get_data
> 
> Fixes:
>   - http://autobuild.buildroot.org/results/e623f4e1d6b6004e98815b8b7da3938238890bd8
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   package/libkrb5/libkrb5.mk | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/libkrb5/libkrb5.mk b/package/libkrb5/libkrb5.mk
> index f406cd9e49..bd751d9c77 100644
> --- a/package/libkrb5/libkrb5.mk
> +++ b/package/libkrb5/libkrb5.mk
> @@ -49,7 +49,7 @@ else
>   LIBKRB5_CONF_OPTS += --without-ldap
>   endif
>   
> -ifeq ($(BR2_PACKAGE_OPENSSL),y)
> +ifeq ($(BR2_PACKAGE_LIBOPENSSL),y)
>   LIBKRB5_CONF_OPTS += \
>   	--enable-pkinit \
>   	--with-crypto-impl=openssl \
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libkrb5: doesn't build with libressl

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > libkrb5 does not build with libressl since commit
 > b7a5b9d06d484700fc4fcbd354f2c15e0422688c and upstream is not interested
 > in fixing this issue as a PR is opened for more than 4 years
 > (https://github.com/krb5/krb5/pull/607):

 > pkinit_crypto_openssl.c: In function 'cms_signeddata_verify':
 > pkinit_crypto_openssl.c:1700:22: error: implicit declaration of
 > function 'OBJ_get0_data'; did you mean 'BIO_get_data'?
 > [-Werror=implicit-function-declaration]
 >  1700 |         print_buffer(OBJ_get0_data(etype), OBJ_length(etype));
 >       |                      ^~~~~~~~~~~~~
 >       |                      BIO_get_data

 > Fixes:
 >  - http://autobuild.buildroot.org/results/e623f4e1d6b6004e98815b8b7da3938238890bd8

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot