* [PATCH] POWERPC: idle: fix return value of __setup handler
@ 2022-03-13 6:58 ` Randy Dunlap
0 siblings, 0 replies; 10+ messages in thread
From: Randy Dunlap @ 2022-03-13 6:58 UTC (permalink / raw)
To: linuxppc-dev
Cc: patches, Randy Dunlap, Arnd Bergmann, Paul Mackerras,
Michael Ellerman, Benjamin Herrenschmidt
__setup() handlers should return 1 to obsolete_checksetup() in
init/main.c to indicate that the boot option has been handled.
A return of 0 causes the boot option/value to be listed as an Unknown
kernel parameter and added to init's (limited) argument or environment
strings. Also, error return codes don't mean anything to
obsolete_checksetup() -- only non-zero (usually 1) or zero.
So return 1 from powersave_off().
Fixes: 302eca184fb8 ("[POWERPC] cell: use ppc_md->power_save instead of cbe_idle_loop")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
From: Igor Zhbanov <i.zhbanov@omprussia.ru>
Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3@omprussia.ru
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
arch/powerpc/kernel/idle.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20220310.orig/arch/powerpc/kernel/idle.c
+++ linux-next-20220310/arch/powerpc/kernel/idle.c
@@ -37,7 +37,7 @@ static int __init powersave_off(char *ar
{
ppc_md.power_save = NULL;
cpuidle_disable = IDLE_POWERSAVE_OFF;
- return 0;
+ return 1;
}
__setup("powersave=off", powersave_off);
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] POWERPC: idle: fix return value of __setup handler
@ 2022-03-13 6:58 ` Randy Dunlap
0 siblings, 0 replies; 10+ messages in thread
From: Randy Dunlap @ 2022-03-13 6:58 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Arnd Bergmann, Randy Dunlap, patches, Paul Mackerras
__setup() handlers should return 1 to obsolete_checksetup() in
init/main.c to indicate that the boot option has been handled.
A return of 0 causes the boot option/value to be listed as an Unknown
kernel parameter and added to init's (limited) argument or environment
strings. Also, error return codes don't mean anything to
obsolete_checksetup() -- only non-zero (usually 1) or zero.
So return 1 from powersave_off().
Fixes: 302eca184fb8 ("[POWERPC] cell: use ppc_md->power_save instead of cbe_idle_loop")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
From: Igor Zhbanov <i.zhbanov@omprussia.ru>
Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3@omprussia.ru
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
arch/powerpc/kernel/idle.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20220310.orig/arch/powerpc/kernel/idle.c
+++ linux-next-20220310/arch/powerpc/kernel/idle.c
@@ -37,7 +37,7 @@ static int __init powersave_off(char *ar
{
ppc_md.power_save = NULL;
cpuidle_disable = IDLE_POWERSAVE_OFF;
- return 0;
+ return 1;
}
__setup("powersave=off", powersave_off);
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] POWERPC: idle: fix return value of __setup handler
2022-03-13 6:58 ` Randy Dunlap
@ 2022-05-02 13:19 ` Michael Ellerman
-1 siblings, 0 replies; 10+ messages in thread
From: Michael Ellerman @ 2022-05-02 13:19 UTC (permalink / raw)
To: Randy Dunlap, linuxppc-dev
Cc: Randy Dunlap, Paul Mackerras, patches, Arnd Bergmann
Randy Dunlap <rdunlap@infradead.org> writes:
> __setup() handlers should return 1 to obsolete_checksetup() in
> init/main.c to indicate that the boot option has been handled.
> A return of 0 causes the boot option/value to be listed as an Unknown
> kernel parameter and added to init's (limited) argument or environment
> strings. Also, error return codes don't mean anything to
> obsolete_checksetup() -- only non-zero (usually 1) or zero.
> So return 1 from powersave_off().
>
> Fixes: 302eca184fb8 ("[POWERPC] cell: use ppc_md->power_save instead of cbe_idle_loop")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> From: Igor Zhbanov <i.zhbanov@omprussia.ru>
What happened here? Is the patch actually from Igor? If so he should be
the author, and it should include his SoB shouldn't it?
Same comment for "[PATCH] powerpc/4xx: cpm: fix return value of __setup handler".
cheers
> Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3@omprussia.ru
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
> arch/powerpc/kernel/idle.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20220310.orig/arch/powerpc/kernel/idle.c
> +++ linux-next-20220310/arch/powerpc/kernel/idle.c
> @@ -37,7 +37,7 @@ static int __init powersave_off(char *ar
> {
> ppc_md.power_save = NULL;
> cpuidle_disable = IDLE_POWERSAVE_OFF;
> - return 0;
> + return 1;
> }
> __setup("powersave=off", powersave_off);
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] POWERPC: idle: fix return value of __setup handler
@ 2022-05-02 13:19 ` Michael Ellerman
0 siblings, 0 replies; 10+ messages in thread
From: Michael Ellerman @ 2022-05-02 13:19 UTC (permalink / raw)
To: Randy Dunlap, linuxppc-dev
Cc: patches, Randy Dunlap, Arnd Bergmann, Paul Mackerras,
Benjamin Herrenschmidt
Randy Dunlap <rdunlap@infradead.org> writes:
> __setup() handlers should return 1 to obsolete_checksetup() in
> init/main.c to indicate that the boot option has been handled.
> A return of 0 causes the boot option/value to be listed as an Unknown
> kernel parameter and added to init's (limited) argument or environment
> strings. Also, error return codes don't mean anything to
> obsolete_checksetup() -- only non-zero (usually 1) or zero.
> So return 1 from powersave_off().
>
> Fixes: 302eca184fb8 ("[POWERPC] cell: use ppc_md->power_save instead of cbe_idle_loop")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> From: Igor Zhbanov <i.zhbanov@omprussia.ru>
What happened here? Is the patch actually from Igor? If so he should be
the author, and it should include his SoB shouldn't it?
Same comment for "[PATCH] powerpc/4xx: cpm: fix return value of __setup handler".
cheers
> Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3@omprussia.ru
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
> arch/powerpc/kernel/idle.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20220310.orig/arch/powerpc/kernel/idle.c
> +++ linux-next-20220310/arch/powerpc/kernel/idle.c
> @@ -37,7 +37,7 @@ static int __init powersave_off(char *ar
> {
> ppc_md.power_save = NULL;
> cpuidle_disable = IDLE_POWERSAVE_OFF;
> - return 0;
> + return 1;
> }
> __setup("powersave=off", powersave_off);
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] POWERPC: idle: fix return value of __setup handler
2022-05-02 13:19 ` Michael Ellerman
@ 2022-05-02 15:50 ` Randy Dunlap
-1 siblings, 0 replies; 10+ messages in thread
From: Randy Dunlap @ 2022-05-02 15:50 UTC (permalink / raw)
To: Michael Ellerman, linuxppc-dev
Cc: patches, Arnd Bergmann, Paul Mackerras, Benjamin Herrenschmidt
On 5/2/22 06:19, Michael Ellerman wrote:
> Randy Dunlap <rdunlap@infradead.org> writes:
>> __setup() handlers should return 1 to obsolete_checksetup() in
>> init/main.c to indicate that the boot option has been handled.
>> A return of 0 causes the boot option/value to be listed as an Unknown
>> kernel parameter and added to init's (limited) argument or environment
>> strings. Also, error return codes don't mean anything to
>> obsolete_checksetup() -- only non-zero (usually 1) or zero.
>> So return 1 from powersave_off().
>>
>> Fixes: 302eca184fb8 ("[POWERPC] cell: use ppc_md->power_save instead of cbe_idle_loop")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> From: Igor Zhbanov <i.zhbanov@omprussia.ru>
>
> What happened here? Is the patch actually from Igor? If so he should be
> the author, and it should include his SoB shouldn't it?
I don't know what happened. I did the patches.
I'll resend them.
Thanks.
> Same comment for "[PATCH] powerpc/4xx: cpm: fix return value of __setup handler".
>
> cheers
>
>> Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3@omprussia.ru
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> Cc: Paul Mackerras <paulus@samba.org>
>> Cc: Michael Ellerman <mpe@ellerman.id.au>
>> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>> ---
>> arch/powerpc/kernel/idle.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- linux-next-20220310.orig/arch/powerpc/kernel/idle.c
>> +++ linux-next-20220310/arch/powerpc/kernel/idle.c
>> @@ -37,7 +37,7 @@ static int __init powersave_off(char *ar
>> {
>> ppc_md.power_save = NULL;
>> cpuidle_disable = IDLE_POWERSAVE_OFF;
>> - return 0;
>> + return 1;
>> }
>> __setup("powersave=off", powersave_off);
>>
--
~Randy
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] POWERPC: idle: fix return value of __setup handler
@ 2022-05-02 15:50 ` Randy Dunlap
0 siblings, 0 replies; 10+ messages in thread
From: Randy Dunlap @ 2022-05-02 15:50 UTC (permalink / raw)
To: Michael Ellerman, linuxppc-dev; +Cc: Paul Mackerras, patches, Arnd Bergmann
On 5/2/22 06:19, Michael Ellerman wrote:
> Randy Dunlap <rdunlap@infradead.org> writes:
>> __setup() handlers should return 1 to obsolete_checksetup() in
>> init/main.c to indicate that the boot option has been handled.
>> A return of 0 causes the boot option/value to be listed as an Unknown
>> kernel parameter and added to init's (limited) argument or environment
>> strings. Also, error return codes don't mean anything to
>> obsolete_checksetup() -- only non-zero (usually 1) or zero.
>> So return 1 from powersave_off().
>>
>> Fixes: 302eca184fb8 ("[POWERPC] cell: use ppc_md->power_save instead of cbe_idle_loop")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> From: Igor Zhbanov <i.zhbanov@omprussia.ru>
>
> What happened here? Is the patch actually from Igor? If so he should be
> the author, and it should include his SoB shouldn't it?
I don't know what happened. I did the patches.
I'll resend them.
Thanks.
> Same comment for "[PATCH] powerpc/4xx: cpm: fix return value of __setup handler".
>
> cheers
>
>> Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3@omprussia.ru
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> Cc: Paul Mackerras <paulus@samba.org>
>> Cc: Michael Ellerman <mpe@ellerman.id.au>
>> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>> ---
>> arch/powerpc/kernel/idle.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- linux-next-20220310.orig/arch/powerpc/kernel/idle.c
>> +++ linux-next-20220310/arch/powerpc/kernel/idle.c
>> @@ -37,7 +37,7 @@ static int __init powersave_off(char *ar
>> {
>> ppc_md.power_save = NULL;
>> cpuidle_disable = IDLE_POWERSAVE_OFF;
>> - return 0;
>> + return 1;
>> }
>> __setup("powersave=off", powersave_off);
>>
--
~Randy
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] POWERPC: idle: fix return value of __setup handler
2022-05-02 15:50 ` Randy Dunlap
(?)
@ 2022-05-02 18:45 ` Christophe Leroy
2022-05-02 19:17 ` Randy Dunlap
-1 siblings, 1 reply; 10+ messages in thread
From: Christophe Leroy @ 2022-05-02 18:45 UTC (permalink / raw)
To: Randy Dunlap, Michael Ellerman, linuxppc-dev
Cc: Paul Mackerras, patches, Arnd Bergmann
Le 02/05/2022 à 17:50, Randy Dunlap a écrit :
>
>
> On 5/2/22 06:19, Michael Ellerman wrote:
>> Randy Dunlap <rdunlap@infradead.org> writes:
>>> __setup() handlers should return 1 to obsolete_checksetup() in
>>> init/main.c to indicate that the boot option has been handled.
>>> A return of 0 causes the boot option/value to be listed as an Unknown
>>> kernel parameter and added to init's (limited) argument or environment
>>> strings. Also, error return codes don't mean anything to
>>> obsolete_checksetup() -- only non-zero (usually 1) or zero.
>>> So return 1 from powersave_off().
>>>
>>> Fixes: 302eca184fb8 ("[POWERPC] cell: use ppc_md->power_save instead of cbe_idle_loop")
>>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>>> From: Igor Zhbanov <i.zhbanov@omprussia.ru>
>>
>> What happened here? Is the patch actually from Igor? If so he should be
>> the author, and it should include his SoB shouldn't it?
>
> I don't know what happened. I did the patches.
> I'll resend them.
>
Some erroneous copy/paste from
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20220308024228.20477-1-rdunlap@infradead.org/
?
> Thanks.
>
>> Same comment for "[PATCH] powerpc/4xx: cpm: fix return value of __setup handler".
>>
>> cheers
>>
>>> Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3@omprussia.ru
>>> Cc: Arnd Bergmann <arnd@arndb.de>
>>> Cc: Paul Mackerras <paulus@samba.org>
>>> Cc: Michael Ellerman <mpe@ellerman.id.au>
>>> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>>> ---
>>> arch/powerpc/kernel/idle.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> --- linux-next-20220310.orig/arch/powerpc/kernel/idle.c
>>> +++ linux-next-20220310/arch/powerpc/kernel/idle.c
>>> @@ -37,7 +37,7 @@ static int __init powersave_off(char *ar
>>> {
>>> ppc_md.power_save = NULL;
>>> cpuidle_disable = IDLE_POWERSAVE_OFF;
>>> - return 0;
>>> + return 1;
>>> }
>>> __setup("powersave=off", powersave_off);
>>>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] POWERPC: idle: fix return value of __setup handler
2022-05-02 18:45 ` Christophe Leroy
@ 2022-05-02 19:17 ` Randy Dunlap
0 siblings, 0 replies; 10+ messages in thread
From: Randy Dunlap @ 2022-05-02 19:17 UTC (permalink / raw)
To: Christophe Leroy, Michael Ellerman, linuxppc-dev
Cc: Paul Mackerras, patches, Arnd Bergmann
On 5/2/22 11:45, Christophe Leroy wrote:
>
>
> Le 02/05/2022 à 17:50, Randy Dunlap a écrit :
>>
>>
>> On 5/2/22 06:19, Michael Ellerman wrote:
>>> Randy Dunlap <rdunlap@infradead.org> writes:
>>>> __setup() handlers should return 1 to obsolete_checksetup() in
>>>> init/main.c to indicate that the boot option has been handled.
>>>> A return of 0 causes the boot option/value to be listed as an Unknown
>>>> kernel parameter and added to init's (limited) argument or environment
>>>> strings. Also, error return codes don't mean anything to
>>>> obsolete_checksetup() -- only non-zero (usually 1) or zero.
>>>> So return 1 from powersave_off().
>>>>
>>>> Fixes: 302eca184fb8 ("[POWERPC] cell: use ppc_md->power_save instead of cbe_idle_loop")
>>>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>>>> From: Igor Zhbanov <i.zhbanov@omprussia.ru>
>>>
>>> What happened here? Is the patch actually from Igor? If so he should be
>>> the author, and it should include his SoB shouldn't it?
>>
>> I don't know what happened. I did the patches.
>> I'll resend them.
>>
>
> Some erroneous copy/paste from
> https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20220308024228.20477-1-rdunlap@infradead.org/
> ?
Yes, it should have been Reported-by:
>
>> Thanks.
>>
>>> Same comment for "[PATCH] powerpc/4xx: cpm: fix return value of __setup handler".
>>>
>>> cheers
>>>
>>>> Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3@omprussia.ru
>>>> Cc: Arnd Bergmann <arnd@arndb.de>
>>>> Cc: Paul Mackerras <paulus@samba.org>
>>>> Cc: Michael Ellerman <mpe@ellerman.id.au>
>>>> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>>>> ---
>>>> arch/powerpc/kernel/idle.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> --- linux-next-20220310.orig/arch/powerpc/kernel/idle.c
>>>> +++ linux-next-20220310/arch/powerpc/kernel/idle.c
>>>> @@ -37,7 +37,7 @@ static int __init powersave_off(char *ar
>>>> {
>>>> ppc_md.power_save = NULL;
>>>> cpuidle_disable = IDLE_POWERSAVE_OFF;
>>>> - return 0;
>>>> + return 1;
>>>> }
>>>> __setup("powersave=off", powersave_off);
>>>>
--
~Randy
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] POWERPC: idle: fix return value of __setup handler
2022-05-02 15:50 ` Randy Dunlap
@ 2022-05-03 0:55 ` Michael Ellerman
-1 siblings, 0 replies; 10+ messages in thread
From: Michael Ellerman @ 2022-05-03 0:55 UTC (permalink / raw)
To: Randy Dunlap, linuxppc-dev
Cc: patches, Arnd Bergmann, Paul Mackerras, Benjamin Herrenschmidt
Randy Dunlap <rdunlap@infradead.org> writes:
> On 5/2/22 06:19, Michael Ellerman wrote:
>> Randy Dunlap <rdunlap@infradead.org> writes:
>>> __setup() handlers should return 1 to obsolete_checksetup() in
>>> init/main.c to indicate that the boot option has been handled.
>>> A return of 0 causes the boot option/value to be listed as an Unknown
>>> kernel parameter and added to init's (limited) argument or environment
>>> strings. Also, error return codes don't mean anything to
>>> obsolete_checksetup() -- only non-zero (usually 1) or zero.
>>> So return 1 from powersave_off().
>>>
>>> Fixes: 302eca184fb8 ("[POWERPC] cell: use ppc_md->power_save instead of cbe_idle_loop")
>>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>>> From: Igor Zhbanov <i.zhbanov@omprussia.ru>
>>
>> What happened here? Is the patch actually from Igor? If so he should be
>> the author, and it should include his SoB shouldn't it?
>
> I don't know what happened. I did the patches.
> I'll resend them.
Thanks.
cheers
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] POWERPC: idle: fix return value of __setup handler
@ 2022-05-03 0:55 ` Michael Ellerman
0 siblings, 0 replies; 10+ messages in thread
From: Michael Ellerman @ 2022-05-03 0:55 UTC (permalink / raw)
To: Randy Dunlap, linuxppc-dev; +Cc: Paul Mackerras, patches, Arnd Bergmann
Randy Dunlap <rdunlap@infradead.org> writes:
> On 5/2/22 06:19, Michael Ellerman wrote:
>> Randy Dunlap <rdunlap@infradead.org> writes:
>>> __setup() handlers should return 1 to obsolete_checksetup() in
>>> init/main.c to indicate that the boot option has been handled.
>>> A return of 0 causes the boot option/value to be listed as an Unknown
>>> kernel parameter and added to init's (limited) argument or environment
>>> strings. Also, error return codes don't mean anything to
>>> obsolete_checksetup() -- only non-zero (usually 1) or zero.
>>> So return 1 from powersave_off().
>>>
>>> Fixes: 302eca184fb8 ("[POWERPC] cell: use ppc_md->power_save instead of cbe_idle_loop")
>>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>>> From: Igor Zhbanov <i.zhbanov@omprussia.ru>
>>
>> What happened here? Is the patch actually from Igor? If so he should be
>> the author, and it should include his SoB shouldn't it?
>
> I don't know what happened. I did the patches.
> I'll resend them.
Thanks.
cheers
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2022-05-03 0:55 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-13 6:58 [PATCH] POWERPC: idle: fix return value of __setup handler Randy Dunlap
2022-03-13 6:58 ` Randy Dunlap
2022-05-02 13:19 ` Michael Ellerman
2022-05-02 13:19 ` Michael Ellerman
2022-05-02 15:50 ` Randy Dunlap
2022-05-02 15:50 ` Randy Dunlap
2022-05-02 18:45 ` Christophe Leroy
2022-05-02 19:17 ` Randy Dunlap
2022-05-03 0:55 ` Michael Ellerman
2022-05-03 0:55 ` Michael Ellerman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.