From: Jani Nikula <jani.nikula@linux.intel.com> To: Kuogee Hsieh <khsieh@codeaurora.org>, robdclark@gmail.com, sean@poorly.run, swboyd@chromium.org, lyude@redhat.com Cc: abhinavk@codeaurora.org, aravindh@codeaurora.org, khsieh@codeaurora.org, rsubbia@codeaurora.org, rnayak@codeaurora.org, freedreno@lists.freedesktop.org, airlied@linux.ie, daniel@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] drm/dp_mst: Fix return code on sideband message failure Date: Wed, 07 Jul 2021 11:37:21 +0300 [thread overview] Message-ID: <87zguy7c5a.fsf@intel.com> (raw) In-Reply-To: <1625585434-9562-1-git-send-email-khsieh@codeaurora.org> On Tue, 06 Jul 2021, Kuogee Hsieh <khsieh@codeaurora.org> wrote: > From: Rajkumar Subbiah <rsubbia@codeaurora.org> > > Commit 2f015ec6eab6 ("drm/dp_mst: Add sideband down request tracing + > selftests") added some debug code for sideband message tracing. But > it seems to have unintentionally changed the behavior on sideband message > failure. It catches and returns failure only if DRM_UT_DP is enabled. > Otherwise it ignores the error code and returns success. So on an MST > unplug, the caller is unaware that the clear payload message failed and > ends up waiting for 4 seconds for the response. Fixes the issue by > returning the proper error code. > > Changes in V2: > -- Revise commit text as review comment > -- add Fixes text > > Changes in V3: > -- remove "unlikely" optimization > > Fixes: 2f015ec6eab6 ("drm/dp_mst: Add sideband down request tracing + selftests") > > Signed-off-by: Rajkumar Subbiah <rsubbia@codeaurora.org> > Signed-off-by: Kuogee Hsieh <khsieh@codeaurora.org> > > Reviewed-by: Stephen Boyd <swboyd@chromium.org> Reviewed-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/gpu/drm/drm_dp_mst_topology.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c > index 1590144..df91110 100644 > --- a/drivers/gpu/drm/drm_dp_mst_topology.c > +++ b/drivers/gpu/drm/drm_dp_mst_topology.c > @@ -2887,11 +2887,13 @@ static int process_single_tx_qlock(struct drm_dp_mst_topology_mgr *mgr, > idx += tosend + 1; > > ret = drm_dp_send_sideband_msg(mgr, up, chunk, idx); > - if (unlikely(ret) && drm_debug_enabled(DRM_UT_DP)) { > - struct drm_printer p = drm_debug_printer(DBG_PREFIX); > + if (ret) { > + if (drm_debug_enabled(DRM_UT_DP)) { > + struct drm_printer p = drm_debug_printer(DBG_PREFIX); > > - drm_printf(&p, "sideband msg failed to send\n"); > - drm_dp_mst_dump_sideband_msg_tx(&p, txmsg); > + drm_printf(&p, "sideband msg failed to send\n"); > + drm_dp_mst_dump_sideband_msg_tx(&p, txmsg); > + } > return ret; > } -- Jani Nikula, Intel Open Source Graphics Center
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com> To: Kuogee Hsieh <khsieh@codeaurora.org>, robdclark@gmail.com, sean@poorly.run, swboyd@chromium.org, lyude@redhat.com Cc: rnayak@codeaurora.org, tzimmermann@suse.de, airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, abhinavk@codeaurora.org, khsieh@codeaurora.org, aravindh@codeaurora.org, freedreno@lists.freedesktop.org, rsubbia@codeaurora.org Subject: Re: [PATCH v3] drm/dp_mst: Fix return code on sideband message failure Date: Wed, 07 Jul 2021 11:37:21 +0300 [thread overview] Message-ID: <87zguy7c5a.fsf@intel.com> (raw) In-Reply-To: <1625585434-9562-1-git-send-email-khsieh@codeaurora.org> On Tue, 06 Jul 2021, Kuogee Hsieh <khsieh@codeaurora.org> wrote: > From: Rajkumar Subbiah <rsubbia@codeaurora.org> > > Commit 2f015ec6eab6 ("drm/dp_mst: Add sideband down request tracing + > selftests") added some debug code for sideband message tracing. But > it seems to have unintentionally changed the behavior on sideband message > failure. It catches and returns failure only if DRM_UT_DP is enabled. > Otherwise it ignores the error code and returns success. So on an MST > unplug, the caller is unaware that the clear payload message failed and > ends up waiting for 4 seconds for the response. Fixes the issue by > returning the proper error code. > > Changes in V2: > -- Revise commit text as review comment > -- add Fixes text > > Changes in V3: > -- remove "unlikely" optimization > > Fixes: 2f015ec6eab6 ("drm/dp_mst: Add sideband down request tracing + selftests") > > Signed-off-by: Rajkumar Subbiah <rsubbia@codeaurora.org> > Signed-off-by: Kuogee Hsieh <khsieh@codeaurora.org> > > Reviewed-by: Stephen Boyd <swboyd@chromium.org> Reviewed-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/gpu/drm/drm_dp_mst_topology.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c > index 1590144..df91110 100644 > --- a/drivers/gpu/drm/drm_dp_mst_topology.c > +++ b/drivers/gpu/drm/drm_dp_mst_topology.c > @@ -2887,11 +2887,13 @@ static int process_single_tx_qlock(struct drm_dp_mst_topology_mgr *mgr, > idx += tosend + 1; > > ret = drm_dp_send_sideband_msg(mgr, up, chunk, idx); > - if (unlikely(ret) && drm_debug_enabled(DRM_UT_DP)) { > - struct drm_printer p = drm_debug_printer(DBG_PREFIX); > + if (ret) { > + if (drm_debug_enabled(DRM_UT_DP)) { > + struct drm_printer p = drm_debug_printer(DBG_PREFIX); > > - drm_printf(&p, "sideband msg failed to send\n"); > - drm_dp_mst_dump_sideband_msg_tx(&p, txmsg); > + drm_printf(&p, "sideband msg failed to send\n"); > + drm_dp_mst_dump_sideband_msg_tx(&p, txmsg); > + } > return ret; > } -- Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2021-07-07 8:37 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-06 15:30 [PATCH v3] drm/dp_mst: Fix return code on sideband message failure Kuogee Hsieh 2021-07-06 15:30 ` Kuogee Hsieh 2021-07-07 8:37 ` Jani Nikula [this message] 2021-07-07 8:37 ` Jani Nikula 2021-07-13 22:24 ` khsieh 2021-07-13 22:24 ` khsieh 2021-07-22 17:53 ` Lyude Paul 2021-07-22 17:53 ` Lyude Paul 2021-07-22 22:28 ` khsieh 2021-07-22 22:28 ` khsieh 2021-07-27 19:21 ` Lyude Paul 2021-07-27 19:21 ` Lyude Paul 2021-07-27 22:41 ` khsieh 2021-07-27 22:41 ` khsieh 2021-07-27 22:44 ` Lyude Paul 2021-07-27 22:44 ` Lyude Paul 2021-08-25 16:06 ` khsieh 2021-08-25 16:26 ` Lyude Paul 2021-08-25 16:26 ` Lyude Paul 2021-08-30 15:56 ` khsieh 2021-08-30 16:58 ` Lyude Paul 2021-08-30 16:58 ` Lyude Paul 2021-08-30 22:57 ` Stephen Boyd 2021-08-30 22:57 ` Stephen Boyd 2021-09-07 20:47 ` khsieh
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87zguy7c5a.fsf@intel.com \ --to=jani.nikula@linux.intel.com \ --cc=abhinavk@codeaurora.org \ --cc=airlied@linux.ie \ --cc=aravindh@codeaurora.org \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=khsieh@codeaurora.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lyude@redhat.com \ --cc=maarten.lankhorst@linux.intel.com \ --cc=mripard@kernel.org \ --cc=rnayak@codeaurora.org \ --cc=robdclark@gmail.com \ --cc=rsubbia@codeaurora.org \ --cc=sean@poorly.run \ --cc=swboyd@chromium.org \ --cc=tzimmermann@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.