All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: kernel test robot <lkp@intel.com>
Cc: "Thierry Reding" <thierry.reding@gmail.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Lee Jones" <lee.jones@linaro.org>,
	kbuild-all@lists.01.org, "Andy Gross" <agross@kernel.org>,
	"Bjorn Andersson" <bjorn.andersson@linaro.org>,
	"Balaji Prakash J" <bjagadee@codeaurora.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Robert Marko" <robert.marko@sartura.hr>,
	linux-pwm@vger.kernel.org,
	"Geert Uytterhoeven" <geert@linux-m68k.org>
Subject: Re: [PATCH v3 1/3] pwm: driver for qualcomm ipq6018 pwm block
Date: Tue, 22 Jun 2021 20:25:58 +0300	[thread overview]
Message-ID: <87zgvh95g9.fsf@tarshish> (raw)
In-Reply-To: <202106222154.DXCnEs3v-lkp@intel.com>

Hi lkp,

Thanks for the report.

Adding m68k maintainer to Cc.

On Tue, Jun 22 2021, kernel test robot wrote:
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on pwm/for-next]
> [also build test ERROR on robh/for-next v5.13-rc7 next-20210621]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url:    https://github.com/0day-ci/linux/commits/Baruch-Siach/pwm-driver-for-qualcomm-ipq6018-pwm-block/20210622-155719
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/thierry.reding/linux-pwm.git for-next
> config: m68k-allmodconfig (attached as .config)
> compiler: m68k-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://github.com/0day-ci/linux/commit/9fe01901cd004c6d48de541eb67dd006243c9220
>         git remote add linux-review https://github.com/0day-ci/linux
>         git fetch --no-tags linux-review Baruch-Siach/pwm-driver-for-qualcomm-ipq6018-pwm-block/20210622-155719
>         git checkout 9fe01901cd004c6d48de541eb67dd006243c9220
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k 
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>, old ones prefixed by <<):
>
>>> ERROR: modpost: "__divdi3" [drivers/pwm/pwm-ipq.ko] undefined!
>>> ERROR: modpost: "__udivdi3" [drivers/pwm/pwm-ipq.ko] undefined!

That is most likely related to the div64_u64() call. The sh arch also
showed a similar issue on v2:

  https://lore.kernel.org/linux-pwm/202105250028.jIIxG5w6-lkp@intel.com/

What is the right fix here? Isn't div64_u64() universally available? I
see quite a few calls under driver/pwm/. Should the driver depend on
some per-arch Kconfig symbol?

Thanks,
baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

WARNING: multiple messages have this Message-ID (diff)
From: Baruch Siach <baruch@tkos.co.il>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v3 1/3] pwm: driver for qualcomm ipq6018 pwm block
Date: Tue, 22 Jun 2021 20:25:58 +0300	[thread overview]
Message-ID: <87zgvh95g9.fsf@tarshish> (raw)
In-Reply-To: <202106222154.DXCnEs3v-lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 2398 bytes --]

Hi lkp,

Thanks for the report.

Adding m68k maintainer to Cc.

On Tue, Jun 22 2021, kernel test robot wrote:
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on pwm/for-next]
> [also build test ERROR on robh/for-next v5.13-rc7 next-20210621]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url:    https://github.com/0day-ci/linux/commits/Baruch-Siach/pwm-driver-for-qualcomm-ipq6018-pwm-block/20210622-155719
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/thierry.reding/linux-pwm.git for-next
> config: m68k-allmodconfig (attached as .config)
> compiler: m68k-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://github.com/0day-ci/linux/commit/9fe01901cd004c6d48de541eb67dd006243c9220
>         git remote add linux-review https://github.com/0day-ci/linux
>         git fetch --no-tags linux-review Baruch-Siach/pwm-driver-for-qualcomm-ipq6018-pwm-block/20210622-155719
>         git checkout 9fe01901cd004c6d48de541eb67dd006243c9220
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k 
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>, old ones prefixed by <<):
>
>>> ERROR: modpost: "__divdi3" [drivers/pwm/pwm-ipq.ko] undefined!
>>> ERROR: modpost: "__udivdi3" [drivers/pwm/pwm-ipq.ko] undefined!

That is most likely related to the div64_u64() call. The sh arch also
showed a similar issue on v2:

  https://lore.kernel.org/linux-pwm/202105250028.jIIxG5w6-lkp(a)intel.com/

What is the right fix here? Isn't div64_u64() universally available? I
see quite a few calls under driver/pwm/. Should the driver depend on
some per-arch Kconfig symbol?

Thanks,
baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch(a)tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

  reply	other threads:[~2021-06-22 17:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-22  7:55 [PATCH v3 1/3] pwm: driver for qualcomm ipq6018 pwm block Baruch Siach
2021-06-22  7:55 ` Baruch Siach
2021-06-22  7:55 ` [PATCH v3 2/3] dt-bindings: pwm: add IPQ6018 binding Baruch Siach
2021-06-22  7:55   ` Baruch Siach
2021-06-22 14:36   ` Rob Herring
2021-06-22 14:36     ` Rob Herring
2021-06-22  7:55 ` [PATCH v3 3/3] arm64: dts: ipq6018: add pwm node Baruch Siach
2021-06-22  7:55   ` Baruch Siach
2021-06-22 14:05 ` [PATCH v3 1/3] pwm: driver for qualcomm ipq6018 pwm block kernel test robot
2021-06-22 14:05   ` kernel test robot
2021-06-22 17:25   ` Baruch Siach [this message]
2021-06-22 17:25     ` Baruch Siach
2021-06-25  9:23     ` Uwe Kleine-König
2021-06-25  9:23       ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zgvh95g9.fsf@tarshish \
    --to=baruch@tkos.co.il \
    --cc=agross@kernel.org \
    --cc=bjagadee@codeaurora.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=geert@linux-m68k.org \
    --cc=kbuild-all@lists.01.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=robert.marko@sartura.hr \
    --cc=robh+dt@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.