All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luis Henriques <lhenriques@suse.de>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: virtio-fs@redhat.com, miklos@szeredi.hu, qemu-devel@nongnu.org,
	stefanha@redhat.com, dgilbert@redhat.com
Subject: Re: [PATCH 0/3] virtiofsd: Add options to enable/disable posix acl
Date: Wed, 17 Feb 2021 09:32:53 +0000	[thread overview]
Message-ID: <87zh03hwe2.fsf@suse.de> (raw)
In-Reply-To: <20210216233611.33400-1-vgoyal@redhat.com> (Vivek Goyal's message of "Tue, 16 Feb 2021 18:36:08 -0500")

Vivek Goyal <vgoyal@redhat.com> writes:

> Luis Henriques reported that fstest generic/099 fails with virtiofs.
> Little debugging showed that we don't enable acl support. So this
> patch series provides option to enable/disable posix acl support. By
> default it is disabled.
>
> I have run blogbench and pjdfstests with posix acl enabled and
> things work fine. 
>
> Luis, can you please apply these patches, and run virtiofsd with
> "-o posix_acl" and see if it fixes the failure you are seeing. I
> ran the steps you provided manually and it fixes the issue for
> me.

Awesome, thanks for looking into this.  I'll have a look and test these
patches.  I expect to be able to report back later today.

Cheers,
-- 
Luis


>
> Vivek Goyal (3):
>   virtiofsd: Add an option to enable/disable posix acls
>   virtiofsd: Add umask to seccom allow list
>   virtiofsd: Change umask if posix acls are enabled
>
>  tools/virtiofsd/passthrough_ll.c      | 45 +++++++++++++++++++++++----
>  tools/virtiofsd/passthrough_seccomp.c |  1 +
>  2 files changed, 40 insertions(+), 6 deletions(-)
>
> -- 
> 2.25.4
>


WARNING: multiple messages have this Message-ID (diff)
From: Luis Henriques <lhenriques@suse.de>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: virtio-fs@redhat.com, miklos@szeredi.hu, qemu-devel@nongnu.org
Subject: Re: [Virtio-fs] [PATCH 0/3] virtiofsd: Add options to enable/disable posix acl
Date: Wed, 17 Feb 2021 09:32:53 +0000	[thread overview]
Message-ID: <87zh03hwe2.fsf@suse.de> (raw)
In-Reply-To: <20210216233611.33400-1-vgoyal@redhat.com> (Vivek Goyal's message of "Tue, 16 Feb 2021 18:36:08 -0500")

Vivek Goyal <vgoyal@redhat.com> writes:

> Luis Henriques reported that fstest generic/099 fails with virtiofs.
> Little debugging showed that we don't enable acl support. So this
> patch series provides option to enable/disable posix acl support. By
> default it is disabled.
>
> I have run blogbench and pjdfstests with posix acl enabled and
> things work fine. 
>
> Luis, can you please apply these patches, and run virtiofsd with
> "-o posix_acl" and see if it fixes the failure you are seeing. I
> ran the steps you provided manually and it fixes the issue for
> me.

Awesome, thanks for looking into this.  I'll have a look and test these
patches.  I expect to be able to report back later today.

Cheers,
-- 
Luis


>
> Vivek Goyal (3):
>   virtiofsd: Add an option to enable/disable posix acls
>   virtiofsd: Add umask to seccom allow list
>   virtiofsd: Change umask if posix acls are enabled
>
>  tools/virtiofsd/passthrough_ll.c      | 45 +++++++++++++++++++++++----
>  tools/virtiofsd/passthrough_seccomp.c |  1 +
>  2 files changed, 40 insertions(+), 6 deletions(-)
>
> -- 
> 2.25.4
>


  parent reply	other threads:[~2021-02-17 13:32 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-16 23:36 [PATCH 0/3] virtiofsd: Add options to enable/disable posix acl Vivek Goyal
2021-02-16 23:36 ` [Virtio-fs] " Vivek Goyal
2021-02-16 23:36 ` [PATCH 1/3] virtiofsd: Add an option to enable/disable posix acls Vivek Goyal
2021-02-16 23:36   ` [Virtio-fs] " Vivek Goyal
2021-02-17  8:53   ` Miklos Szeredi
2021-02-17  8:53     ` [Virtio-fs] " Miklos Szeredi
2021-02-17 15:07     ` Vivek Goyal
2021-02-17 15:07       ` [Virtio-fs] " Vivek Goyal
2021-02-17 15:23       ` Miklos Szeredi
2021-02-17 15:23         ` [Virtio-fs] " Miklos Szeredi
2021-02-16 23:36 ` [PATCH 2/3] virtiofsd: Add umask to seccom allow list Vivek Goyal
2021-02-16 23:36   ` [Virtio-fs] " Vivek Goyal
2021-02-16 23:36 ` [PATCH 3/3] virtiofsd: Change umask if posix acls are enabled Vivek Goyal
2021-02-16 23:36   ` [Virtio-fs] " Vivek Goyal
2021-02-16 23:45 ` [PATCH 0/3] virtiofsd: Add options to enable/disable posix acl no-reply
2021-02-16 23:45   ` [Virtio-fs] " no-reply
2021-02-17  9:32 ` Luis Henriques [this message]
2021-02-17  9:32   ` Luis Henriques

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zh03hwe2.fsf@suse.de \
    --to=lhenriques@suse.de \
    --cc=dgilbert@redhat.com \
    --cc=miklos@szeredi.hu \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=vgoyal@redhat.com \
    --cc=virtio-fs@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.