All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kurt Kanzenbach <kurt@linutronix.de>
To: David Miller <davem@davemloft.net>, richardcochran@gmail.com
Cc: andrew@lunn.ch, olteanv@gmail.com, vivien.didelot@gmail.com,
	f.fainelli@gmail.com, kuba@kernel.org, netdev@vger.kernel.org,
	robh+dt@kernel.org, devicetree@vger.kernel.org,
	bigeasy@linutronix.de, kamil.alkhouri@hs-offenburg.de,
	ilias.apalodimas@linaro.org
Subject: Re: [PATCH v4 2/7] net: dsa: Add DSA driver for Hirschmann Hellcreek switches
Date: Wed, 02 Sep 2020 07:59:12 +0200	[thread overview]
Message-ID: <87zh68afdb.fsf@kurt> (raw)
In-Reply-To: <20200901.115338.1041117882209940166.davem@davemloft.net>

[-- Attachment #1: Type: text/plain, Size: 982 bytes --]

On Tue Sep 01 2020, David Miller wrote:
> From: Richard Cochran <richardcochran@gmail.com>
> Date: Tue, 1 Sep 2020 09:36:10 -0700
>
>> On Tue, Sep 01, 2020 at 05:59:45PM +0200, Andrew Lunn wrote:
>>> Maybe, at the moment, RTNL is keeping things atomic. But that is
>>> because there is no HWMON, or MDIO bus. Those sort of operations don't
>>> take the RTNL, and so would be an issue. I've also never audited the
>>> network stack to check RTNL really is held at all the network stack
>>> entry points to a DSA driver. It would be an interesting excesses to
>>> scatter some ASSERT_RTNL() in a DSA driver and see what happens.
>> 
>> Device drivers really aught to protect their state and their devices'
>> state from concurrent access.
>
> Completely agreed.

OK. So I'll keep the locking as is.

Since I have to have to prepare another version due to the compiler
warnings, I'll wait a bit for more comments and send the next version
after.

Thanks,
Kurt

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2020-09-02  5:59 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-01 12:50 [PATCH v4 0/7] Hirschmann Hellcreek DSA driver Kurt Kanzenbach
2020-09-01 12:50 ` [PATCH v4 1/7] net: dsa: Add tag handling for Hirschmann Hellcreek switches Kurt Kanzenbach
2020-09-01 12:50 ` [PATCH v4 2/7] net: dsa: Add DSA driver " Kurt Kanzenbach
2020-09-01 13:40   ` Vladimir Oltean
2020-09-01 14:05     ` Kurt Kanzenbach
2020-09-01 14:22       ` Vladimir Oltean
2020-09-01 15:59         ` Andrew Lunn
2020-09-01 16:36           ` Richard Cochran
2020-09-01 18:53             ` David Miller
2020-09-02  5:59               ` Kurt Kanzenbach [this message]
2020-09-01 15:11   ` kernel test robot
2020-09-01 15:11     ` kernel test robot
2020-09-01 12:50 ` [PATCH v4 3/7] net: dsa: hellcreek: Add PTP clock support Kurt Kanzenbach
2020-09-01 12:50 ` [PATCH v4 4/7] net: dsa: hellcreek: Add support for hardware timestamping Kurt Kanzenbach
2020-09-01 12:50 ` [PATCH v4 5/7] net: dsa: hellcreek: Add PTP status LEDs Kurt Kanzenbach
2020-09-03 16:32   ` Florian Fainelli
2020-09-01 12:50 ` [PATCH v4 6/7] dt-bindings: Add vendor prefix for Hirschmann Kurt Kanzenbach
2020-09-01 12:50 ` [PATCH v4 7/7] dt-bindings: net: dsa: Add documentation for Hellcreek switches Kurt Kanzenbach
2020-09-03 16:27   ` Rob Herring
2020-09-03 16:29   ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zh68afdb.fsf@kurt \
    --to=kurt@linutronix.de \
    --cc=andrew@lunn.ch \
    --cc=bigeasy@linutronix.de \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=kamil.alkhouri@hs-offenburg.de \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=richardcochran@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.