[Buildroot] [PATCH] Revert "package/dialog: bump version to 1.3-20190808"

[Buildroot] [PATCH] Revert "package/dialog: bump version to 1.3-20190808"

[Paul Cercueil]

The 1.3-20190808 version looks extremely buggy.
For instance, if you try to open a dialog using this command:
dialog --no-shadow --msgbox "test test test" 10 32

- the --no-shadow attribute doesn't seem to work anymore, since the
  frame will sill have a shadow,
- the text shown within the frame won't be "test test test" as expected,
  but "testtesttest".

These bugs make the program completely unusable, so revert to the last
known good version.

This partly reverts commit 6a2ebcaf6a.

The license hash and URL update from ftp to https were not modified
back.

Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
 package/dialog/dialog.hash | 1 +
 package/dialog/dialog.mk   | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/dialog/dialog.hash b/package/dialog/dialog.hash
index 98e2229ce8..5200e5cf86 100644
--- a/package/dialog/dialog.hash
+++ b/package/dialog/dialog.hash
@@ -1,4 +1,5 @@
 # Locally calculated after checking pgp signature
 sha256 886e12f2cf3df36cde65f32f6ae52bc598eb2599a611b1d8ce5dfdea599e47e2  dialog-1.3-20190808.tgz
+sha256 2ff1ba74c632b9d13a0d0d2c942295dd4e8909694eeeded7908a467d0bcd4756  dialog-1.3-20170509.tgz
 # Locally computed
 sha256 6095e9ffa777dd22839f7801aa845b31c9ed07f3d6bf8a26dc5d2dec8ccc0ef3  COPYING
diff --git a/package/dialog/dialog.mk b/package/dialog/dialog.mk
index ae3d2d466a..0f22f033cf 100644
--- a/package/dialog/dialog.mk
+++ b/package/dialog/dialog.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-DIALOG_VERSION = 1.3-20190808
+DIALOG_VERSION = 1.3-20170509
 DIALOG_SOURCE = dialog-$(DIALOG_VERSION).tgz
 DIALOG_SITE = https://invisible-mirror.net/archives/dialog
 DIALOG_CONF_OPTS = --with-ncurses --with-curses-dir=$(STAGING_DIR)/usr \
-- 
2.24.0

[Buildroot] [PATCH] Revert "package/dialog: bump version to 1.3-20190808"

[Peter Korsgaard]

>>>>> "Paul" == Paul Cercueil <paul@crapouillou.net> writes:

 > The 1.3-20190808 version looks extremely buggy.
 > For instance, if you try to open a dialog using this command:
 > dialog --no-shadow --msgbox "test test test" 10 32

 > - the --no-shadow attribute doesn't seem to work anymore, since the
 >   frame will sill have a shadow,
 > - the text shown within the frame won't be "test test test" as expected,
 >   but "testtesttest".

 > These bugs make the program completely unusable, so revert to the last
 > known good version.

Funky. I gave it a try (using qemu_arm_versatile_defconfig with sourcery
codebench toolchain) and I indeed see the shadow but the text is
rendered correctly:

http://peter.korsgaard.com/dialog.png

And with the revert the shadow is indeed gone:

http://peter.korsgaard.com/dialog-old.png


Interesting enough, dialog on my (Debian, 1.3-20190211-1) laptop behaves
like the new version, so it also unconditionally adds the frame:

http://peter.korsgaard.com/dialog-debian.png

So I am not sure where you got the corrupted testtesttest from? What is
your TERM variable set to?

Anyway, I am OK with reverting, but it would be great if you could also:

- Contact upstream to get it fixed in future releases
- Add a runtime test for it

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] Revert "package/dialog: bump version to 1.3-20190808"

[Thomas Petazzoni]

On Fri,  6 Dec 2019 14:38:02 +0100
Paul Cercueil <paul@crapouillou.net> wrote:

> The 1.3-20190808 version looks extremely buggy.
> For instance, if you try to open a dialog using this command:
> dialog --no-shadow --msgbox "test test test" 10 32
> 
> - the --no-shadow attribute doesn't seem to work anymore, since the
>   frame will sill have a shadow,
> - the text shown within the frame won't be "test test test" as expected,
>   but "testtesttest".
> 
> These bugs make the program completely unusable, so revert to the last
> known good version.
> 
> This partly reverts commit 6a2ebcaf6a.
> 
> The license hash and URL update from ftp to https were not modified
> back.
> 
> Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
>  package/dialog/dialog.hash | 1 +
>  package/dialog/dialog.mk   | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)

Peter has submitted a version bump of the dialog package, which I have
just applied. It is supposed to fix the issues you've seen I believe.
Could you test it ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH] Revert "package/dialog: bump version to 1.3-20190808"

[Paul Cercueil]

Hi Thomas,


Le sam., d?c. 14, 2019 at 15:18, Thomas Petazzoni 
<thomas.petazzoni@bootlin.com> a ?crit :
> On Fri,  6 Dec 2019 14:38:02 +0100
> Paul Cercueil <paul@crapouillou.net> wrote:
> 
>>  The 1.3-20190808 version looks extremely buggy.
>>  For instance, if you try to open a dialog using this command:
>>  dialog --no-shadow --msgbox "test test test" 10 32
>> 
>>  - the --no-shadow attribute doesn't seem to work anymore, since the
>>    frame will sill have a shadow,
>>  - the text shown within the frame won't be "test test test" as 
>> expected,
>>    but "testtesttest".
>> 
>>  These bugs make the program completely unusable, so revert to the 
>> last
>>  known good version.
>> 
>>  This partly reverts commit 6a2ebcaf6a.
>> 
>>  The license hash and URL update from ftp to https were not modified
>>  back.
>> 
>>  Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
>>  Signed-off-by: Paul Cercueil <paul@crapouillou.net>
>>  ---
>>   package/dialog/dialog.hash | 1 +
>>   package/dialog/dialog.mk   | 2 +-
>>   2 files changed, 2 insertions(+), 1 deletion(-)
> 
> Peter has submitted a version bump of the dialog package, which I have
> just applied. It is supposed to fix the issues you've seen I believe.
> Could you test it ?

Yes, we were debugging it through emails with the author. The new 
version does fix the issues listed above.

Cheers,
-Paul


> 
> Thanks,
> 
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com