Re: [REPOST PATCH 0/4] usb: dwc2: Turn on uframe sched everywhere

From: Felipe Balbi <balbi@kernel.org>
To: Douglas Anderson <dianders@chromium.org>,
	hminas@synopsys.com, gregkh@linuxfoundation.org
Cc: stefan.wahren@i2se.com, grigor.tovmasyan@synopsys.com,
	Bruno Herrera <bruherrera@gmail.com>,
	Zhangfei Gao <zhangfei.gao@linaro.org>,
	john.stultz@linaro.org, Stephen Warren <swarren@wwwdotorg.org>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Douglas Anderson <dianders@chromium.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [REPOST PATCH 0/4] usb: dwc2: Turn on uframe sched everywhere
Date: Fri, 27 Jul 2018 13:01:32 +0300	[thread overview]
Message-ID: <87zhydxair.fsf@linux.intel.com> (raw)
In-Reply-To: <20180726200730.18290-1-dianders@chromium.org>

[-- Attachment #1: Type: text/plain, Size: 1325 bytes --]

Douglas Anderson <dianders@chromium.org> writes:

> While looking at a dwc2 recently, I noticed that some platforms still
> have the uframe scheduler off.  As far as I know, nothing good can
> come out of having the uframe scheduler off.  Let's turn it on
> everywhere.  Assuming this all works out then some time in the future
> we can gut all the old code that handles the old non-uframe scheduler
> and make everything simpler.
>
> This is a repost of the original "RFT" (request for testing) series I
> posted a few weeks ago but without the "RFT" prefix.  Two of the
> patches in the series now have "Tested-by:" tags.  Since there should
> be nothing platform specific about the uFrame scheduler presumably
> this should mean we're good to go?  Specificaly note that in at least
> one of the "Tested-by" reports this patch caused a notable
> improvement.
>
> In response to the original RFT, some notes about testing this:
> - In general, try to have lots of things plugged in.
> - Plug many different keyboards / mice in.  See if keys are
>   dropped / mouse is jerky.
> - Try USB audio (ideally full speed, not high speed).  How is
>   the audio?
> - If you're brave, try a USB webcam.  How is the video?
>   ...maybe try including patches from crbug.com/820961 too.

Minas??

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]