All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Anholt <eric@anholt.net>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: dri-devel@lists.freedesktop.org, tom.cooksey@arm.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] drm/pl111: Initial drm/kms driver for pl111
Date: Tue, 21 Mar 2017 12:41:51 -0700	[thread overview]
Message-ID: <87zige1kow.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <20170321172700.GC21222@n2100.armlinux.org.uk>

[-- Attachment #1: Type: text/plain, Size: 917 bytes --]

Russell King - ARM Linux <linux@armlinux.org.uk> writes:

> On Mon, Mar 20, 2017 at 04:36:14PM -0700, Eric Anholt wrote:
>> +static struct amba_driver pl111_amba_driver = {
>> +	.drv = {
>> +		.name = "clcd-pl11x",
>
> either:
>
> 		.name = "clcd-pl111",
>
> or:
>
> 		.name = "drm-clcd-pl111",
>
> otherwise the driver names will clash in sysfs - driver names must be
> unique.
>
>> +	},
>> +	.probe = pl111_amba_probe,
>> +	.remove = pl111_amba_remove,
>> +	.id_table = pl111_id_table,
>> +};
>> +#endif /* CONFIG_ARM_AMBA */
>> +
>> +module_amba_driver(pl111_amba_driver);
>> +
>> +MODULE_DESCRIPTION(DRIVER_DESC);
>> +MODULE_AUTHOR("ARM Ltd.");
>> +MODULE_LICENSE("GPL");
>> +MODULE_ALIAS("platform:pl111_drm");
>
> Does the platform alias make sense for an OF-only driver?

Not sure, this is left over from the original submission.

If I renamed to drm-clcd-pl111 and dropped the alias, would that get
your ack?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Eric Anholt <eric@anholt.net>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 2/3] drm/pl111: Initial drm/kms driver for pl111
Date: Tue, 21 Mar 2017 12:41:51 -0700	[thread overview]
Message-ID: <87zige1kow.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <20170321172700.GC21222@n2100.armlinux.org.uk>


[-- Attachment #1.1: Type: text/plain, Size: 917 bytes --]

Russell King - ARM Linux <linux@armlinux.org.uk> writes:

> On Mon, Mar 20, 2017 at 04:36:14PM -0700, Eric Anholt wrote:
>> +static struct amba_driver pl111_amba_driver = {
>> +	.drv = {
>> +		.name = "clcd-pl11x",
>
> either:
>
> 		.name = "clcd-pl111",
>
> or:
>
> 		.name = "drm-clcd-pl111",
>
> otherwise the driver names will clash in sysfs - driver names must be
> unique.
>
>> +	},
>> +	.probe = pl111_amba_probe,
>> +	.remove = pl111_amba_remove,
>> +	.id_table = pl111_id_table,
>> +};
>> +#endif /* CONFIG_ARM_AMBA */
>> +
>> +module_amba_driver(pl111_amba_driver);
>> +
>> +MODULE_DESCRIPTION(DRIVER_DESC);
>> +MODULE_AUTHOR("ARM Ltd.");
>> +MODULE_LICENSE("GPL");
>> +MODULE_ALIAS("platform:pl111_drm");
>
> Does the platform alias make sense for an OF-only driver?

Not sure, this is left over from the original submission.

If I renamed to drm-clcd-pl111 and dropped the alias, would that get
your ack?

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2017-03-21 19:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-20 23:36 [PATCH v3 1/3] video: ARM CLCD: Move registers to a separate header Eric Anholt
2017-03-20 23:36 ` Eric Anholt
2017-03-20 23:36 ` [PATCH v3 2/3] drm/pl111: Initial drm/kms driver for pl111 Eric Anholt
2017-03-20 23:36   ` Eric Anholt
2017-03-21 17:27   ` Russell King - ARM Linux
2017-03-21 19:41     ` Eric Anholt [this message]
2017-03-21 19:41       ` Eric Anholt
2017-03-20 23:36 ` [PATCH v3 3/3] drm: Clarify the role of plane_state argument to drm_simple update() Eric Anholt
2017-03-20 23:36   ` Eric Anholt
2017-03-21  7:27   ` Daniel Vetter
2017-03-21  7:27     ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zige1kow.fsf@eliezer.anholt.net \
    --to=eric@anholt.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=tom.cooksey@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.