All of lore.kernel.org
 help / color / mirror / Atom feed
From: Francisco Jerez <currojerez@riseup.net>
To: Lukas Wunner <lukas@wunner.de>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 14/15] drm/i2c/ch7006: Use helper to turn off CRTC
Date: Sat, 11 Jun 2016 14:57:58 -0700	[thread overview]
Message-ID: <87ziqrtml5.fsf@riseup.net> (raw)
In-Reply-To: <ec7d5c06e2a21dfb8f9fc9413d3e6df86d6aa1fb.1465392124.git.lukas@wunner.de>


[-- Attachment #1.1.1: Type: text/plain, Size: 1071 bytes --]

Lukas Wunner <lukas@wunner.de> writes:

> Use shiny new drm_crtc_force_disable() instead of open coding the same.
> No functional change intended.
>
> Cc: Francisco Jerez <currojerez@riseup.net>
> Signed-off-by: Lukas Wunner <lukas@wunner.de>

Reviewed-by: Francisco Jerez <currojerez@riseup.net>

> ---
>  drivers/gpu/drm/i2c/ch7006_drv.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i2c/ch7006_drv.c b/drivers/gpu/drm/i2c/ch7006_drv.c
> index 0594c45..e9e8ae2 100644
> --- a/drivers/gpu/drm/i2c/ch7006_drv.c
> +++ b/drivers/gpu/drm/i2c/ch7006_drv.c
> @@ -361,13 +361,8 @@ static int ch7006_encoder_set_property(struct drm_encoder *encoder,
>  
>  		/* Disable the crtc to ensure a full modeset is
>  		 * performed whenever it's turned on again. */
> -		if (crtc) {
> -			struct drm_mode_set modeset = {
> -				.crtc = crtc,
> -			};
> -
> -			drm_mode_set_config_internal(&modeset);
> -		}
> +		if (crtc)
> +			drm_crtc_force_disable(crtc);
>  	}
>  
>  	return 0;
> -- 
> 2.8.1

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 212 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2016-06-11 21:58 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-08 16:47 [PATCH v2 00/15] Runtime pm ref leak bonanza Lukas Wunner
2016-06-08 16:47 ` [PATCH v2 09/15] drm: Add helpers to turn off CRTCs Lukas Wunner
     [not found] ` <cover.1465392124.git.lukas-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2016-06-08 16:47   ` [PATCH v2 02/15] drm/nouveau: Forbid runtime pm on driver unload Lukas Wunner
2016-06-08 16:47   ` [PATCH v2 15/15] drm/nouveau/dispnv04: Use helper to turn off CRTC Lukas Wunner
2016-06-08 16:47   ` [PATCH v2 10/15] drm/nouveau: Turn off CRTCs on driver unload Lukas Wunner
2016-06-09  6:50   ` [PATCH v2 00/15] Runtime pm ref leak bonanza Daniel Vetter
     [not found]     ` <20160609065032.GI3363-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2016-06-09  7:20       ` Ben Skeggs
2016-06-14 20:18       ` Alex Deucher
     [not found]         ` <CADnq5_NENZukwJg-CACQ-djWsP4e299gnr4aWrEJkdcVMeaZWA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-06-15 11:37           ` Lukas Wunner
     [not found]             ` <20160615113735.GA562-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2016-06-15 15:11               ` Daniel Vetter
     [not found]                 ` <20160615151154.GF1338-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2016-06-22 12:44                   ` Lukas Wunner
     [not found]                     ` <20160622124447.GA3267-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2016-06-22 12:43                       ` Daniel Vetter
2016-06-08 16:47 ` [PATCH v2 14/15] drm/i2c/ch7006: Use helper to turn off CRTC Lukas Wunner
2016-06-11 21:57   ` Francisco Jerez [this message]
2016-06-08 16:47 ` [PATCH v2 08/15] drm/amdgpu: Forbid runtime pm on driver unload Lukas Wunner
2016-06-08 16:47 ` [PATCH v2 07/15] drm/amdgpu: Don't leak runtime pm ref on driver load Lukas Wunner
2016-06-08 16:47 ` [PATCH v2 03/15] drm/radeon: Don't leak runtime pm ref on driver unload Lukas Wunner
2016-06-08 16:47 ` [PATCH v2 04/15] drm/radeon: Don't leak runtime pm ref on driver load Lukas Wunner
2016-06-08 16:47 ` [PATCH v2 05/15] drm/radeon: Forbid runtime pm on driver unload Lukas Wunner
2016-06-08 16:47 ` [PATCH v2 11/15] drm/radeon: Turn off CRTCs " Lukas Wunner
2016-06-08 16:47 ` [PATCH v2 13/15] drm: Use helper to turn off CRTC Lukas Wunner
2016-06-08 16:47 ` [PATCH v2 01/15] drm/nouveau: Don't leak runtime pm ref on driver unload Lukas Wunner
2016-06-08 16:47 ` [PATCH v2 12/15] drm/amdgpu: Turn off CRTCs " Lukas Wunner
2016-06-08 16:47 ` [PATCH v2 06/15] drm/amdgpu: Don't leak runtime pm ref " Lukas Wunner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ziqrtml5.fsf@riseup.net \
    --to=currojerez@riseup.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=lukas@wunner.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.