* [PATCH] ASoC: qcom: remove incorrect dependencies
@ 2015-05-21 9:07 ` Arnd Bergmann
0 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2015-05-21 9:07 UTC (permalink / raw)
To: broonie, lgirdwood
Cc: alsa-devel, linux-arm-kernel, linux-arm-msm, Kenneth Westfield,
Banajit Goswami
Compile-tests show a warning for the newly added SND_SOC_STORM
symbol:
warning: (SND_SOC_STORM) selects SND_SOC_LPASS_CPU which has unmet direct dependencies (SOUND && !M68K && !UML && SND && SND_SOC && SND_SOC_QCOM)
The problem is that it can be selected for COMPILE_TEST on non-QCOM
builds, but the symbols it selects have a dependency.
Dropping the dependencies makes it work without warnings and no
other side-effects, because these are not user-visible.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: f380dd3f3cd ("ASoC: qcom: Add ability to build QCOM drivers")
diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig
index 5f58e4f1bca9..b07f183fc47f 100644
--- a/sound/soc/qcom/Kconfig
+++ b/sound/soc/qcom/Kconfig
@@ -6,12 +6,10 @@ config SND_SOC_QCOM
config SND_SOC_LPASS_CPU
tristate
- depends on SND_SOC_QCOM
select REGMAP_MMIO
config SND_SOC_LPASS_PLATFORM
tristate
- depends on SND_SOC_QCOM
select REGMAP_MMIO
config SND_SOC_STORM
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] ASoC: qcom: remove incorrect dependencies
@ 2015-05-21 9:07 ` Arnd Bergmann
0 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2015-05-21 9:07 UTC (permalink / raw)
To: linux-arm-kernel
Compile-tests show a warning for the newly added SND_SOC_STORM
symbol:
warning: (SND_SOC_STORM) selects SND_SOC_LPASS_CPU which has unmet direct dependencies (SOUND && !M68K && !UML && SND && SND_SOC && SND_SOC_QCOM)
The problem is that it can be selected for COMPILE_TEST on non-QCOM
builds, but the symbols it selects have a dependency.
Dropping the dependencies makes it work without warnings and no
other side-effects, because these are not user-visible.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: f380dd3f3cd ("ASoC: qcom: Add ability to build QCOM drivers")
diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig
index 5f58e4f1bca9..b07f183fc47f 100644
--- a/sound/soc/qcom/Kconfig
+++ b/sound/soc/qcom/Kconfig
@@ -6,12 +6,10 @@ config SND_SOC_QCOM
config SND_SOC_LPASS_CPU
tristate
- depends on SND_SOC_QCOM
select REGMAP_MMIO
config SND_SOC_LPASS_PLATFORM
tristate
- depends on SND_SOC_QCOM
select REGMAP_MMIO
config SND_SOC_STORM
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] ASoC: qcom: remove incorrect dependencies
2015-05-21 9:07 ` Arnd Bergmann
@ 2015-05-21 11:00 ` Mark Brown
-1 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2015-05-21 11:00 UTC (permalink / raw)
To: Arnd Bergmann
Cc: lgirdwood, alsa-devel, linux-arm-kernel, linux-arm-msm,
Kenneth Westfield, Banajit Goswami
[-- Attachment #1: Type: text/plain, Size: 156 bytes --]
On Thu, May 21, 2015 at 11:07:08AM +0200, Arnd Bergmann wrote:
> Compile-tests show a warning for the newly added SND_SOC_STORM
> symbol:
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ASoC: qcom: remove incorrect dependencies
@ 2015-05-21 11:00 ` Mark Brown
0 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2015-05-21 11:00 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, May 21, 2015 at 11:07:08AM +0200, Arnd Bergmann wrote:
> Compile-tests show a warning for the newly added SND_SOC_STORM
> symbol:
Applied, thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150521/bb9362c9/attachment.sig>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ASoC: qcom: remove incorrect dependencies
2015-05-21 9:07 ` Arnd Bergmann
@ 2015-05-21 21:00 ` Kenneth Westfield
-1 siblings, 0 replies; 8+ messages in thread
From: Kenneth Westfield @ 2015-05-21 21:00 UTC (permalink / raw)
To: Arnd Bergmann
Cc: broonie, lgirdwood, alsa-devel, linux-arm-kernel, linux-arm-msm,
Kenneth Westfield, Banajit Goswami
On Thu, May 21, 2015 at 11:07:08AM +0200, Arnd Bergmann wrote:
> Compile-tests show a warning for the newly added SND_SOC_STORM
> symbol:
>
> warning: (SND_SOC_STORM) selects SND_SOC_LPASS_CPU which has unmet direct dependencies (SOUND && !M68K && !UML && SND && SND_SOC && SND_SOC_QCOM)
>
> The problem is that it can be selected for COMPILE_TEST on non-QCOM
> builds, but the symbols it selects have a dependency.
> Dropping the dependencies makes it work without warnings and no
> other side-effects, because these are not user-visible.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: f380dd3f3cd ("ASoC: qcom: Add ability to build QCOM drivers")
>
> diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig
> index 5f58e4f1bca9..b07f183fc47f 100644
> --- a/sound/soc/qcom/Kconfig
> +++ b/sound/soc/qcom/Kconfig
> @@ -6,12 +6,10 @@ config SND_SOC_QCOM
>
> config SND_SOC_LPASS_CPU
> tristate
> - depends on SND_SOC_QCOM
Rather than remove the dependency (which I would like to keep), would
the following change work for SND_SOC_LPASS_CPU and
SND_SOC_LPASS_PLATFORM?
- depends on SND_SOC_QCOM
+ depends on SND_SOC_QCOM || COMPILE_TEST
If so, I will submit a patch (I know this has been applied already) on
top of this one.
> select REGMAP_MMIO
>
> config SND_SOC_LPASS_PLATFORM
> tristate
> - depends on SND_SOC_QCOM
> select REGMAP_MMIO
>
> config SND_SOC_STORM
>
--
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ASoC: qcom: remove incorrect dependencies
@ 2015-05-21 21:00 ` Kenneth Westfield
0 siblings, 0 replies; 8+ messages in thread
From: Kenneth Westfield @ 2015-05-21 21:00 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, May 21, 2015 at 11:07:08AM +0200, Arnd Bergmann wrote:
> Compile-tests show a warning for the newly added SND_SOC_STORM
> symbol:
>
> warning: (SND_SOC_STORM) selects SND_SOC_LPASS_CPU which has unmet direct dependencies (SOUND && !M68K && !UML && SND && SND_SOC && SND_SOC_QCOM)
>
> The problem is that it can be selected for COMPILE_TEST on non-QCOM
> builds, but the symbols it selects have a dependency.
> Dropping the dependencies makes it work without warnings and no
> other side-effects, because these are not user-visible.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: f380dd3f3cd ("ASoC: qcom: Add ability to build QCOM drivers")
>
> diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig
> index 5f58e4f1bca9..b07f183fc47f 100644
> --- a/sound/soc/qcom/Kconfig
> +++ b/sound/soc/qcom/Kconfig
> @@ -6,12 +6,10 @@ config SND_SOC_QCOM
>
> config SND_SOC_LPASS_CPU
> tristate
> - depends on SND_SOC_QCOM
Rather than remove the dependency (which I would like to keep), would
the following change work for SND_SOC_LPASS_CPU and
SND_SOC_LPASS_PLATFORM?
- depends on SND_SOC_QCOM
+ depends on SND_SOC_QCOM || COMPILE_TEST
If so, I will submit a patch (I know this has been applied already) on
top of this one.
> select REGMAP_MMIO
>
> config SND_SOC_LPASS_PLATFORM
> tristate
> - depends on SND_SOC_QCOM
> select REGMAP_MMIO
>
> config SND_SOC_STORM
>
--
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ASoC: qcom: remove incorrect dependencies
2015-05-21 21:00 ` Kenneth Westfield
@ 2015-05-21 21:23 ` Arnd Bergmann
-1 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2015-05-21 21:23 UTC (permalink / raw)
To: Kenneth Westfield
Cc: broonie, lgirdwood, alsa-devel, linux-arm-kernel, linux-arm-msm,
Banajit Goswami
On Thursday 21 May 2015 14:00:00 Kenneth Westfield wrote:
> > diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig
> > index 5f58e4f1bca9..b07f183fc47f 100644
> > --- a/sound/soc/qcom/Kconfig
> > +++ b/sound/soc/qcom/Kconfig
> > @@ -6,12 +6,10 @@ config SND_SOC_QCOM
> >
> > config SND_SOC_LPASS_CPU
> > tristate
> > - depends on SND_SOC_QCOM
>
> Rather than remove the dependency (which I would like to keep), would
> the following change work for SND_SOC_LPASS_CPU and
> SND_SOC_LPASS_PLATFORM?
> - depends on SND_SOC_QCOM
> + depends on SND_SOC_QCOM || COMPILE_TEST
>
> If so, I will submit a patch (I know this has been applied already) on
> top of this one.
>
That would have the same effect, but what is the point? Do you plan
to make these options user-visible in the future?
Arnd
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ASoC: qcom: remove incorrect dependencies
@ 2015-05-21 21:23 ` Arnd Bergmann
0 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2015-05-21 21:23 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday 21 May 2015 14:00:00 Kenneth Westfield wrote:
> > diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig
> > index 5f58e4f1bca9..b07f183fc47f 100644
> > --- a/sound/soc/qcom/Kconfig
> > +++ b/sound/soc/qcom/Kconfig
> > @@ -6,12 +6,10 @@ config SND_SOC_QCOM
> >
> > config SND_SOC_LPASS_CPU
> > tristate
> > - depends on SND_SOC_QCOM
>
> Rather than remove the dependency (which I would like to keep), would
> the following change work for SND_SOC_LPASS_CPU and
> SND_SOC_LPASS_PLATFORM?
> - depends on SND_SOC_QCOM
> + depends on SND_SOC_QCOM || COMPILE_TEST
>
> If so, I will submit a patch (I know this has been applied already) on
> top of this one.
>
That would have the same effect, but what is the point? Do you plan
to make these options user-visible in the future?
Arnd
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-05-21 21:23 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-21 9:07 [PATCH] ASoC: qcom: remove incorrect dependencies Arnd Bergmann
2015-05-21 9:07 ` Arnd Bergmann
2015-05-21 11:00 ` Mark Brown
2015-05-21 11:00 ` Mark Brown
2015-05-21 21:00 ` Kenneth Westfield
2015-05-21 21:00 ` Kenneth Westfield
2015-05-21 21:23 ` Arnd Bergmann
2015-05-21 21:23 ` Arnd Bergmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.