All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael Opdenacker" <michael.opdenacker@bootlin.com>
To: Khem Raj <raj.khem@gmail.com>, openembedded-core@lists.openembedded.org
Cc: YP docs mailing list <docs@lists.yoctoproject.org>
Subject: Re: [OE-core] [PATCH] musl: Set UPSTREAM_CHECK_COMMITS
Date: Mon, 14 Jun 2021 15:12:40 +0200	[thread overview]
Message-ID: <8825b363-ef7b-626c-908b-a2c6405410ff@bootlin.com> (raw)
In-Reply-To: <20210612221006.2888173-1-raj.khem@gmail.com>

Hi Khem

On 6/13/21 12:10 AM, Khem Raj wrote:
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/recipes-core/musl/musl_git.bb | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-core/musl/musl_git.bb b/meta/recipes-core/musl/musl_git.bb
> index 6569d1b37b..bd9d5f1d4b 100644
> --- a/meta/recipes-core/musl/musl_git.bb
> +++ b/meta/recipes-core/musl/musl_git.bb
> @@ -84,3 +84,5 @@ RPROVIDES_${PN} += "ldd libsegfault rtld(GNU_HASH)"
>  LEAD_SONAME = "libc.so"
>  INSANE_SKIP_${PN}-dev = "staticdev"
>  INSANE_SKIP_${PN} = "libdir"
> +
> +UPSTREAM_CHECK_COMMITS = "1"


Thanks for the patch.
Reviewed-by: Michael Opdenacker <michael.opdenacker@bootlin.com>

I realize that the UPSTREAM_CHECK_COMMITS variable doesn't appear in the
documentation, and it's in relatively frequent use.

Would it make sense to propose to add a description based on the initial
commit
(https://git.openembedded.org/openembedded-core/commit/?id=591d57877d3d3e659d78c0ed33f4c515e3f6f8fb)?

Thanks in advance,
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


  reply	other threads:[~2021-06-14 13:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-12 22:10 [PATCH] musl: Set UPSTREAM_CHECK_COMMITS Khem Raj
2021-06-14 13:12 ` Michael Opdenacker [this message]
2021-06-14 13:17   ` [docs] [OE-core] " Alexander Kanavin
2021-06-14 16:06     ` Michael Opdenacker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8825b363-ef7b-626c-908b-a2c6405410ff@bootlin.com \
    --to=michael.opdenacker@bootlin.com \
    --cc=docs@lists.yoctoproject.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.