[PATCH 0/3] ARM: dts: da850: Enable cppi41 dma

[PATCH 0/3] ARM: dts: da850: Enable cppi41 dma

[Alexandre Bailon]

This series enable support of cppi41 for da850.
The bindings and DT support are added in the series
"dmaengine: cppi41: Add dma support to da8xx".

Alexandre Bailon (3):
  ARM: dts: da850: Add the cppi41 dma node
  ARM: dts: da850: Add the cppi41 dma to the usb otg controller
  ARM: dts: da850: Enable cppi41 dma for da850-lcdk

 arch/arm/boot/dts/da850-lcdk.dts |  4 ++++
 arch/arm/boot/dts/da850.dtsi     | 24 ++++++++++++++++++++++++
 2 files changed, 28 insertions(+)

-- 
2.10.2

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/3] ARM: dts: da850: Add the cppi41 dma node

[Alexandre Bailon]

This adds the device tree node for the cppi41 dma
used by the usb otg controller present in the da850 family of SoC's.

Signed-off-by: Alexandre Bailon <abailon-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
---
 arch/arm/boot/dts/da850.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
index 104155d..d6b406a 100644
--- a/arch/arm/boot/dts/da850.dtsi
+++ b/arch/arm/boot/dts/da850.dtsi
@@ -403,6 +403,22 @@
 			phy-names = "usb-phy";
 			status = "disabled";
 		};
+		cppi41dma: dma-controller@201000 {
+			compatible = "ti,da8xx-cppi41";
+			reg =  <0x200000 0x1000
+				0x201000 0x1000
+				0x202000 0x1000
+				0x204000 0x4000>;
+			reg-names = "glue", "controller",
+				    "scheduler", "queuemgr";
+			interrupts = <58>;
+			interrupt-names = "glue";
+			#dma-cells = <2>;
+			#dma-channels = <4>;
+			#dma-requests = <256>;
+			status = "disabled";
+
+		};
 		mdio: mdio@224000 {
 			compatible = "ti,davinci_mdio";
 			#address-cells = <1>;
-- 
2.10.2

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] ARM: dts: da850: Add the cppi41 dma node

[Sergei Shtylyov]

Hello.

On 01/09/2017 07:24 PM, Alexandre Bailon wrote:

> This adds the device tree node for the cppi41 dma
> used by the usb otg controller present in the da850 family of SoC's.
>
> Signed-off-by: Alexandre Bailon <abailon-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
> ---
>  arch/arm/boot/dts/da850.dtsi | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
> index 104155d..d6b406a 100644
> --- a/arch/arm/boot/dts/da850.dtsi
> +++ b/arch/arm/boot/dts/da850.dtsi
> @@ -403,6 +403,22 @@
>  			phy-names = "usb-phy";
>  			status = "disabled";
>  		};
> +		cppi41dma: dma-controller@201000 {
> +			compatible = "ti,da8xx-cppi41";
> +			reg =  <0x200000 0x1000

    I don't remember any DA8xx glue regs having to do with the CPPI 4.1...

> +				0x201000 0x1000
> +				0x202000 0x1000
> +				0x204000 0x4000>;
> +			reg-names = "glue", "controller",
> +				    "scheduler", "queuemgr";
> +			interrupts = <58>;
> +			interrupt-names = "glue";
> +			#dma-cells = <2>;
> +			#dma-channels = <4>;
> +			#dma-requests = <256>;
> +			status = "disabled";

    Why disabled? It doesn't use any external pins...

[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] ARM: dts: da850: Add the cppi41 dma node

[Alexandre Bailon]

On 01/09/2017 07:26 PM, Sergei Shtylyov wrote:
> Hello.
> 
> On 01/09/2017 07:24 PM, Alexandre Bailon wrote:
> 
>> This adds the device tree node for the cppi41 dma
>> used by the usb otg controller present in the da850 family of SoC's.
>>
>> Signed-off-by: Alexandre Bailon <abailon-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
>> ---
>>  arch/arm/boot/dts/da850.dtsi | 16 ++++++++++++++++
>>  1 file changed, 16 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
>> index 104155d..d6b406a 100644
>> --- a/arch/arm/boot/dts/da850.dtsi
>> +++ b/arch/arm/boot/dts/da850.dtsi
>> @@ -403,6 +403,22 @@
>>              phy-names = "usb-phy";
>>              status = "disabled";
>>          };
>> +        cppi41dma: dma-controller@201000 {
>> +            compatible = "ti,da8xx-cppi41";
>> +            reg =  <0x200000 0x1000
> 
>    I don't remember any DA8xx glue regs having to do with the CPPI 4.1...
The CPPI 4.1 driver need it to manage the IRQ.
> 
>> +                0x201000 0x1000
>> +                0x202000 0x1000
>> +                0x204000 0x4000>;
>> +            reg-names = "glue", "controller",
>> +                    "scheduler", "queuemgr";
>> +            interrupts = <58>;
>> +            interrupt-names = "glue";
>> +            #dma-cells = <2>;
>> +            #dma-channels = <4>;
>> +            #dma-requests = <256>;
>> +            status = "disabled";
> 
>    Why disabled? It doesn't use any external pins...
Will fix it.
> 
> [...]
> 
> MBR, Sergei
> 

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] ARM: dts: da850: Add the cppi41 dma node

[Sekhar Nori]

On Tuesday 10 January 2017 07:15 PM, Alexandre Bailon wrote:
> On 01/09/2017 07:26 PM, Sergei Shtylyov wrote:

>>> +                0x201000 0x1000
>>> +                0x202000 0x1000
>>> +                0x204000 0x4000>;
>>> +            reg-names = "glue", "controller",
>>> +                    "scheduler", "queuemgr";
>>> +            interrupts = <58>;
>>> +            interrupt-names = "glue";
>>> +            #dma-cells = <2>;
>>> +            #dma-channels = <4>;
>>> +            #dma-requests = <256>;
>>> +            status = "disabled";
>>
>>    Why disabled? It doesn't use any external pins...

> Will fix it.

Please keep it disabled. See the other thread on this.

Thanks,
Sekhar
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] ARM: dts: da850: Add the cppi41 dma node

[David Lechner]

On 01/09/2017 12:26 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 01/09/2017 07:24 PM, Alexandre Bailon wrote:
>
>> This adds the device tree node for the cppi41 dma
>> used by the usb otg controller present in the da850 family of SoC's.
>>
>> Signed-off-by: Alexandre Bailon <abailon-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
>> ---
>>  arch/arm/boot/dts/da850.dtsi | 16 ++++++++++++++++
>>  1 file changed, 16 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
>> index 104155d..d6b406a 100644
>> --- a/arch/arm/boot/dts/da850.dtsi
>> +++ b/arch/arm/boot/dts/da850.dtsi
>> @@ -403,6 +403,22 @@
>>              phy-names = "usb-phy";
>>              status = "disabled";
>>          };
>> +        cppi41dma: dma-controller@201000 {
>> +            compatible = "ti,da8xx-cppi41";
>> +            reg =  <0x200000 0x1000
>
>    I don't remember any DA8xx glue regs having to do with the CPPI 4.1...
>
>> +                0x201000 0x1000
>> +                0x202000 0x1000
>> +                0x204000 0x4000>;
>> +            reg-names = "glue", "controller",
>> +                    "scheduler", "queuemgr";
>> +            interrupts = <58>;
>> +            interrupt-names = "glue";
>> +            #dma-cells = <2>;
>> +            #dma-channels = <4>;
>> +            #dma-requests = <256>;
>> +            status = "disabled";
>
>    Why disabled? It doesn't use any external pins...

Why enable it if musb node is not also enabled?

>
> [...]
>
> MBR, Sergei
>

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] ARM: dts: da850: Add the cppi41 dma node

[Sergei Shtylyov]

On 01/10/2017 07:15 PM, David Lechner wrote:

>>> This adds the device tree node for the cppi41 dma
>>> used by the usb otg controller present in the da850 family of SoC's.
>>>
>>> Signed-off-by: Alexandre Bailon <abailon-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
>>> ---
>>>  arch/arm/boot/dts/da850.dtsi | 16 ++++++++++++++++
>>>  1 file changed, 16 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
>>> index 104155d..d6b406a 100644
>>> --- a/arch/arm/boot/dts/da850.dtsi
>>> +++ b/arch/arm/boot/dts/da850.dtsi
>>> @@ -403,6 +403,22 @@
>>>              phy-names = "usb-phy";
>>>              status = "disabled";
>>>          };
>>> +        cppi41dma: dma-controller@201000 {
>>> +            compatible = "ti,da8xx-cppi41";
>>> +            reg =  <0x200000 0x1000
>>
>>    I don't remember any DA8xx glue regs having to do with the CPPI 4.1...
>>
>>> +                0x201000 0x1000
>>> +                0x202000 0x1000
>>> +                0x204000 0x4000>;
>>> +            reg-names = "glue", "controller",
>>> +                    "scheduler", "queuemgr";
>>> +            interrupts = <58>;
>>> +            interrupt-names = "glue";
>>> +            #dma-cells = <2>;
>>> +            #dma-channels = <4>;
>>> +            #dma-requests = <256>;
>>> +            status = "disabled";
>>
>>    Why disabled? It doesn't use any external pins...
>
> Why enable it if musb node is not also enabled?

    Well, it's a good point.

>> [...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/3] ARM: dts: da850: Add the cppi41 dma to the usb otg controller

[Alexandre Bailon]

This adds the cppi41 dma controller to the usb otg controller.

Signed-off-by: Alexandre Bailon <abailon-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
---
 arch/arm/boot/dts/da850.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
index d6b406a..0ed0cb9 100644
--- a/arch/arm/boot/dts/da850.dtsi
+++ b/arch/arm/boot/dts/da850.dtsi
@@ -402,6 +402,14 @@
 			phys = <&usb_phy 0>;
 			phy-names = "usb-phy";
 			status = "disabled";
+
+			dmas = <&cppi41dma 0 0 &cppi41dma 1 0
+				&cppi41dma 2 0 &cppi41dma 3 0
+				&cppi41dma 0 1 &cppi41dma 1 1
+				&cppi41dma 2 1 &cppi41dma 3 1>;
+			dma-names =
+				"rx1", "rx2", "rx3", "rx4",
+				"tx1", "tx2", "tx3", "tx4";
 		};
 		cppi41dma: dma-controller@201000 {
 			compatible = "ti,da8xx-cppi41";
-- 
2.10.2

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 3/3] ARM: dts: da850: Enable cppi41 dma for da850-lcdk

[Alexandre Bailon]

This enable the cppi41 dma controller used by the usb otg for
the da850-lcdk board.

Signed-off-by: Alexandre Bailon <abailon-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
---
 arch/arm/boot/dts/da850-lcdk.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/da850-lcdk.dts b/arch/arm/boot/dts/da850-lcdk.dts
index afcb482..abb9b9d 100644
--- a/arch/arm/boot/dts/da850-lcdk.dts
+++ b/arch/arm/boot/dts/da850-lcdk.dts
@@ -167,6 +167,10 @@
 	status = "okay";
 };
 
+&cppi41dma  {
+	status = "okay";
+};
+
 &aemif {
 	pinctrl-names = "default";
 	pinctrl-0 = <&nand_pins>;
-- 
2.10.2

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/3] ARM: dts: da850: Enable cppi41 dma for da850-lcdk

[David Lechner]

On 01/09/2017 10:24 AM, Alexandre Bailon wrote:
> This enable the cppi41 dma controller used by the usb otg for
> the da850-lcdk board.
>
> Signed-off-by: Alexandre Bailon <abailon-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
> ---
>  arch/arm/boot/dts/da850-lcdk.dts | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/da850-lcdk.dts b/arch/arm/boot/dts/da850-lcdk.dts
> index afcb482..abb9b9d 100644
> --- a/arch/arm/boot/dts/da850-lcdk.dts
> +++ b/arch/arm/boot/dts/da850-lcdk.dts
> @@ -167,6 +167,10 @@
>  	status = "okay";
>  };
>
> +&cppi41dma  {

nit, there should only be one space before "{"

> +	status = "okay";
> +};
> +
>  &aemif {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&nand_pins>;
>

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html