[PATCH] xfs_scrub: fix complaint about uninitialized ret

[PATCH] xfs_scrub: fix complaint about uninitialized ret

[Darrick J. Wong]

From: Darrick J. Wong <darrick.wong@oracle.com>

Coverity complained about the uninitialized ret in run_scrub_phases.
It's not sophisticated enough to realize that phase 1 and 7 are both
marked mustrun and are never the repair or datascan dummies and that
therefore ret is always initialized by the end of the for loop, but
OTOH there's no reason not to fix a trivial logic bomb if that ever
changes.

Coverity-id: 1455255
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 scrub/xfs_scrub.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scrub/xfs_scrub.c b/scrub/xfs_scrub.c
index a792768c..014c54dd 100644
--- a/scrub/xfs_scrub.c
+++ b/scrub/xfs_scrub.c
@@ -422,7 +422,7 @@ run_scrub_phases(
 	unsigned int		debug_phase = 0;
 	unsigned int		phase;
 	int			rshift;
-	int			ret;
+	int			ret = 0;
 
 	if (debug_tweak_on("XFS_SCRUB_PHASE"))
 		debug_phase = atoi(getenv("XFS_SCRUB_PHASE"));

Re: [PATCH] xfs_scrub: fix complaint about uninitialized ret

[Eric Sandeen]

On 11/7/19 3:30 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Coverity complained about the uninitialized ret in run_scrub_phases.
> It's not sophisticated enough to realize that phase 1 and 7 are both
> marked mustrun and are never the repair or datascan dummies and that
> therefore ret is always initialized by the end of the for loop, but
> OTOH there's no reason not to fix a trivial logic bomb if that ever
> changes.
> 
> Coverity-id: 1455255
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

> ---
>  scrub/xfs_scrub.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scrub/xfs_scrub.c b/scrub/xfs_scrub.c
> index a792768c..014c54dd 100644
> --- a/scrub/xfs_scrub.c
> +++ b/scrub/xfs_scrub.c
> @@ -422,7 +422,7 @@ run_scrub_phases(
>  	unsigned int		debug_phase = 0;
>  	unsigned int		phase;
>  	int			rshift;
> -	int			ret;
> +	int			ret = 0;
>  
>  	if (debug_tweak_on("XFS_SCRUB_PHASE"))
>  		debug_phase = atoi(getenv("XFS_SCRUB_PHASE"));
>