* [PATCH] media: exynos4-is: Fix recursive locking in isp_video_release()
[not found] <CGME20191018101825epcas1p3fc6c1d01b4d898ebd0db64527e17b536@epcas1p3.samsung.com>
@ 2019-10-18 10:20 ` Seung-Woo Kim
2019-10-18 10:32 ` Sylwester Nawrocki
0 siblings, 1 reply; 2+ messages in thread
From: Seung-Woo Kim @ 2019-10-18 10:20 UTC (permalink / raw)
To: linux-media, linux-samsung-soc, s.nawrocki, mchehab, krzk; +Cc: sw0312.kim
From isp_video_release(), &isp->video_lock is held and subsequent
vb2_fop_release() tries to lock vdev->lock which is same with the
previous one. Replace vb2_fop_release() with _vb2_fop_release() to
fix the recursive locking.
Fixes: 1380f5754cb0 ("[media] videobuf2: Add missing lock held on vb2_fop_release")
Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
---
drivers/media/platform/exynos4-is/fimc-isp-video.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/platform/exynos4-is/fimc-isp-video.c b/drivers/media/platform/exynos4-is/fimc-isp-video.c
index 378cc30..d2cbcdc 100644
--- a/drivers/media/platform/exynos4-is/fimc-isp-video.c
+++ b/drivers/media/platform/exynos4-is/fimc-isp-video.c
@@ -313,7 +313,7 @@ static int isp_video_release(struct file *file)
ivc->streaming = 0;
}
- vb2_fop_release(file);
+ _vb2_fop_release(file, NULL);
if (v4l2_fh_is_singular_file(file)) {
fimc_pipeline_call(&ivc->ve, close);
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: exynos4-is: Fix recursive locking in isp_video_release()
2019-10-18 10:20 ` [PATCH] media: exynos4-is: Fix recursive locking in isp_video_release() Seung-Woo Kim
@ 2019-10-18 10:32 ` Sylwester Nawrocki
0 siblings, 0 replies; 2+ messages in thread
From: Sylwester Nawrocki @ 2019-10-18 10:32 UTC (permalink / raw)
To: Seung-Woo Kim, linux-media; +Cc: linux-samsung-soc, mchehab, krzk
On 10/18/19 12:20, Seung-Woo Kim wrote:
>>From isp_video_release(), &isp->video_lock is held and subsequent
> vb2_fop_release() tries to lock vdev->lock which is same with the
> previous one. Replace vb2_fop_release() with _vb2_fop_release() to
> fix the recursive locking.
>
> Fixes: 1380f5754cb0 ("[media] videobuf2: Add missing lock held on vb2_fop_release")
> Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-18 10:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20191018101825epcas1p3fc6c1d01b4d898ebd0db64527e17b536@epcas1p3.samsung.com>
2019-10-18 10:20 ` [PATCH] media: exynos4-is: Fix recursive locking in isp_video_release() Seung-Woo Kim
2019-10-18 10:32 ` Sylwester Nawrocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.