* [PATCH] x86/kdump: fix wrong judge about crash_size var
@ 2021-08-13 7:12 Xin Hao
2021-08-24 2:31 ` Xin Hao
0 siblings, 1 reply; 2+ messages in thread
From: Xin Hao @ 2021-08-13 7:12 UTC (permalink / raw)
To: tglx; +Cc: mingo, bp, hpa, x86, linux-kernel
The type of crash_size is unsigned long long, so
it can not be less than 0, so there fix it.
Signed-off-by: Xin Hao <xhao@linux.alibaba.com>
---
arch/x86/kernel/setup.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index bff3a784aec5..95b80ec11741 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -472,11 +472,11 @@ static void __init reserve_crashkernel(void)
/* crashkernel=XM */
ret = parse_crashkernel(boot_command_line, total_mem, &crash_size, &crash_base);
- if (ret != 0 || crash_size <= 0) {
+ if (ret != 0 || !crash_size) {
/* crashkernel=X,high */
ret = parse_crashkernel_high(boot_command_line, total_mem,
&crash_size, &crash_base);
- if (ret != 0 || crash_size <= 0)
+ if (ret != 0 || !crash_size)
return;
high = true;
}
--
2.31.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] x86/kdump: fix wrong judge about crash_size var
2021-08-13 7:12 [PATCH] x86/kdump: fix wrong judge about crash_size var Xin Hao
@ 2021-08-24 2:31 ` Xin Hao
0 siblings, 0 replies; 2+ messages in thread
From: Xin Hao @ 2021-08-24 2:31 UTC (permalink / raw)
To: tglx; +Cc: mingo, bp, hpa, x86, linux-kernel
Hi, everyone:
Why nobody review this patch?
在 2021/8/13 下午3:12, Xin Hao 写道:
> The type of crash_size is unsigned long long, so
> it can not be less than 0, so there fix it.
>
> Signed-off-by: Xin Hao <xhao@linux.alibaba.com>
> ---
> arch/x86/kernel/setup.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index bff3a784aec5..95b80ec11741 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -472,11 +472,11 @@ static void __init reserve_crashkernel(void)
>
> /* crashkernel=XM */
> ret = parse_crashkernel(boot_command_line, total_mem, &crash_size, &crash_base);
> - if (ret != 0 || crash_size <= 0) {
> + if (ret != 0 || !crash_size) {
> /* crashkernel=X,high */
> ret = parse_crashkernel_high(boot_command_line, total_mem,
> &crash_size, &crash_base);
> - if (ret != 0 || crash_size <= 0)
> + if (ret != 0 || !crash_size)
> return;
> high = true;
> }
> --
> 2.31.0
--
Best Regards!
Xin Hao
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-24 2:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-13 7:12 [PATCH] x86/kdump: fix wrong judge about crash_size var Xin Hao
2021-08-24 2:31 ` Xin Hao
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.