All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Kevin Brodsky <kevin.brodsky@arm.com>,
	Andrey Konovalov <andreyknvl@google.com>,
	linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org,
	linux-media@vger.kernel.org, kvm@vger.kernel.org,
	linux-kselftest@vger.kernel.org
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Vincenzo Frascino <vincenzo.frascino@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Kees Cook <keescook@chromium.org>,
	Yishai Hadas <yishaih@mellanox.com>,
	Felix Kuehling <Felix.Kuehling@amd.com>,
	Alexander Deucher <Alexander.Deucher@amd.com>,
	Christian Koenig <Christian.Koenig@amd.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Jens Wiklander <jens.wiklander@linaro.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Leon Romanovsky <leon@kernel.org>,
	Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
	Dave Martin <Dave.Martin@arm.com>,
	Khalid Aziz <khalid.aziz@oracle.com>, enh <enh@google.com>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	Christoph Hellwig <hch@infradead.org>,
	Dmitry Vyukov <dvyukov@google.com>,
	Kostya Serebryany <kcc@google.com>,
	Evgeniy Stepanov <eugenis@google.com>,
	Lee Smith <Lee.Smith@arm.com>,
	Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>,
	Jacob Bramley <Jacob.Bramley@arm.com>,
	Ruben Ayrapetyan <Ruben.Ayrapetyan@arm.com>,
	Robin Murphy <robin.murphy@arm.com>,
	Szabolcs Nagy <Szabolcs.Nagy@arm.com>
Subject: Re: [PATCH v19 02/15] arm64: Introduce prctl() options to control the tagged user addresses ABI
Date: Thu, 1 Aug 2019 09:45:05 -0700	[thread overview]
Message-ID: <88c59d1e-eda9-fcfe-5ee3-64a331f34313@intel.com> (raw)
In-Reply-To: <2b274c6f-6023-8eb8-5a86-507e6000e13d@arm.com>

On 8/1/19 5:38 AM, Kevin Brodsky wrote:
> This patch series only changes what is allowed or not at the syscall
> interface. It does not change the address space size. On arm64, TBI (Top
> Byte Ignore) has always been enabled for userspace, so it has never been
> possible to use the upper 8 bits of user pointers for addressing.

Oh, so does the address space that's available already chop that out?

> If other architectures were to support a similar functionality, then I
> agree that a common and more generic interface (if needed) would be
> helpful, but as it stands this is an arm64-specific prctl, and on arm64
> the address tag is defined by the architecture as bits [63:56].

It should then be an arch_prctl(), no?

WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave.hansen@intel.com>
To: Kevin Brodsky <kevin.brodsky@arm.com>,
	Andrey Konovalov <andreyknvl@google.com>,
	linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org,
	linux-media@vger.kernel.org, kvm@vger.kernel.org,
	linux-kselftest@vger.kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>,
	Szabolcs Nagy <Szabolcs.Nagy@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Kostya Serebryany <kcc@google.com>,
	Khalid Aziz <khalid.aziz@oracle.com>,
	Felix Kuehling <Felix.Kuehling@amd.com>,
	Vincenzo Frascino <vincenzo.frascino@arm.com>,
	Jacob Bramley <Jacob.Bramley@arm.com>,
	Leon Romanovsky <leon@kernel.org>,
	Christoph Hellwig <hch@infradead.org>,
	Jason Gunthorpe <jgg@ziepe.ca>, Dave Martin <Dave.Martin@arm.com>,
	Evgeniy Stepanov <eugenis@google.com>,
	Kees Cook <keescook@chromium.org>,
	Ruben Ayrapetyan <Ruben.Ayrapetyan@arm.com>,
	Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Dmitry Vyukov <dvyukov@google.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Yishai Hadas <yishaih@mellanox.com>,
	Jens Wiklander <jens.wiklander@linaro.org>,
	Lee Smith <Lee.Smith@arm.com>,
	Alexander Deucher <Alexander.Deucher@amd.com>,
	Andrew Morton <akpm@linux-foundation.org>, enh <enh@google.com>,
	Robin Murphy <robin.murphy@arm.com>,
	Christian Koenig <Christian.Koenig@amd.com>,
	Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Subject: Re: [PATCH v19 02/15] arm64: Introduce prctl() options to control the tagged user addresses ABI
Date: Thu, 1 Aug 2019 09:45:05 -0700	[thread overview]
Message-ID: <88c59d1e-eda9-fcfe-5ee3-64a331f34313@intel.com> (raw)
In-Reply-To: <2b274c6f-6023-8eb8-5a86-507e6000e13d@arm.com>

On 8/1/19 5:38 AM, Kevin Brodsky wrote:
> This patch series only changes what is allowed or not at the syscall
> interface. It does not change the address space size. On arm64, TBI (Top
> Byte Ignore) has always been enabled for userspace, so it has never been
> possible to use the upper 8 bits of user pointers for addressing.

Oh, so does the address space that's available already chop that out?

> If other architectures were to support a similar functionality, then I
> agree that a common and more generic interface (if needed) would be
> helpful, but as it stands this is an arm64-specific prctl, and on arm64
> the address tag is defined by the architecture as bits [63:56].

It should then be an arch_prctl(), no?

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave.hansen@intel.com>
To: Kevin Brodsky <kevin.brodsky@arm.com>,
	Andrey Konovalov <andreyknvl@google.com>,
	linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org,
	linux-media@vger.kernel.org, kvm@vger.kernel.org,
	linux-kselftest@vger.kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>,
	Szabolcs Nagy <Szabolcs.Nagy@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Kostya Serebryany <kcc@google.com>,
	Khalid Aziz <khalid.aziz@oracle.com>,
	Felix Kuehling <Felix.Kuehling@amd.com>,
	Vincenzo Frascino <vincenzo.frascino@arm.com>,
	Jacob Bramley <Jacob.Bramley@arm.com>,
	Leon Romanovsky <leon@kernel.org>,
	Christoph Hellwig <hch@infradead.org>,
	Jason Gunthorpe <jgg@ziepe.ca>, Dave Martin <Dave.Martin@arm.com>,
	Evgeniy Stepanov <eugenis@google.com>,
	Kees Cook <keescook@chromium.org>,
	Ruben Ayrapetyan <Ruben.Ayrapetyan@arm.com>,
	Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Dmitry Vyukov <dvyukov@google.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Yishai Hadas <yishaih@mellanox.com>,
	Je
Subject: Re: [PATCH v19 02/15] arm64: Introduce prctl() options to control the tagged user addresses ABI
Date: Thu, 1 Aug 2019 09:45:05 -0700	[thread overview]
Message-ID: <88c59d1e-eda9-fcfe-5ee3-64a331f34313@intel.com> (raw)
In-Reply-To: <2b274c6f-6023-8eb8-5a86-507e6000e13d@arm.com>

On 8/1/19 5:38 AM, Kevin Brodsky wrote:
> This patch series only changes what is allowed or not at the syscall
> interface. It does not change the address space size. On arm64, TBI (Top
> Byte Ignore) has always been enabled for userspace, so it has never been
> possible to use the upper 8 bits of user pointers for addressing.

Oh, so does the address space that's available already chop that out?

> If other architectures were to support a similar functionality, then I
> agree that a common and more generic interface (if needed) would be
> helpful, but as it stands this is an arm64-specific prctl, and on arm64
> the address tag is defined by the architecture as bits [63:56].

It should then be an arch_prctl(), no?
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2019-08-01 16:45 UTC|newest]

Thread overview: 175+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-23 17:58 [PATCH v19 00/15] arm64: untag user pointers passed to the kernel Andrey Konovalov
2019-07-23 17:58 ` Andrey Konovalov
2019-07-23 17:58 ` Andrey Konovalov
2019-07-23 17:58 ` Andrey Konovalov
2019-07-23 17:58 ` [PATCH v19 01/15] arm64: untag user pointers in access_ok and __uaccess_mask_ptr Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58 ` [PATCH v19 02/15] arm64: Introduce prctl() options to control the tagged user addresses ABI Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-31 17:05   ` Dave Hansen
2019-07-31 17:05     ` Dave Hansen
2019-07-31 17:05     ` Dave Hansen
2019-08-01 12:38     ` Kevin Brodsky
2019-08-01 12:38       ` Kevin Brodsky
2019-08-01 12:38       ` Kevin Brodsky
2019-08-01 16:45       ` Dave Hansen [this message]
2019-08-01 16:45         ` Dave Hansen
2019-08-01 16:45         ` Dave Hansen
2019-08-02 10:50         ` Catalin Marinas
2019-08-02 10:50           ` Catalin Marinas
2019-08-02 10:50           ` Catalin Marinas
2019-08-09 16:08   ` Catalin Marinas
2019-08-09 16:08     ` Catalin Marinas
2019-08-09 16:08     ` Catalin Marinas
2019-07-23 17:58 ` [PATCH v19 03/15] lib: untag user pointers in strn*_user Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58 ` [PATCH v19 04/15] mm: untag user pointers passed to memory syscalls Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-08-09 16:03   ` Catalin Marinas
2019-08-09 16:03     ` Catalin Marinas
2019-08-09 16:03     ` Catalin Marinas
2019-07-23 17:58 ` [PATCH v19 05/15] mm: untag user pointers in mm/gup.c Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58 ` [PATCH v19 06/15] mm: untag user pointers in get_vaddr_frames Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58 ` [PATCH v19 07/15] fs/namespace: untag user pointers in copy_mount_options Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58 ` [PATCH v19 08/15] userfaultfd: untag user pointers Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58 ` [PATCH v19 09/15] drm/amdgpu: " Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58 ` [PATCH v19 10/15] drm/radeon: untag user pointers in radeon_gem_userptr_ioctl Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58 ` [PATCH v19 11/15] IB/mlx4: untag user pointers in mlx4_get_umem_mr Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-24 19:25   ` Jason Gunthorpe
2019-07-24 19:25     ` Jason Gunthorpe
2019-07-24 19:25     ` Jason Gunthorpe
2019-07-25 11:17     ` Andrey Konovalov
2019-07-25 11:17       ` Andrey Konovalov
2019-07-25 11:17       ` Andrey Konovalov
2019-07-25 11:17       ` Andrey Konovalov
2019-07-23 17:58 ` [PATCH v19 12/15] media/v4l2-core: untag user pointers in videobuf_dma_contig_user_get Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58 ` [PATCH v19 13/15] tee/shm: untag user pointers in tee_shm_register Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58 ` [PATCH v19 14/15] vfio/type1: untag user pointers in vaddr_get_pfn Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58 ` [PATCH v19 15/15] selftests, arm64: add a selftest for passing tagged pointers to kernel Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 17:58   ` Andrey Konovalov
2019-07-23 18:03 ` [PATCH v19 00/15] arm64: untag user pointers passed to the kernel Andrey Konovalov
2019-07-23 18:03   ` Andrey Konovalov
2019-07-23 18:03   ` Andrey Konovalov
2019-07-23 18:03   ` Andrey Konovalov
2019-07-24 14:02   ` Will Deacon
2019-07-24 14:02     ` Will Deacon
2019-07-24 14:02     ` Will Deacon
2019-07-24 14:02     ` Will Deacon
2019-07-24 14:16     ` Andrey Konovalov
2019-07-24 14:16       ` Andrey Konovalov
2019-07-24 14:16       ` Andrey Konovalov
2019-07-24 14:16       ` Andrey Konovalov
2019-07-24 14:20       ` Will Deacon
2019-07-24 14:20         ` Will Deacon
2019-07-24 14:20         ` Will Deacon
2019-07-24 14:20         ` Will Deacon
2019-07-24 17:12         ` Vincenzo Frascino
2019-07-24 17:12           ` Vincenzo Frascino
2019-07-24 17:12           ` Vincenzo Frascino
2019-07-24 17:12           ` Vincenzo Frascino
2019-08-06 17:13         ` Will Deacon
2019-08-06 17:13           ` Will Deacon
2019-08-06 17:13           ` Will Deacon
2019-08-06 17:13           ` Will Deacon
2019-08-07 17:17           ` Andrey Konovalov
2019-08-07 17:17             ` Andrey Konovalov
2019-08-07 17:17             ` Andrey Konovalov
2019-08-07 17:17             ` Andrey Konovalov
2019-08-08 21:12             ` Kees Cook
2019-08-08 21:12               ` Kees Cook
2019-08-08 21:12               ` Kees Cook
2019-08-08 21:12               ` Kees Cook
2019-08-08 22:33               ` Andrew Morton
2019-08-08 22:33                 ` Andrew Morton
2019-08-08 22:33                 ` Andrew Morton
2019-08-08 22:33                 ` Andrew Morton
2019-08-08 23:09                 ` Kees Cook
2019-08-08 23:09                   ` Kees Cook
2019-08-08 23:09                   ` Kees Cook
2019-08-08 23:09                   ` Kees Cook
2019-08-09  9:00                   ` Catalin Marinas
2019-08-09  9:00                     ` Catalin Marinas
2019-08-09  9:00                     ` Catalin Marinas
2019-08-09  9:00                     ` Catalin Marinas
2019-08-09  9:28                     ` Dave Martin
2019-08-09  9:28                       ` Dave Martin
2019-08-09  9:28                       ` Dave Martin
2019-08-09  9:28                       ` Dave Martin
2019-07-25 13:50 ` [PATCH v6 0/2] arm64 relaxed ABI Vincenzo Frascino
2019-07-25 13:50   ` Vincenzo Frascino
2019-07-25 13:50   ` [PATCH v6 1/2] arm64: Define Documentation/arm64/tagged-address-abi.rst Vincenzo Frascino
2019-07-25 13:50     ` Vincenzo Frascino
2019-07-30 10:32     ` Kevin Brodsky
2019-07-30 10:32       ` Kevin Brodsky
2019-07-30 13:25       ` Vincenzo Frascino
2019-07-30 13:25         ` Vincenzo Frascino
2019-07-30 13:57         ` Kevin Brodsky
2019-07-30 13:57           ` Kevin Brodsky
2019-07-30 14:24           ` Vincenzo Frascino
2019-07-30 14:24             ` Vincenzo Frascino
2019-07-30 14:48             ` Kevin Brodsky
2019-07-30 14:48               ` Kevin Brodsky
2019-07-31 16:43     ` Dave Hansen
2019-07-31 16:43       ` Dave Hansen
2019-08-02 10:08       ` Catalin Marinas
2019-08-02 10:08         ` Catalin Marinas
2019-07-25 13:50   ` [PATCH v6 2/2] arm64: Relax Documentation/arm64/tagged-pointers.rst Vincenzo Frascino
2019-07-25 13:50     ` Vincenzo Frascino
2019-07-31 16:50 ` [PATCH v19 00/15] arm64: untag user pointers passed to the kernel Dave Hansen
2019-07-31 16:50   ` Dave Hansen
2019-07-31 16:50   ` Dave Hansen
2019-08-01 12:11   ` Kevin Brodsky
2019-08-01 12:11     ` Kevin Brodsky
2019-08-01 12:11     ` Kevin Brodsky
2019-08-01 12:48     ` Andrey Konovalov
2019-08-01 12:48       ` Andrey Konovalov
2019-08-01 12:48       ` Andrey Konovalov
2019-08-01 12:48       ` Andrey Konovalov
2019-08-01 15:36       ` Dave Hansen
2019-08-01 15:36         ` Dave Hansen
2019-08-01 15:36         ` Dave Hansen
2019-08-01 15:36         ` Dave Hansen
2019-08-02 10:20         ` Catalin Marinas
2019-08-02 10:20           ` Catalin Marinas
2019-08-02 10:20           ` Catalin Marinas
2019-08-02 10:20           ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=88c59d1e-eda9-fcfe-5ee3-64a331f34313@intel.com \
    --to=dave.hansen@intel.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=Christian.Koenig@amd.com \
    --cc=Dave.Martin@arm.com \
    --cc=Felix.Kuehling@amd.com \
    --cc=Jacob.Bramley@arm.com \
    --cc=Lee.Smith@arm.com \
    --cc=Ramana.Radhakrishnan@arm.com \
    --cc=Ruben.Ayrapetyan@arm.com \
    --cc=Szabolcs.Nagy@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=alex.williamson@redhat.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=andreyknvl@google.com \
    --cc=catalin.marinas@arm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=dvyukov@google.com \
    --cc=enh@google.com \
    --cc=eugenis@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@infradead.org \
    --cc=jens.wiklander@linaro.org \
    --cc=jgg@ziepe.ca \
    --cc=kcc@google.com \
    --cc=keescook@chromium.org \
    --cc=kevin.brodsky@arm.com \
    --cc=khalid.aziz@oracle.com \
    --cc=kvm@vger.kernel.org \
    --cc=leon@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=luc.vanoostenryck@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=mchehab@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=vincenzo.frascino@arm.com \
    --cc=will.deacon@arm.com \
    --cc=yishaih@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.