* [PATCH] xen-platform: constify pci_device_id.
@ 2017-08-02 17:46 Arvind Yadav
2017-08-02 22:36 ` Boris Ostrovsky
2017-08-02 22:36 ` Boris Ostrovsky
0 siblings, 2 replies; 6+ messages in thread
From: Arvind Yadav @ 2017-08-02 17:46 UTC (permalink / raw)
To: boris.ostrovsky, jgross; +Cc: xen-devel, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/xen/platform-pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/xen/platform-pci.c b/drivers/xen/platform-pci.c
index 1275df8..5d7dcad 100644
--- a/drivers/xen/platform-pci.c
+++ b/drivers/xen/platform-pci.c
@@ -175,7 +175,7 @@ static int platform_pci_probe(struct pci_dev *pdev,
return ret;
}
-static struct pci_device_id platform_pci_tbl[] = {
+static const struct pci_device_id platform_pci_tbl[] = {
{PCI_VENDOR_ID_XEN, PCI_DEVICE_ID_XEN_PLATFORM,
PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
{0,}
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] xen-platform: constify pci_device_id.
2017-08-02 17:46 [PATCH] xen-platform: constify pci_device_id Arvind Yadav
@ 2017-08-02 22:36 ` Boris Ostrovsky
2017-08-02 22:36 ` Boris Ostrovsky
1 sibling, 0 replies; 6+ messages in thread
From: Boris Ostrovsky @ 2017-08-02 22:36 UTC (permalink / raw)
To: Arvind Yadav, jgross; +Cc: xen-devel, linux-kernel
On 08/02/2017 01:46 PM, Arvind Yadav wrote:
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xen-platform: constify pci_device_id.
2017-08-02 17:46 [PATCH] xen-platform: constify pci_device_id Arvind Yadav
2017-08-02 22:36 ` Boris Ostrovsky
@ 2017-08-02 22:36 ` Boris Ostrovsky
2017-08-16 15:04 ` Boris Ostrovsky
2017-08-16 15:04 ` Boris Ostrovsky
1 sibling, 2 replies; 6+ messages in thread
From: Boris Ostrovsky @ 2017-08-02 22:36 UTC (permalink / raw)
To: Arvind Yadav, jgross; +Cc: xen-devel, linux-kernel
On 08/02/2017 01:46 PM, Arvind Yadav wrote:
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xen-platform: constify pci_device_id.
2017-08-02 22:36 ` Boris Ostrovsky
@ 2017-08-16 15:04 ` Boris Ostrovsky
2017-08-16 15:04 ` Boris Ostrovsky
1 sibling, 0 replies; 6+ messages in thread
From: Boris Ostrovsky @ 2017-08-16 15:04 UTC (permalink / raw)
To: Arvind Yadav, jgross; +Cc: xen-devel, linux-kernel
On 08/02/2017 06:36 PM, Boris Ostrovsky wrote:
> On 08/02/2017 01:46 PM, Arvind Yadav wrote:
>> pci_device_id are not supposed to change at runtime. All functions
>> working with pci_device_id provided by <linux/pci.h> work with
>> const pci_device_id. So mark the non-const structs as const.
>>
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Applied to for-linus-4.14.
-boris
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xen-platform: constify pci_device_id.
2017-08-02 22:36 ` Boris Ostrovsky
2017-08-16 15:04 ` Boris Ostrovsky
@ 2017-08-16 15:04 ` Boris Ostrovsky
1 sibling, 0 replies; 6+ messages in thread
From: Boris Ostrovsky @ 2017-08-16 15:04 UTC (permalink / raw)
To: Arvind Yadav, jgross; +Cc: xen-devel, linux-kernel
On 08/02/2017 06:36 PM, Boris Ostrovsky wrote:
> On 08/02/2017 01:46 PM, Arvind Yadav wrote:
>> pci_device_id are not supposed to change at runtime. All functions
>> working with pci_device_id provided by <linux/pci.h> work with
>> const pci_device_id. So mark the non-const structs as const.
>>
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Applied to for-linus-4.14.
-boris
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] xen-platform: constify pci_device_id.
@ 2017-08-02 17:46 Arvind Yadav
0 siblings, 0 replies; 6+ messages in thread
From: Arvind Yadav @ 2017-08-02 17:46 UTC (permalink / raw)
To: boris.ostrovsky, jgross; +Cc: xen-devel, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/xen/platform-pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/xen/platform-pci.c b/drivers/xen/platform-pci.c
index 1275df8..5d7dcad 100644
--- a/drivers/xen/platform-pci.c
+++ b/drivers/xen/platform-pci.c
@@ -175,7 +175,7 @@ static int platform_pci_probe(struct pci_dev *pdev,
return ret;
}
-static struct pci_device_id platform_pci_tbl[] = {
+static const struct pci_device_id platform_pci_tbl[] = {
{PCI_VENDOR_ID_XEN, PCI_DEVICE_ID_XEN_PLATFORM,
PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
{0,}
--
2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-08-16 15:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-02 17:46 [PATCH] xen-platform: constify pci_device_id Arvind Yadav
2017-08-02 22:36 ` Boris Ostrovsky
2017-08-02 22:36 ` Boris Ostrovsky
2017-08-16 15:04 ` Boris Ostrovsky
2017-08-16 15:04 ` Boris Ostrovsky
2017-08-02 17:46 Arvind Yadav
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.